CDRIVER-5709 remove cursor returning command helpers (#1919)

Removes `mongoc_client_command`, `mongoc_database_command`, and `mongoc_collection_command`.

Author: kevinAlbs

NEWS

@@ -17,6 +17,7 @@ Unreleased (2.0.0)
 * `MONGOC_QUERY_SLAVE_OK` is removed. Use the equivalent `MONGOC_QUERY_SECONDARY_OK` instead.
 * `MONGOC_URI_SLAVEOK` is removed. It was unused.
 * `mongoc_collection_save` is removed. Use `mongoc_collection_insert_one` or `mongoc_collection_replace_one` instead.
+* `mongoc_client_command`, `mongoc_database_command`, and `mongoc_collection_command` are removed. Use `mongoc_client_command_simple`,  `mongoc_database_command_simple`, and `mongoc_collection_command_simple` instead.
 * `MONGOC_URI_MAXIDLETIMEMS` and `MONGOC_URI_WAITQUEUEMULTIPLE` are removed. They were unused.
 * `bson_string_t` and associated functions are removed.
 * `mongoc_cursor_is_alive` is removed. Use the equivalent `mongoc_cursor_more` instead.

src/libmongoc/CMakeLists.txt

@@ -1340,11 +1340,6 @@ if (ENABLE_EXAMPLES AND ENABLE_SHARED)
    # examples/tutorial
    mongoc_add_example (executing ${PROJECT_SOURCE_DIR}/examples/tutorial/executing.c)
    mongoc_add_example (appending ${PROJECT_SOURCE_DIR}/examples/tutorial/appending.c)
-   mongoc_add_example (migrating ${PROJECT_SOURCE_DIR}/examples/migrating.c)
-   # Ignore deprecation warnings in migrating examples. Migrating examples deliberately call deprecated API to show how to migrate.
-   target_compile_options (migrating
-      PRIVATE $<$<NOT:$<C_COMPILER_ID:MSVC>>:-Wno-deprecated-declarations>
-   )
 endif ()
 
 if (ENABLE_TESTS AND ENABLE_SHARED AND MONGOC_ENABLE_SSL AND NOT WIN32)

src/libmongoc/doc/mongoc_client_command.rst

@@ -16,7 +16,7 @@ Synopsis
                                 bson_t *reply,
                                 bson_error_t *error);
 
-This is a simplified interface to :symbol:`mongoc_client_command()`. It returns the first document from the result cursor into ``reply``. The client's read preference, read concern, and write concern are not applied to the command.
+The client's read preference, read concern, and write concern are not applied to the command.
 
 .. warning::
 

src/libmongoc/doc/mongoc_client_command_simple.rst

@@ -53,7 +53,6 @@ Example
     :maxdepth: 1
 
     mongoc_client_bulkwrite_new
-    mongoc_client_command
     mongoc_client_command_simple
     mongoc_client_command_simple_with_server_id
     mongoc_client_command_with_opts

src/libmongoc/doc/mongoc_client_t.rst

@@ -27,7 +27,7 @@ Parameters
 Description
 -----------
 
-This is a simplified version of :symbol:`mongoc_collection_command()` that returns the first result document in ``reply``. The collection's read preference, read concern, and write concern are not applied to the command. The parameter ``reply`` is initialized even upon failure to simplify memory management.
+The collection's read preference, read concern, and write concern are not applied to the command. The parameter ``reply`` is initialized even upon failure to simplify memory management.
 
 This function tries to unwrap an embedded error in the command when possible. The unwrapped error will be propagated via the ``error`` parameter. Additionally, the result document is set in ``reply``.
 

src/libmongoc/doc/mongoc_collection_command.rst

@@ -27,7 +27,6 @@ Read preferences and write concerns are inherited from the parent client. They c
     :maxdepth: 1
 
     mongoc_collection_aggregate
-    mongoc_collection_command
     mongoc_collection_command_simple
     mongoc_collection_command_with_opts
     mongoc_collection_copy

src/libmongoc/doc/mongoc_collection_command_simple.rst

@@ -24,7 +24,7 @@ Parameters
 * ``reply``: A |bson_t-opt-storage-ptr| to contain the results.
 * ``error``: An optional location for a :symbol:`bson_error_t <errors>` or ``NULL``.
 
-This is a simplified interface to :symbol:`mongoc_database_command()` that returns the first result document. The database's read preference, read concern, and write concern are not applied to the command.  The parameter ``reply`` is initialized even upon failure to simplify memory management.
+The database's read preference, read concern, and write concern are not applied to the command.  The parameter ``reply`` is initialized even upon failure to simplify memory management.
 
 .. include:: includes/not-retryable-read.txt