CDRIVER-709 add MONGOC_ERROR_DUPLICATE_KEY

Author: ajdavis

NEWS

@@ -20,6 +20,7 @@ New features and bug fixes:
   * connectTimeoutMS timer now begins after DNS resolution, and resets
     for each interface attempted (e.g., if the driver first tries IPv6,
     then IPv4).
+  * New error code MONGOC_ERROR_DUPLICATE_KEY.
   * mongoc_collection_find no longer treats the "filter" key specially in
     queries - querying for a document with a key named "filter" is the same
     now as any other key.

doc/mongoc_errors.page

@@ -195,6 +195,15 @@
           <p>You tried to use a command option the server does not support.</p>
         </td>
       </tr>
+      <tr>
+        <td />
+        <td>
+          <p><code>MONGOC_ERROR_DUPLICATE_KEY</code></p>
+        </td>
+        <td>
+          <p>An insert or update failed because because of a duplicate <code>_id</code> or other unique-index violation.</p>
+        </td>
+      </tr>
       <tr>
         <td>
           <p><em style="strong"><code>MONGOC_ERROR_COMMAND</code></em></p>

src/mongoc/mongoc-error.h

@@ -108,6 +108,8 @@ typedef enum
    MONGOC_ERROR_PROTOCOL_ERROR = 17,
 
    MONGOC_ERROR_WRITE_CONCERN_ERROR = 64,
+
+   MONGOC_ERROR_DUPLICATE_KEY = 11000,
 } mongoc_error_code_t;
 
 

src/mongoc/mongoc-write-command.c

@@ -59,6 +59,16 @@ _mongoc_write_result_merge_arrays (uint32_t               offset,
                                    bson_t                *dest,
                                    bson_iter_t           *iter);
 
+static bool
+_is_duplicate_key_error (int32_t code)
+{
+   return code == 11000 ||
+          code == 16460 || /* see SERVER-11493 */
+          code == 11001 || /* duplicate key for updates before 2.6 */
+          code == 12582;   /* mongos before 2.6 */
+}
+
+
 void
 _mongoc_write_command_insert_append (mongoc_write_command_t *command,
                                      const bson_t           *document)
@@ -1590,6 +1600,10 @@ _mongoc_write_result_merge_legacy (mongoc_write_result_t  *result,  /* IN */
       code = bson_iter_int32 (&iter);
    }
 
+   if (_is_duplicate_key_error (code)) {
+      code = MONGOC_ERROR_DUPLICATE_KEY;
+   }
+
    if (code || err) {
       if (!err) {
          err = "unknown error";

tests/test-mongoc-collection.c

@@ -4106,6 +4106,27 @@ test_index_with_collation_ok (void)
    test_index_with_collation (WIRE_VERSION_COLLATION);
 }
 
+static void
+test_insert_duplicate_key (void)
+{
+   mongoc_client_t *client;
+   mongoc_collection_t *collection;
+   bson_error_t error;
+
+   client = test_framework_client_new ();
+   collection = get_test_collection (client, "test_insert_duplicate_key");
+   mongoc_collection_insert (collection, MONGOC_INSERT_NONE,
+                             tmp_bson ("{'_id': 1}"), NULL, NULL);
+
+   ASSERT (!mongoc_collection_insert (collection, MONGOC_INSERT_NONE,
+                                      tmp_bson ("{'_id': 1}"), NULL, &error));
+   ASSERT_CMPINT (error.domain, ==, MONGOC_ERROR_COMMAND);
+   ASSERT_CMPINT (error.code, ==, MONGOC_ERROR_DUPLICATE_KEY);
+
+   mongoc_collection_destroy (collection);
+   mongoc_client_destroy (client);
+}
+
 void
 test_collection_install (TestSuite *suite)
 {
@@ -4193,4 +4214,5 @@ test_collection_install (TestSuite *suite)
    TestSuite_AddFull (suite, "/Collection/command_fully_qualified", test_command_fq, NULL, NULL, test_framework_skip_if_mongos);
    TestSuite_AddLive (suite, "/Collection/get_index_info", test_get_index_info);
    TestSuite_Add (suite, "/Collection/find_indexes/error", test_find_indexes_err);
+   TestSuite_AddLive (suite, "/Collection/insert/duplicate_key", test_insert_duplicate_key);
 }