CDRIVER-1574 Remove --enable-hardening

Author: bjori

.evergreen/compile-unix.sh

@@ -59,7 +59,6 @@ RELEASE_FLAGS="\
    --enable-html-docs=no \
    --enable-extra-align=no \
    --enable-optimizations \
-   --enable-hardening \
    --disable-automatic-init-and-cleanup \
    --with-libbson=bundled \
 "

build/autotools/AutoHarden.m4

@@ -1,6 +1,9 @@
 OPTIMIZE_CFLAGS=""
 OPTIMIZE_LDFLAGS=""
 
+AC_DEFUN([check_link_flag],
+    [AX_CHECK_LINK_FLAG([$1], [$2], [$3], [-Werror $4])])
+
 dnl Check if we should use -Bsymbolic
 AS_IF([test "$enable_optimizations" != "no"], [
     check_link_flag([-Wl,-Bsymbolic], [OPTIMIZE_LDFLAGS="$OPTIMIZE_LDFLAGS -Wl,-Bsymbolic"])

build/autotools/Optimizations.m4

@@ -34,7 +34,6 @@ Build configuration:
   Enable debugging (slow)                          : ${enable_debug}
   Compile with debug symbols (slow)                : ${enable_debug_symbols}
   Enable GCC build optimization                    : ${enable_optimizations}
-  Enable automatic binary hardening                : ${enable_hardening}
   Enable automatic init and cleanup                : ${enable_automatic_init_and_cleanup}${automatic_init_deprecated}
   Code coverage support                            : ${enable_coverage}
   Cross Compiling                                  : ${enable_crosscompile}

build/autotools/PrintBuildConfiguration.m4

@@ -39,7 +39,6 @@ m4_include([build/autotools/ReadCommandLineArguments.m4])
 m4_include([build/autotools/CheckSasl.m4])
 m4_include([build/autotools/CheckSSL.m4])
 m4_include([build/autotools/FindDependencies.m4])
-m4_include([build/autotools/AutoHarden.m4])
 m4_include([build/autotools/MaintainerFlags.m4])
 m4_include([build/autotools/PlatformFlags.m4])
 m4_include([build/autotools/Optimizations.m4])

configure.ac

@@ -100,7 +100,6 @@ Build configuration:
 Enable debugging (slow)                          : no
 Compile with debug symbols (slow)                : no
 Enable GCC build optimization                    : yes
-Enable automatic binary hardening                : yes
 Code coverage support                            : no
 Cross Compiling                                  : no
 Fast counters                                    : no

doc/mongoc_installing.page.in

@@ -23,7 +23,6 @@ MONGOC_CPPFLAGS_SHARED = \
 	$(PTHREAD_CFLAGS) \
 	$(SSL_CFLAGS) \
 	$(SASL_CFLAGS) \
-	$(HARDEN_CFLAGS) \
 	-fvisibility=hidden
 
 if OS_SOLARIS
@@ -33,7 +32,7 @@ libmongoc_priv_la_CPPFLAGS = $(MONGOC_CPPFLAGS_SHARED)
 libmongoc_1_0_la_CPPFLAGS = $(MONGOC_CPPFLAGS_SHARED)
 
 
-MONGOC_LDFLAGS_SHARED = $(OPTIMIZE_LDFLAGS) $(COVERAGE_LDFLAGS) $(HARDEN_LDFLAGS)
+MONGOC_LDFLAGS_SHARED = $(OPTIMIZE_LDFLAGS) $(COVERAGE_LDFLAGS)
 libmongoc_priv_la_LDFLAGS = \
 	$(MONGOC_LDFLAGS_SHARED) \
 	-no-undefined