assert future_wait called before future_destroy

Author: ajdavis

build/future_function_templates/future.c.template

@@ -91,6 +91,8 @@ future_wait (future_t *future)
    mongoc_mutex_unlock (&future->mutex);
 
    if (resolved) {
+      future->awaited = true;
+
       /* free memory */
       mongoc_thread_join (future->thread);
    }
@@ -102,6 +104,7 @@ future_wait (future_t *future)
 void
 future_destroy (future_t *future)
 {
+   assert (future->awaited);
    bson_free (future->argv);
    mongoc_cond_destroy (&future->cond);
    mongoc_mutex_destroy (&future->mutex);

build/future_function_templates/future.h.template

@@ -11,6 +11,7 @@
 typedef struct
 {
    bool             resolved;
+   bool             awaited;
    future_value_t   return_value;
    int              argc;
    future_value_t  *argv;

tests/mock_server/future.c

@@ -328,6 +328,8 @@ future_wait (future_t *future)
    mongoc_mutex_unlock (&future->mutex);
 
    if (resolved) {
+      future->awaited = true;
+
       /* free memory */
       mongoc_thread_join (future->thread);
    }
@@ -339,6 +341,7 @@ future_wait (future_t *future)
 void
 future_destroy (future_t *future)
 {
+   assert (future->awaited);
    bson_free (future->argv);
    mongoc_cond_destroy (&future->cond);
    mongoc_mutex_destroy (&future->mutex);

tests/mock_server/future.h

@@ -17,6 +17,7 @@
 typedef struct
 {
    bool             resolved;
+   bool             awaited;
    future_value_t   return_value;
    int              argc;
    future_value_t  *argv;