CID-102165 (Coverity) fix unchecked return value

rcsanchez97 · rcsanchez97 · commit afeb4d5ac92d · 2018-07-18T09:13:50.000-04:00
diff --git a/src/libmongoc/tests/mock_server/request.c b/src/libmongoc/tests/mock_server/request.c
@@ -1133,8 +1133,7 @@ request_from_op_msg (request_t *request, const mongoc_rpc_t *rpc)
 
    if (request->docs.len) {
       doc = request_get_doc (request, 0);
-      bson_iter_init (&iter, doc);
-      if (bson_iter_next (&iter)) {
+      if (bson_iter_init (&iter, doc) && bson_iter_next (&iter)) {
          request->command_name = bson_strdup (bson_iter_key (&iter));
       }
    }

Original file line number	Diff line number	Diff line change
`@@ -1133,8 +1133,7 @@ request_from_op_msg (request_t request, const mongoc_rpc_t rpc)`
`1133`	`1133`
`1134`	`1134`	`if (request->docs.len) {`
`1135`	`1135`	`doc = request_get_doc (request, 0);`
`1136`		`- bson_iter_init (&iter, doc);`
`1137`		`- if (bson_iter_next (&iter)) {`
	`1136`	`+ if (bson_iter_init (&iter, doc) && bson_iter_next (&iter)) {`
`1138`	`1137`	`request->command_name = bson_strdup (bson_iter_key (&iter));`
`1139`	`1138`	`}`
`1140`	`1139`	`}`