CDRIVER-3513 saved errors in out parameter (#650)

saved errors and added test case

Author: Andrew Witten

src/libmongoc/src/mongoc/mongoc-cmd.c

@@ -116,6 +116,7 @@ mongoc_cmd_parts_append_opts (mongoc_cmd_parts_t *parts,
    uint32_t len;
    const uint8_t *data;
    bson_t read_concern;
+   const char *to_append;
 
    ENTRY;
 
@@ -184,7 +185,13 @@ mongoc_cmd_parts_append_opts (mongoc_cmd_parts_t *parts,
          continue;
       }
 
-      if (!bson_append_iter (&parts->extra, bson_iter_key (iter), -1, iter)) {
+      to_append = bson_iter_key (iter);
+      if (!bson_append_iter (&parts->extra, to_append, -1, iter)) {
+         bson_set_error (error,
+                         MONGOC_ERROR_COMMAND,
+                         MONGOC_ERROR_COMMAND_INVALID_ARG,
+                         "Failed to append \"%s\" to create command.",
+                         to_append);
          RETURN (false);
       }
    }

src/libmongoc/src/mongoc/mongoc-host-list.c

@@ -236,15 +236,31 @@ _mongoc_host_list_from_string_with_err (mongoc_host_list_t *link_,
       /* if present, the port should immediately follow after ] */
       sport = strchr (close_bracket, ':');
       if (sport > close_bracket + 1) {
+         bson_set_error (error,
+                         MONGOC_ERROR_COMMAND,
+                         MONGOC_ERROR_COMMAND_INVALID_ARG,
+                         "If present, port should immediately follow the \"]\""
+                         "in an IPv6 address"
+                         );
          return false;
       }
 
       /* otherwise ] should be the last char. */
       if (!sport && *(close_bracket + 1) != '\0') {
+         bson_set_error (error,
+                         MONGOC_ERROR_COMMAND,
+                         MONGOC_ERROR_COMMAND_INVALID_ARG,
+                         "If port is not supplied, \"[\" should be the last"
+                         "character");
          return false;
       }
 
       if (*address != '[') {
+         bson_set_error (error,
+                         MONGOC_ERROR_COMMAND,
+                         MONGOC_ERROR_COMMAND_INVALID_ARG,
+                         "Missing matching bracket \"[\""
+                         );
          return false;
       }
 
@@ -259,10 +275,20 @@ _mongoc_host_list_from_string_with_err (mongoc_host_list_t *link_,
    if (sport) {
       if (sport == address) {
          /* bad address like ":27017" */
+         bson_set_error (error,
+                         MONGOC_ERROR_COMMAND,
+                         MONGOC_ERROR_COMMAND_INVALID_ARG,
+                         "Bad address, \":\" should not be first character"
+                        );
          return false;
       }
 
       if (!mongoc_parse_port (&port, sport + 1)) {
+         bson_set_error (error,
+                         MONGOC_ERROR_COMMAND,
+                         MONGOC_ERROR_COMMAND_INVALID_ARG,
+                         "Port could not be parsed"
+                        );
          return false;
       }
 

src/libmongoc/src/mongoc/mongoc-topology-scanner.c

@@ -903,6 +903,10 @@ mongoc_topology_scanner_node_connect_unix (mongoc_topology_scanner_node_t *node,
                            0 /* delay */);
       RETURN (true);
    }
+   bson_set_error (error,
+                   MONGOC_ERROR_STREAM,
+                   MONGOC_ERROR_STREAM_CONNECT,
+                   "Failed to create TLS stream");
    RETURN (false);
 #endif
 }

src/libmongoc/src/mongoc/mongoc-uri.c

@@ -1127,6 +1127,11 @@ mongoc_uri_apply_options (mongoc_uri_t *uri,
             }
 
             if (!mongoc_uri_set_option_as_bool (uri, canon, bval)) {
+               bson_set_error (error,
+                               MONGOC_ERROR_COMMAND,
+                               MONGOC_ERROR_COMMAND_INVALID_ARG,
+                               "Failed to set %s to %d",
+                               canon, bval);
                return false;
             }
          } else {

src/libmongoc/tests/test-mongoc-uri.c

@@ -923,6 +923,13 @@ test_mongoc_host_list_from_string (void)
                         MONGOC_LOG_LEVEL_ERROR,
                         "Could not parse address");
 
+   capture_logs (true);
+   ASSERT (!_mongoc_host_list_from_string (&host_list, "[::1]extra_chars:27017"));
+   ASSERT_CAPTURED_LOG ("_mongoc_host_list_from_string",
+                        MONGOC_LOG_LEVEL_ERROR,
+                        "If present, port should immediately follow the \"]\""
+                           "in an IPv6 address");
+
    /* normal parsing, host and port are split, host is downcased */
    ASSERT (_mongoc_host_list_from_string (&host_list, "localHOST:27019"));
    ASSERT_CMPSTR (host_list.host_and_port, "localhost:27019");