CDRIVER-3373 Remove readConcern snapshot in sharded txn tests (#628)

Author: bazile-clyde

src/libmongoc/tests/json-test.c

@@ -1504,37 +1504,6 @@ _in_blacklist (const bson_t *test, char **blacklist, uint32_t blacklist_len)
 
    return false;
 }
-static bool
-_should_skip_due_to_server_39704 (const bson_t *test)
-{
-   char *blacklist[] = {
-      "only first countDocuments includes readConcern",
-      "only first find includes readConcern",
-      "only first aggregate includes readConcern",
-      "only first distinct includes readConcern",
-      "only first runCommand includes readConcern",
-      "transaction options inherited from defaultTransactionOptions",
-      "startTransaction options override defaults",
-      "defaultTransactionOptions override client options",
-      "readConcern snapshot in startTransaction options",
-      "withTransaction inherits transaction options from "
-      "defaultTransactionOptions",
-      "withTransaction explicit transaction options",
-      "withTransaction explicit transaction options override "
-      "defaultTransactionOptions",
-      "withTransaction explicit transaction options override client options"};
-
-   /* Only an issue for sharded clusters. */
-   if (!test_framework_is_mongos ()) {
-      return false;
-   }
-
-   if (_in_blacklist (test, blacklist, sizeof (blacklist) / sizeof (char *))) {
-      return true;
-   }
-
-   return false;
-}
 
 static bool
 _should_skip_due_to_unsupported_operation (const bson_t *test)
@@ -1632,14 +1601,6 @@ run_json_general_test (const json_test_config_t *config)
          continue;
       }
 
-      if (_should_skip_due_to_server_39704 (&test)) {
-         fprintf (stderr,
-                  " - %s SKIPPED, reason: SERVER-39704 causes sharded tests to "
-                  "fail when using readConcern: snapshot\n",
-                  description);
-         continue;
-      }
-
       if (_should_skip_due_to_unsupported_operation (&test)) {
          fprintf (
             stderr,

src/libmongoc/tests/json/transactions/read-concern.json

@@ -39,7 +39,7 @@
           "arguments": {
             "options": {
               "readConcern": {
-                "level": "snapshot"
+                "level": "majority"
               }
             }
           }
@@ -110,7 +110,7 @@
               "cursor": {},
               "lsid": "session0",
               "readConcern": {
-                "level": "snapshot"
+                "level": "majority"
               },
               "txnNumber": {
                 "$numberLong": "1"
@@ -202,7 +202,7 @@
           "arguments": {
             "options": {
               "readConcern": {
-                "level": "snapshot"
+                "level": "majority"
               }
             }
           }
@@ -274,7 +274,7 @@
               "batchSize": 3,
               "lsid": "session0",
               "readConcern": {
-                "level": "snapshot"
+                "level": "majority"
               },
               "txnNumber": {
                 "$numberLong": "1"
@@ -389,7 +389,7 @@
           "arguments": {
             "options": {
               "readConcern": {
-                "level": "snapshot"
+                "level": "majority"
               }
             }
           }
@@ -484,7 +484,7 @@
               },
               "lsid": "session0",
               "readConcern": {
-                "level": "snapshot"
+                "level": "majority"
               },
               "txnNumber": {
                 "$numberLong": "1"
@@ -608,7 +608,7 @@
           "arguments": {
             "options": {
               "readConcern": {
-                "level": "snapshot"
+                "level": "majority"
               }
             }
           }
@@ -664,7 +664,7 @@
               "key": "_id",
               "lsid": "session0",
               "readConcern": {
-                "level": "snapshot"
+                "level": "majority"
               },
               "txnNumber": {
                 "$numberLong": "1"
@@ -741,7 +741,7 @@
           "arguments": {
             "options": {
               "readConcern": {
-                "level": "snapshot"
+                "level": "majority"
               }
             }
           }
@@ -780,7 +780,7 @@
               "find": "test",
               "lsid": "session0",
               "readConcern": {
-                "level": "snapshot"
+                "level": "majority"
               },
               "txnNumber": {
                 "$numberLong": "1"