CDRIVER-2060: Validate that localThresholdMS URI option is non-negative

Author: jmikola

src/mongoc/mongoc-uri.c

@@ -1265,6 +1265,11 @@ mongoc_uri_get_local_threshold_option (const mongoc_uri_t *uri)
        BSON_ITER_HOLDS_INT32 (&iter)) {
 
       retval = bson_iter_int32 (&iter);
+
+      if (retval < 0) {
+         MONGOC_WARNING ("Invalid localThresholdMS: %d", retval);
+         retval = MONGOC_TOPOLOGY_LOCAL_THRESHOLD_MS;
+      }
    }
 
    return retval;

tests/test-mongoc-uri.c

@@ -1089,6 +1089,19 @@ test_mongoc_uri_local_threshold_ms (void)
    ASSERT_CMPINT (mongoc_uri_get_local_threshold_option (uri), ==, 99);
 
    mongoc_uri_destroy(uri);
+
+
+   uri = mongoc_uri_new(
+      "mongodb://localhost/?" MONGOC_URI_LOCALTHRESHOLDMS "=-1");
+
+   /* localthresholdms is invalid, return the default */
+   capture_logs (true);
+   ASSERT_CMPINT (mongoc_uri_get_local_threshold_option (uri), ==,
+      MONGOC_TOPOLOGY_LOCAL_THRESHOLD_MS);
+   ASSERT_CAPTURED_LOG ("mongoc_uri_get_local_threshold_option",
+      MONGOC_LOG_LEVEL_WARNING, "Invalid localThresholdMS: -1");
+
+   mongoc_uri_destroy(uri);
 }
 
 void