Skip to content

Commit e9863ec

Browse files
committed
Improve skip-if for topology variations
1 parent dbb2584 commit e9863ec

File tree

2 files changed

+27
-6
lines changed

2 files changed

+27
-6
lines changed

tests/test-libmongoc.c

Lines changed: 24 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1001,12 +1001,6 @@ test_framework_is_replset (void)
10011001
return is_replset;
10021002
}
10031003

1004-
int
1005-
test_framework_skip_if_single (void)
1006-
{
1007-
return (test_framework_is_mongos () || test_framework_is_replset());
1008-
}
1009-
10101004
bool
10111005
test_framework_server_is_secondary (mongoc_client_t *client,
10121006
uint32_t server_id)
@@ -1173,6 +1167,12 @@ test_version_cmp (void)
11731167
ASSERT (v3_2_0_rc1_pre < test_framework_str_to_version ("3.2"));
11741168
}
11751169

1170+
int
1171+
test_framework_skip_if_single (void)
1172+
{
1173+
return (test_framework_is_mongos () || test_framework_is_replset());
1174+
}
1175+
11761176
int
11771177
test_framework_skip_if_mongos (void)
11781178
{
@@ -1185,6 +1185,24 @@ test_framework_skip_if_replset (void)
11851185
return test_framework_is_replset() ? 0 : 1;
11861186
}
11871187

1188+
int
1189+
test_framework_skip_if_not_single (void)
1190+
{
1191+
return !test_framework_skip_if_single ();
1192+
}
1193+
1194+
int
1195+
test_framework_skip_if_not_mongos (void)
1196+
{
1197+
return !test_framework_skip_if_mongos ();
1198+
}
1199+
1200+
int
1201+
test_framework_skip_if_not_replset (void)
1202+
{
1203+
return !test_framework_skip_if_replset ();
1204+
}
1205+
11881206
int test_framework_skip_if_max_version_version_less_than_4 (void)
11891207
{
11901208
return test_framework_max_wire_version_at_least (4);

tests/test-libmongoc.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,9 @@ int test_framework_skip_if_mongos (void);
5858
int test_framework_skip_if_replset (void);
5959
int test_framework_skip_if_single (void);
6060
int test_framework_skip_if_windows (void);
61+
int test_framework_skip_if_not_mongos (void);
62+
int test_framework_skip_if_not_replset (void);
63+
int test_framework_skip_if_not_single (void);
6164

6265
typedef struct _debug_stream_stats_t {
6366
mongoc_client_t *client;

0 commit comments

Comments
 (0)