Skip to content

Commit e99ccad

Browse files
committed
more info when ssl or topology tests fail
1 parent a530dd8 commit e99ccad

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

tests/ssl-test.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,11 @@ ssl_test_client (void * ptr)
175175
server_addr.sin_addr.s_addr = htonl(INADDR_LOOPBACK);
176176

177177
r = mongoc_socket_connect (conn_sock, (struct sockaddr *)&server_addr, sizeof(server_addr), -1);
178-
assert (r == 0);
178+
if (r != 0) {
179+
fprintf (stderr, "mongoc_socket_connect returned %zd: \"%s\"",
180+
r, strerror (errno));
181+
abort ();
182+
}
179183

180184
sock_stream = mongoc_stream_socket_new (conn_sock);
181185
assert(sock_stream);

tests/test-mongoc-topology.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -355,20 +355,20 @@ test_invalid_cluster_node (void)
355355
assert (cluster_node);
356356
assert (scanner_node);
357357
assert (cluster_node->stream);
358-
assert (cluster_node->timestamp > scanner_node->timestamp);
358+
ASSERT_CMPINT64 (cluster_node->timestamp, >, scanner_node->timestamp);
359359

360360
/* update the scanner node's timestamp */
361361
_mongoc_usleep (1000 * 1000);
362362
scanner_node->timestamp = bson_get_monotonic_time ();
363-
assert (cluster_node->timestamp < scanner_node->timestamp);
363+
ASSERT_CMPINT64 (cluster_node->timestamp, <, scanner_node->timestamp);
364364
_mongoc_usleep (1000 * 1000);
365365

366366
/* cluster discards node and creates new one */
367367
server_stream = mongoc_cluster_stream_for_server (&client->cluster,
368368
id, true, &error);
369369
ASSERT_OR_PRINT (server_stream, error);
370370
cluster_node = (mongoc_cluster_node_t *)mongoc_set_get (cluster->nodes, id);
371-
assert (cluster_node->timestamp > scanner_node->timestamp);
371+
ASSERT_CMPINT64 (cluster_node->timestamp, >, scanner_node->timestamp);
372372

373373
mongoc_server_stream_cleanup (server_stream);
374374
mongoc_client_pool_push (pool, client);

0 commit comments

Comments
 (0)