CDRIVER-618 show collection names aren't NULL on err

Author: ajdavis

tests/test-mongoc-database.c

@@ -3,6 +3,8 @@
 #include "TestSuite.h"
 #include "test-libmongoc.h"
 #include "mongoc-tests.h"
+#include "mock-server.h"
+#include "mongoc-client-private.h"
 
 
 static void
@@ -391,6 +393,59 @@ test_get_collection_names (void)
    mongoc_client_destroy (client);
 }
 
+static void
+collection_names_handler (mock_server_t   *server,
+                          mongoc_stream_t *stream,
+                          mongoc_rpc_t    *rpc,
+                          void            *user_data)
+{
+   mongoc_stream_close (stream);
+}
+
+static void
+test_get_collection_names_error (void)
+{
+   mongoc_database_t *database;
+   mongoc_client_t *client;
+   mock_server_t *server;
+   uint16_t port;
+   bson_error_t error = { 0 };
+   bool success = false;
+   bson_t b = BSON_INITIALIZER;
+   char *uristr;
+   char **names;
+
+   port = (uint16_t )(20000 + (rand () % 1000));
+
+   server = mock_server_new ("127.0.0.1", port, collection_names_handler,
+                             &success);
+   mock_server_set_wire_version (server, 0, 3);  /* listCollections command */
+   mock_server_run_in_thread (server);
+
+   usleep (5000);
+
+   uristr = bson_strdup_printf ("mongodb://127.0.0.1:%hu/", port);
+   client = mongoc_client_new (uristr);
+
+   if (!_mongoc_client_warm_up (client, &error)) {
+      assert (false);
+   }
+
+   database = mongoc_client_get_database (client, "test");
+   suppress_one_message ();
+   suppress_one_message ();
+   names = mongoc_database_get_collection_names (database, &error);
+   assert (!names);
+   ASSERT_CMPINT (MONGOC_ERROR_STREAM, ==, error.domain);
+   ASSERT_CMPINT (MONGOC_ERROR_STREAM_SOCKET, ==, error.code);
+
+   mongoc_database_destroy (database);
+   mongoc_client_destroy (client);
+   mock_server_quit (server, 0);
+   bson_destroy (&b);
+   bson_free (uristr);
+}
+
 void
 test_database_install (TestSuite *suite)
 {
@@ -402,4 +457,6 @@ test_database_install (TestSuite *suite)
                   test_get_collection_info);
    TestSuite_Add (suite, "/Database/get_collection_names",
                   test_get_collection_names);
+   TestSuite_Add (suite, "/Database/get_collection_names_error",
+                  test_get_collection_names_error);
 }