Skip to content

Commit f7353bc

Browse files
committed
CDRIVER-2831 don't use --sort
1 parent b6f3aa6 commit f7353bc

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

build/calc_release_version.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,7 @@ def main():
126126
gexc = Git('.')
127127
tags = gexc.execute(['git', 'tag',
128128
'--merged', 'HEAD',
129-
'--list', '1.*',
130-
'--sort', 'version:refname'])
129+
'--list', '1.*'])
131130
if len(tags) > 0:
132131
release_tag_match = RELEASE_TAG_RE.match(tags.splitlines()[-1])
133132
if release_tag_match:
@@ -159,8 +158,7 @@ def previous(rel_ver):
159158
rel_ver_loose = LooseVersion(rel_ver)
160159
gexc = Git('.')
161160
tags = gexc.execute(['git', 'tag',
162-
'--list', '1.*',
163-
'--sort', '-version:refname'])
161+
'--list', '1.*'])
164162
for tag in tags.splitlines():
165163
previous_tag_match = PREVIOUS_TAG_RE.match(tag)
166164
if previous_tag_match:
@@ -171,12 +169,11 @@ def previous(rel_ver):
171169
new_version_loose = LooseVersion(str(version_new['major']) + '.' +
172170
str(version_new['minor']) + '.' +
173171
str(version_new['patch']))
174-
if new_version_loose < rel_ver_loose:
172+
if new_version_loose < rel_ver_loose and new_version_loose > version_loose:
175173
version_loose = new_version_loose
176174
if DEBUG:
177175
print('Found new best version "' + str(version_loose) \
178176
+ '" from tag "' + tag + '"')
179-
return str(version_loose)
180177

181178
return str(version_loose)
182179

0 commit comments

Comments
 (0)