fixed bug 449 related to iterating and modifying a list at the same time.

craiggwilson · craiggwilson · commit 12fe80e67e0a · 2012-04-19T07:49:59.000-05:00
diff --git a/Driver/Core/MongoServer.cs b/Driver/Core/MongoServer.cs
@@ -1321,11 +1321,11 @@ internal void VerifyInstances(List<MongoServerAddress> instanceAddresses)
         {
             lock (_stateLock)
             {
-                foreach (var instance in _instances)
+                for (int i = _instances.Count - 1; i >= 0; i--)
                 {
-                    if (!instanceAddresses.Contains(instance.Address))
+                    if (!instanceAddresses.Contains(_instances[i].Address))
                     {
-                        RemoveInstance(instance);
+                        RemoveInstance(_instances[i]);
                     }
                 }
                 foreach (var address in instanceAddresses)

Original file line number	Diff line number	Diff line change
`@@ -1321,11 +1321,11 @@ internal void VerifyInstances(List<MongoServerAddress> instanceAddresses)`
`1321`	`1321`	`{`
`1322`	`1322`	`lock (_stateLock)`
`1323`	`1323`	`{`
`1324`		`- foreach (var instance in _instances)`
	`1324`	`+ for (int i = _instances.Count - 1; i >= 0; i--)`
`1325`	`1325`	`{`
`1326`		`- if (!instanceAddresses.Contains(instance.Address))`
	`1326`	`+ if (!instanceAddresses.Contains(_instances[i].Address))`
`1327`	`1327`	`{`
`1328`		`- RemoveInstance(instance);`
	`1328`	`+ RemoveInstance(_instances[i]);`
`1329`	`1329`	`}`
`1330`	`1330`	`}`
`1331`	`1331`	`foreach (var address in instanceAddresses)`