CSHARP-3533/CSHARP-3619: Test that session is unpinned when executing a non-transaction operation. / Unpin sessions after all abortTransaction attempts. (#540)

CSHARP-3533/CSHARP-3619: Test that session is unpinned when executing a non-transaction operation. / Unpin sessions after all abortTransaction attempts.

Author: DmitryLukyanov

src/MongoDB.Driver.Core/Core/Bindings/CoreSession.cs

@@ -139,6 +139,9 @@ public bool IsInTransaction
                 }
                 catch (Exception exception) when (ShouldRetryEndTransactionException(exception))
                 {
+                    // unpin if retryable error
+                    _currentTransaction.PinnedServer = null;
+
                     // ignore exception and retry
                 }
                 catch
@@ -159,6 +162,9 @@ public bool IsInTransaction
             finally
             {
                 _currentTransaction.SetState(CoreTransactionState.Aborted);
+                // The transaction is aborted.The session MUST be unpinned regardless
+                // of whether the abortTransaction command succeeds or fails
+                _currentTransaction.PinnedServer = null;
             }
         }
 
@@ -182,6 +188,9 @@ public bool IsInTransaction
                 }
                 catch (Exception exception) when (ShouldRetryEndTransactionException(exception))
                 {
+                    // unpin if retryable error
+                    _currentTransaction.PinnedServer = null;
+
                     // ignore exception and retry
                 }
                 catch
@@ -202,6 +211,9 @@ public bool IsInTransaction
             finally
             {
                 _currentTransaction.SetState(CoreTransactionState.Aborted);
+                // The transaction is aborted.The session MUST be unpinned regardless
+                // of whether the abortTransaction command succeeds or fails
+                _currentTransaction.PinnedServer = null;
             }
         }
 

tests/MongoDB.Driver.Tests/Specifications/transactions/TransactionTestRunner.cs

@@ -523,13 +523,7 @@ private void VerifyCollectionData(IEnumerable<BsonDocument> expectedDocuments)
         public class TestCaseFactory : JsonDrivenTestCaseFactory
         {
             // protected properties
-            protected override string PathPrefix
-            {
-                get
-                {
-                    return "MongoDB.Driver.Tests.Specifications.transactions.tests.";
-                }
-            }
+            protected override string PathPrefix => "MongoDB.Driver.Tests.Specifications.transactions.tests.legacy";
 
             // protected methods
             protected override IEnumerable<JsonDrivenTestCase> CreateTestCases(BsonDocument document)

tests/MongoDB.Driver.Tests/Specifications/transactions/TransactionUnifiedTestRunner.cs

@@ -0,0 +1,57 @@
+/* Copyright 2021-present MongoDB Inc.
+*
+* Licensed under the Apache License, Version 2.0 (the "License");
+* you may not use this file except in compliance with the License.
+* You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+
+using System.Collections.Generic;
+using MongoDB.Bson;
+using MongoDB.Bson.TestHelpers.JsonDrivenTests;
+using MongoDB.Driver.Tests.UnifiedTestOperations;
+using Xunit;
+
+namespace MongoDB.Driver.Tests.Specifications.transactions
+{
+   public sealed class TransactionUnifiedTestRunner
+    {
+        [SkippableTheory]
+        [ClassData(typeof(TestCaseFactory))]
+        public void Run(JsonDrivenTestCase testCase)
+        {
+            using (var runner = new UnifiedTestRunner())
+            {
+                runner.Run(testCase);
+            }
+        }
+
+        // nested types
+        public class TestCaseFactory : JsonDrivenTestCaseFactory
+        {
+            // protected properties
+            protected override string PathPrefix => "MongoDB.Driver.Tests.Specifications.transactions.tests.unified.";
+
+            // protected methods
+            protected override IEnumerable<JsonDrivenTestCase> CreateTestCases(BsonDocument document)
+            {
+                foreach (var testCase in base.CreateTestCases(document))
+                {
+                    foreach (var async in new[] { false, true })
+                    {
+                        var name = $"{testCase.Name}:async={async}";
+                        var test = testCase.Test.DeepClone().AsBsonDocument.Add("async", async);
+                        yield return new JsonDrivenTestCase(name, testCase.Shared, test);
+                    }
+                }
+            }
+        }
+    }
+}