Make a defensive copy of the test definition in command-monitoring/TestRunner.cs because the test case is run twice (async=false/true).

rstam · rstam · commit 31b235a9807a · 2015-12-02T16:55:40.000-05:00
diff --git a/src/MongoDB.Driver.Tests/Specifications/command-monitoring/TestRunner.cs b/src/MongoDB.Driver.Tests/Specifications/command-monitoring/TestRunner.cs
@@ -92,6 +92,8 @@ public void TestFixtureSetUp()
         [TestCaseSource(typeof(TestCaseFactory), "GetTestCases")]
         public void RunTestDefinition(IEnumerable<BsonDocument> data, string databaseName, string collectionName, BsonDocument definition, bool async)
         {
+            definition = (BsonDocument)DeepCopy(definition); // protect against side effects when the same definition is run twice (async=false/true)
+
             BsonValue bsonValue;
             if (definition.TryGetValue("ignore_if_server_version_greater_than", out bsonValue))
             {

Original file line number	Diff line number	Diff line change
`@@ -92,6 +92,8 @@ public void TestFixtureSetUp()`
`92`	`92`	`[TestCaseSource(typeof(TestCaseFactory), "GetTestCases")]`
`93`	`93`	`public void RunTestDefinition(IEnumerable<BsonDocument> data, string databaseName, string collectionName, BsonDocument definition, bool async)`
`94`	`94`	`{`
	`95`	`+ definition = (BsonDocument)DeepCopy(definition); // protect against side effects when the same definition is run twice (async=false/true)`
	`96`	`+`
`95`	`97`	`BsonValue bsonValue;`
`96`	`98`	`if (definition.TryGetValue("ignore_if_server_version_greater_than", out bsonValue))`
`97`	`99`	`{`