CSHARP-2996: Handle absence of 'ns' field in index specifications returned from listIndexes (regression).

Author: DmitryLukyanov

tests/MongoDB.Driver.Tests/MongoIndexManagerTests.cs

@@ -32,55 +32,58 @@ public void List_should_return_expected_result(
             [Values(false, true)] bool async)
         {
             var indexKeyDocument = BsonDocument.Parse(key);
-            var collection = GetEmptyCollection();
-            var subject = collection.Indexes;
+            var collectionName = DriverTestConfiguration.CollectionNamespace.CollectionName;
+            var client = DriverTestConfiguration.Client;
+            var database = client.GetDatabase(DriverTestConfiguration.DatabaseNamespace.DatabaseName);
+            database.DropCollection(collectionName);
+            var collection = database.GetCollection<BsonDocument>(collectionName);
 
-            subject.CreateOne(new CreateIndexModel<BsonDocument>(indexKeyDocument, new CreateIndexOptions() { Unique = unique }));
+            var subject = collection.Indexes;
 
-            var indexesCursor =
-                async
-                    ? subject.ListAsync().GetAwaiter().GetResult()
-                    : subject.List();
-            var indexes = indexesCursor.ToList();
+            try
+            {
+                subject.CreateOne(new CreateIndexModel<BsonDocument>(indexKeyDocument, new CreateIndexOptions() { Unique = unique }));
 
-            indexes.Count.Should().Be(2);
-            AssertIndex(collection.CollectionNamespace, indexes[0], "_id_");
-            var indexName = IndexNameHelper.GetIndexName(indexKeyDocument);
-            AssertIndex(collection.CollectionNamespace, indexes[1], indexName, expectedUnique: unique);
+                var indexesCursor =
+                    async
+                        ? subject.ListAsync().GetAwaiter().GetResult()
+                        : subject.List();
+                var indexes = indexesCursor.ToList();
 
-            void AssertIndex(CollectionNamespace collectionNamespace, BsonDocument index, string expectedName, bool expectedUnique = false)
-            {
-                index["name"].AsString.Should().Be(expectedName);
+                indexes.Count.Should().Be(2);
+                AssertIndex(collection.CollectionNamespace, indexes[0], "_id_");
+                var indexName = IndexNameHelper.GetIndexName(indexKeyDocument);
+                AssertIndex(collection.CollectionNamespace, indexes[1], indexName, expectedUnique: unique);
 
-                if (expectedUnique)
-                {
-                    index["unique"].AsBoolean.Should().BeTrue();
-                }
-                else
+                void AssertIndex(CollectionNamespace collectionNamespace, BsonDocument index, string expectedName, bool expectedUnique = false)
                 {
-                    index.Contains("unique").Should().BeFalse();
-                }
+                    index["name"].AsString.Should().Be(expectedName);
 
-                if (CoreTestConfiguration.ServerVersion < new SemanticVersion(4, 3, 0))
-                {
-                    index["ns"].AsString.Should().Be(collectionNamespace.ToString());
-                }
-                else
-                {
-                    // the server doesn't return ns anymore
-                    index.Contains("ns").Should().BeFalse();
+                    if (expectedUnique)
+                    {
+                        index["unique"].AsBoolean.Should().BeTrue();
+                    }
+                    else
+                    {
+                        index.Contains("unique").Should().BeFalse();
+                    }
+
+                    if (CoreTestConfiguration.ServerVersion < new SemanticVersion(4, 3, 0))
+                    {
+                        index["ns"].AsString.Should().Be(collectionNamespace.ToString());
+                    }
+                    else
+                    {
+                        // the server doesn't return ns anymore
+                        index.Contains("ns").Should().BeFalse();
+                    }
                 }
             }
-        }
-
-        // private methods
-        private IMongoCollection<BsonDocument> GetEmptyCollection()
-        {
-            var collectionName = DriverTestConfiguration.CollectionNamespace.CollectionName;
-            var client = DriverTestConfiguration.Client;
-            var database = client.GetDatabase(DriverTestConfiguration.DatabaseNamespace.DatabaseName);
-            database.DropCollection(collectionName);
-            return database.GetCollection<BsonDocument>(collectionName);
+            finally
+            {
+                // make sure that index has been removed
+                database.DropCollection(collectionName);
+            }
         }
     }
 }