Skip to content

Commit 3ad811e

Browse files
committed
Added comments
1 parent 7c2beb3 commit 3ad811e

14 files changed

+32
-34
lines changed

src/MongoDB.Bson/Serialization/Serializers/BsonDocumentSerializer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public bool GetDocumentId(
8989
if (bsonDocument.TryGetValue("_id", out idBsonValue))
9090
{
9191
id = idBsonValue;
92-
idGenerator = BsonSerializer.LookupIdGenerator(id.GetType()); //TODO For this we need add a new GetDocumentId to IBsonIdProvider
92+
idGenerator = BsonSerializer.LookupIdGenerator(id.GetType()); //TODO ??
9393

9494
if (idGenerator == null)
9595
{

src/MongoDB.Bson/Serialization/Serializers/DictionarySerializerBase.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,7 @@ public DictionarySerializerBase()
5858
/// </summary>
5959
/// <param name="dictionaryRepresentation">The dictionary representation.</param>
6060
public DictionarySerializerBase(DictionaryRepresentation dictionaryRepresentation)
61-
: this(dictionaryRepresentation, BsonSerializer.LookupSerializer<object>(), BsonSerializer.LookupSerializer<object>())
62-
//TODO We could keep this, and add a new constructor DictionarySerializerBase(dictionaryRepresentation, domain)
61+
: this(dictionaryRepresentation, BsonSerializer.LookupSerializer<object>(), BsonSerializer.LookupSerializer<object>()) //TODO We can keep this as is
6362
{
6463
}
6564

@@ -387,8 +386,7 @@ public DictionarySerializerBase()
387386
/// </summary>
388387
/// <param name="dictionaryRepresentation">The dictionary representation.</param>
389388
public DictionarySerializerBase(DictionaryRepresentation dictionaryRepresentation)
390-
: this(dictionaryRepresentation, BsonSerializer.SerializerRegistry)
391-
//TODO We could keep this, and add a new constructor DictionarySerializerBase(dictionaryRepresentation, domain)
389+
: this(dictionaryRepresentation, BsonSerializer.SerializerRegistry) //TODO We can keep this as is
392390
{
393391
}
394392

src/MongoDB.Bson/Serialization/Serializers/DiscriminatedInterfaceSerializer.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ private static IBsonSerializer<TInterface> CreateInterfaceSerializer()
4747
var classMapType = classMapDefinition.MakeGenericType(typeof(TInterface));
4848
var classMap = (BsonClassMap)Activator.CreateInstance(classMapType);
4949
classMap.AutoMap();
50-
classMap.SetDiscriminatorConvention(BsonSerializer.LookupDiscriminatorConvention(typeof(TInterface))); //TODO This is only called by the constructor, we need a new one with the domain as input
50+
classMap.SetDiscriminatorConvention(BsonSerializer.LookupDiscriminatorConvention(typeof(TInterface))); //TODO ??
5151
classMap.Freeze();
5252
return new BsonClassMapSerializer<TInterface>(classMap);
5353
}
@@ -97,7 +97,7 @@ public DiscriminatedInterfaceSerializer(IDiscriminatorConvention discriminatorCo
9797

9898
_interfaceType = typeof(TInterface);
9999
_discriminatorConvention = discriminatorConvention ?? interfaceSerializer.GetDiscriminatorConvention();
100-
_objectSerializer = BsonSerializer.LookupSerializer<object>(); //TODO We need a new constructor, that takes the domain as input.
100+
_objectSerializer = BsonSerializer.LookupSerializer<object>(); //TODO ??
101101
if (_objectSerializer is ObjectSerializer standardObjectSerializer)
102102
{
103103
_objectSerializer = standardObjectSerializer.WithDiscriminatorConvention(_discriminatorConvention);

src/MongoDB.Bson/Serialization/Serializers/EnumerableSerializerBase.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public abstract class EnumerableSerializerBase<TValue> : SerializerBase<TValue>,
3535
/// Initializes a new instance of the <see cref="EnumerableSerializerBase{TValue}"/> class.
3636
/// </summary>
3737
protected EnumerableSerializerBase()
38-
: this(BsonSerializer.SerializerRegistry) //TODO Need a new constructor that takes the domain as input
38+
: this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
3939
{
4040
}
4141

@@ -234,7 +234,7 @@ public abstract class EnumerableSerializerBase<TValue, TItem> : SerializerBase<T
234234
/// Initializes a new instance of the <see cref="EnumerableSerializerBase{TValue, TItem}"/> class.
235235
/// </summary>
236236
protected EnumerableSerializerBase()
237-
: this(BsonSerializer.SerializerRegistry) //TODO Need a new constructor that takes the domain as input
237+
: this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
238238
{
239239
}
240240

src/MongoDB.Bson/Serialization/Serializers/IEnumerableDeserializingAsCollectionSerializer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ private static void EnsureTIEnumerableIsAnInterface()
5050
/// Initializes a new instance of the IEnumerableDeserializingAsCollectionSerializer class.
5151
/// </summary>
5252
public IEnumerableDeserializingAsCollectionSerializer()
53-
: this(BsonSerializer.SerializerRegistry) //TODO Need a new constructor that takes the domain as input
53+
: this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
5454
{
5555
}
5656

src/MongoDB.Bson/Serialization/Serializers/ImpliedImplementationInterfaceSerializer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public sealed class ImpliedImplementationInterfaceSerializer<TInterface, TImplem
5252
/// Initializes a new instance of the <see cref="ImpliedImplementationInterfaceSerializer{TInterface, TImplementation}"/> class.
5353
/// </summary>
5454
public ImpliedImplementationInterfaceSerializer()
55-
: this(BsonSerializer.SerializerRegistry) //TODO Need a new constructor that takes the domain as input
55+
: this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
5656
{
5757
}
5858

src/MongoDB.Bson/Serialization/Serializers/KeyValuePairSerializer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public KeyValuePairSerializer()
6666
/// </summary>
6767
/// <param name="representation">The representation.</param>
6868
public KeyValuePairSerializer(BsonType representation)
69-
: this(representation, BsonSerializer.SerializerRegistry) //TODO Need a new constructor that takes the domain as input
69+
: this(representation, BsonSerializer.SerializerRegistry) //TODO We can keep this as is
7070
{
7171
}
7272

src/MongoDB.Bson/Serialization/Serializers/NullableSerializer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public sealed class NullableSerializer<T> :
6464
/// Initializes a new instance of the <see cref="NullableSerializer{T}"/> class.
6565
/// </summary>
6666
public NullableSerializer()
67-
: this(BsonSerializer.SerializerRegistry) //TODO Need a new constructor that takes the domain as input
67+
: this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
6868
{
6969
}
7070

src/MongoDB.Bson/Serialization/Serializers/ObjectSerializer.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public sealed class ObjectSerializer : ClassSerializerBase<object>, IHasDiscrimi
6767
/// Initializes a new instance of the <see cref="ObjectSerializer"/> class.
6868
/// </summary>
6969
public ObjectSerializer()
70-
: this(BsonSerializer.LookupDiscriminatorConvention(typeof(object))) //TODO Need a new constructor that takes the domain as input
70+
: this(BsonSerializer.LookupDiscriminatorConvention(typeof(object))) //TODO We can keep this as is
7171
{
7272
}
7373

@@ -96,7 +96,7 @@ public ObjectSerializer(IDiscriminatorConvention discriminatorConvention, GuidRe
9696
/// </summary>
9797
/// <param name="allowedTypes">A delegate that determines what types are allowed.</param>
9898
public ObjectSerializer(Func<Type, bool> allowedTypes)
99-
: this(BsonSerializer.LookupDiscriminatorConvention(typeof(object)), allowedTypes) //TODO Need a new constructor that takes the domain as input
99+
: this(BsonSerializer.LookupDiscriminatorConvention(typeof(object)), allowedTypes) //TODO We can keep this as is
100100
{
101101
}
102102

src/MongoDB.Bson/Serialization/Serializers/SerializeAsNominalTypeSerializer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public sealed class SerializeAsNominalTypeSerializer<TActualType, TNominalType>
3232
/// Initializes a new instance of the <see cref="SerializeAsNominalTypeSerializer{TActualType, TNominalType}"/> class.
3333
/// </summary>
3434
public SerializeAsNominalTypeSerializer()
35-
: this(BsonSerializer.SerializerRegistry) //TODO Need a new constructor that takes the domain as input
35+
: this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
3636
{
3737
}
3838

0 commit comments

Comments
 (0)