CSHARP-3904: Protect xunit/logging infrastructure by DebuggerStepThrough. (#684)

CSHARP-3904: Protect xunit/logging infrastructure by DebuggerStepThrough.

Author: DmitryLukyanov

tests/MongoDB.Driver.Core.TestHelpers/Logging/LoggableTestClass.cs

@@ -23,6 +23,7 @@
 
 namespace MongoDB.Driver.Core.TestHelpers.Logging
 {
+    [DebuggerStepThrough]
     public abstract class LoggableTestClass : IDisposable
     {
         private readonly XunitLogger _loggerBase;

tests/MongoDB.Driver.Core.TestHelpers/Logging/XUnitLoggerFactory.cs

@@ -13,8 +13,11 @@
 * limitations under the License.
 */
 
+using System.Diagnostics;
+
 namespace MongoDB.Driver.Core.TestHelpers.Logging
 {
+    [DebuggerStepThrough]
     internal sealed class XUnitLoggerFactory : ILoggerFactory
     {
         private readonly ILogger _loggerBase;

tests/MongoDB.Driver.Core.TestHelpers/Logging/XunitLogger.cs

@@ -15,11 +15,13 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using MongoDB.Driver.Core.Misc;
 using Xunit.Abstractions;
 
 namespace MongoDB.Driver.Core.TestHelpers.Logging
 {
+    [DebuggerStepThrough]
     internal sealed class XunitLogger : ILogger
     {
         private readonly ITestOutputHelper _output;

tests/MongoDB.Driver.Core.TestHelpers/XunitExtensions/TimeoutEnforcing/TimeoutEnforcingTestInvoker.cs

@@ -15,6 +15,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Reflection;
 using System.Threading;
 using System.Threading.Tasks;
@@ -25,6 +26,7 @@
 
 namespace MongoDB.Driver.Core.TestHelpers.XunitExtensions.TimeoutEnforcing
 {
+    [DebuggerStepThrough]
     internal sealed class TimeoutEnforcingTestInvoker : XunitTestInvoker
     {
         public TimeoutEnforcingTestInvoker(
@@ -52,7 +54,10 @@ protected override async Task<decimal> InvokeTestMethodAsync(object testClassIns
         {
             var xUnitTestCase = Test.TestCase as IXunitTestCase;
             var timeoutMS = xUnitTestCase?.Timeout ?? 0;
-            var timeout = timeoutMS <= 0 ? CoreTestConfiguration.DefaultTestTimeout : TimeSpan.FromMilliseconds(timeoutMS);
+            var timeout = Debugger.IsAttached
+                ? Timeout.InfiniteTimeSpan // allow more flexible debugging expirience
+                : timeoutMS <= 0 ? CoreTestConfiguration.DefaultTestTimeout : TimeSpan.FromMilliseconds(timeoutMS);
+
 
             var testLoggable = testClassInstance as LoggableTestClass;
 

tests/MongoDB.Driver.Core.TestHelpers/XunitExtensions/TimeoutEnforcing/TimeoutEnforcingTestRunner.cs

@@ -15,6 +15,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Reflection;
 using System.Threading;
 using System.Threading.Tasks;
@@ -23,6 +24,7 @@
 
 namespace MongoDB.Driver.Core.TestHelpers.XunitExtensions.TimeoutEnforcing
 {
+    [DebuggerStepThrough]
     internal sealed class TimeoutEnforcingTestRunner : XunitTestRunner
     {
         public TimeoutEnforcingTestRunner(ITest test, IMessageBus messageBus, Type testClass, object[] constructorArguments, MethodInfo testMethod, object[] testMethodArguments, string skipReason, IReadOnlyList<BeforeAfterTestAttribute> beforeAfterAttributes, ExceptionAggregator aggregator, CancellationTokenSource cancellationTokenSource)

tests/MongoDB.Driver.Core.TestHelpers/XunitExtensions/TimeoutEnforcing/TimeoutEnforcingXunitTestAssemblyRunner.cs

@@ -14,13 +14,15 @@
 */
 
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Threading;
 using System.Threading.Tasks;
 using Xunit.Abstractions;
 using Xunit.Sdk;
 
 namespace MongoDB.Driver.Core.TestHelpers.XunitExtensions.TimeoutEnforcing
 {
+    [DebuggerStepThrough]
     internal sealed class TimeoutEnforcingXunitTestAssemblyRunner : XunitTestAssemblyRunner
     {
         public TimeoutEnforcingXunitTestAssemblyRunner(

tests/MongoDB.Driver.Core.TestHelpers/XunitExtensions/TimeoutEnforcing/TimeoutEnforcingXunitTestCaseRunner.cs

@@ -15,13 +15,15 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Reflection;
 using System.Threading;
 using Xunit.Abstractions;
 using Xunit.Sdk;
 
 namespace MongoDB.Driver.Core.TestHelpers.XunitExtensions.TimeoutEnforcing
 {
+    [DebuggerStepThrough]
     internal sealed class TimeoutEnforcingXunitTestCaseRunner : XunitTestCaseRunner
     {
         public TimeoutEnforcingXunitTestCaseRunner(

tests/MongoDB.Driver.Core.TestHelpers/XunitExtensions/TimeoutEnforcing/TimeoutEnforcingXunitTestClassRunner.cs

@@ -15,13 +15,15 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Threading;
 using System.Threading.Tasks;
 using Xunit.Abstractions;
 using Xunit.Sdk;
 
 namespace MongoDB.Driver.Core.TestHelpers.XunitExtensions.TimeoutEnforcing
 {
+    [DebuggerStepThrough]
     internal sealed class TimeoutEnforcingXunitTestClassRunner : XunitTestClassRunner
     {
         public TimeoutEnforcingXunitTestClassRunner(ITestClass testClass, IReflectionTypeInfo @class, IEnumerable<IXunitTestCase> testCases, IMessageSink diagnosticMessageSink, IMessageBus messageBus, ITestCaseOrderer testCaseOrderer, ExceptionAggregator aggregator, CancellationTokenSource cancellationTokenSource, IDictionary<Type, object> collectionFixtureMappings) : base(testClass, @class, testCases, diagnosticMessageSink, messageBus, testCaseOrderer, aggregator, cancellationTokenSource, collectionFixtureMappings)

tests/MongoDB.Driver.Core.TestHelpers/XunitExtensions/TimeoutEnforcing/TimeoutEnforcingXunitTestCollectionRunner.cs

@@ -14,13 +14,15 @@
 */
 
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Threading;
 using System.Threading.Tasks;
 using Xunit.Abstractions;
 using Xunit.Sdk;
 
 namespace MongoDB.Driver.Core.TestHelpers.XunitExtensions.TimeoutEnforcing
 {
+    [DebuggerStepThrough]
     internal sealed class TimeoutEnforcingXunitTestCollectionRunner : XunitTestCollectionRunner
     {
         public TimeoutEnforcingXunitTestCollectionRunner(

tests/MongoDB.Driver.Core.TestHelpers/XunitExtensions/TimeoutEnforcing/TimeoutEnforcingXunitTestFramework.cs

@@ -13,12 +13,14 @@
 * limitations under the License.
 */
 
+using System.Diagnostics;
 using System.Reflection;
 using Xunit.Abstractions;
 using Xunit.Sdk;
 
 namespace MongoDB.Driver.Core.TestHelpers.XunitExtensions.TimeoutEnforcing
 {
+    [DebuggerStepThrough]
     public sealed class TimeoutEnforcingXunitTestFramework : XunitTestFramework
     {
         public TimeoutEnforcingXunitTestFramework(IMessageSink messageSink)