More unit tests. Some code cleanup

Author: sridharn

Bson/BsonUtils.cs

@@ -57,7 +57,8 @@ public static DateTime ToDateTimeFromMillisecondsSinceEpoch(long millisecondsSin
                 millisecondsSinceEpoch > BsonConstants.DateTimeMaxValueMillisecondsSinceEpoch)
             {
                 var message = string.Format(
-                    "The value {0} for the BsonDateTime MillisecondsSinceEpoch is outside the range that can be converted to a .NET DateTime.",
+                    "The value {0} for the BsonDateTime MillisecondsSinceEpoch is outside the"+
+                    "range that can be converted to a .NET DateTime.",
                     millisecondsSinceEpoch);
                 throw new ArgumentOutOfRangeException("millisecondsSinceEpoch", message);
             }
@@ -80,6 +81,10 @@ public static DateTime ToDateTimeFromMillisecondsSinceEpoch(long millisecondsSin
         /// <returns>A hex string.</returns>
         public static string ToHexString(byte[] bytes)
         {
+            if (bytes == null)
+            {
+                throw new ArgumentNullException("bytes");
+            }
             var sb = new StringBuilder(bytes.Length * 2);
             foreach (var b in bytes)
             {
@@ -125,14 +130,7 @@ public static DateTime ToLocalTime(DateTime dateTime, DateTimeKind kind)
         public static long ToMillisecondsSinceEpoch(DateTime dateTime)
         {
             var utcDateTime = ToUniversalTime(dateTime);
-            if (utcDateTime == DateTime.MaxValue)
-            {
-                return BsonConstants.DateTimeMaxValueMillisecondsSinceEpoch;
-            }
-            else
-            {
-                return (utcDateTime - BsonConstants.UnixEpoch).Ticks / 10000;
-            }
+            return (utcDateTime - BsonConstants.UnixEpoch).Ticks / 10000;
         }
 
         /// <summary>
@@ -161,6 +159,7 @@ public static DateTime ToUniversalTime(DateTime dateTime)
                     return dateTime.ToUniversalTime();
                 }
             }
+
         }
 
         /// <summary>

BsonUnitTests/BsonUtilsTests.cs

@@ -78,5 +78,46 @@ public void TestMinToMillisConversion()
             var actual = BsonUtils.ToMillisecondsSinceEpoch(DateTime.MinValue);
             Assert.AreEqual(BsonConstants.DateTimeMinValueMillisecondsSinceEpoch, actual);
         }
+
+        [Test]
+        public void TestToUniversalTimeUTCNow()
+        {
+            var expected = DateTime.UtcNow;
+            var actual = BsonUtils.ToUniversalTime(expected);
+            Assert.AreEqual(expected, actual);
+        }
+
+        [Test]
+        public void TestToUniversalTimeMax()
+        {
+            var expected = DateTime.MaxValue;
+            var actual = BsonUtils.ToUniversalTime(expected);
+            Assert.AreEqual(expected, actual);
+        }
+
+        [Test]
+        public void TestToUniversalTimeMin()
+        {
+            var expected = DateTime.MinValue;
+            var actual = BsonUtils.ToUniversalTime(expected);
+            Assert.AreEqual(expected, actual);
+        }
+
+        [Test]
+        public void TestToHexString()
+        {
+            var value = new byte[] { 0, 1,2, 3, 4, 5 ,6 ,7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 255 };
+            var expected = "000102030405060708090a0b0c0d0e0f10ff";
+            var actual = BsonUtils.ToHexString(value);
+            Assert.AreEqual(expected, actual);
+        }
+
+        [Test]
+        [ExpectedException(typeof(ArgumentNullException))]
+        public void TestToHexStringNull()
+        {
+            var actual = BsonUtils.ToHexString(null);
+        }
+
     }
 }