CSHARP-4652: TagSet.Equals should ignore tags order (#1084)

* CSHARP-4652: TagSet.Equals should ignore tags order

Author: BorisDog

src/MongoDB.Driver.Core/TagSet.cs

@@ -16,8 +16,6 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 using MongoDB.Driver.Core.Misc;
 using MongoDB.Shared;
 
@@ -46,7 +44,7 @@ public TagSet()
         /// <param name="tags">The tags.</param>
         public TagSet(IEnumerable<Tag> tags)
         {
-            _tags = Ensure.IsNotNull(tags, nameof(tags)).ToList();
+            _tags = Ensure.IsNotNull(tags, nameof(tags)).OrderBy(t => t.Name).ThenBy(t => t.Value).ToArray();
         }
 
         // properties

tests/MongoDB.Driver.Core.Tests/TagSetTests.cs

@@ -15,9 +15,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 using FluentAssertions;
 using Xunit;
 
@@ -87,6 +84,38 @@ public void ContainsAll_should_return_true_if_all_required_tags_are_present()
             tagSet.ContainsAll(required).Should().BeTrue();
         }
 
+        public static IEnumerable<object[]> Equals_should_ignore_order_memberdata()
+        {
+            var data = new TagSet[][]
+            {
+                new TagSet[]
+                {
+                    new (new Tag[] { new ("name1", "value1"), new ("name2", "value2") }),
+                    new (new Tag[] { new ("name2", "value2"), new ("name1", "value1") })
+                },
+                new TagSet[]
+                {
+                    new (new Tag[] { new ("name1", "value1"), new ("name1", "value2") }),
+                    new (new Tag[] { new ("name1", "value2"), new ("name1", "value1") })
+                },
+                new TagSet[]
+                {
+                    new (new Tag[] { new ("name1", "value1"), new ("name2", "value2"), new ("name2", "value1"), new ("name1", "value2") }),
+                    new (new Tag[] { new ("name1", "value2"), new ("name2", "value1"), new ("name1", "value1"), new ("name2", "value2") })
+                }
+            };
+
+            return data;
+        }
+
+        [Theory]
+        [MemberData(nameof(Equals_should_ignore_order_memberdata))]
+        public void Equals_should_ignore_order(TagSet tagSet1, TagSet tagSet2)
+        {
+            tagSet1.Equals(tagSet2).Should().BeTrue();
+            tagSet1.Equals((object)tagSet2).Should().BeTrue();
+        }
+
         [Fact]
         public void Equals_should_return_false_if_any_field_is_not_the_same()
         {