CSHARP-2032: Drop support for MongoDB 2.4

Author: MikalaiMazurenka

src/MongoDB.Driver.Core/Core/Misc/Feature.cs

@@ -41,12 +41,12 @@ public class Feature
         private static readonly ArrayFiltersFeature __arrayFilters = new ArrayFiltersFeature("ArrayFilters", new SemanticVersion(3, 5, 11));
         private static readonly Feature __bypassDocumentValidation = new Feature("BypassDocumentValidation", new SemanticVersion(3, 2, 0));
         private static readonly Feature __changeStreamStage = new Feature("ChangeStreamStage", new SemanticVersion(3, 5, 11));
-        private static readonly Feature __changeStreamPostBatchResumeToken = new Feature("ChangeStreamPostBatchResumeToken", new SemanticVersion(4, 0 ,7));
+        private static readonly Feature __changeStreamPostBatchResumeToken = new Feature("ChangeStreamPostBatchResumeToken", new SemanticVersion(4, 0, 7));
         private static readonly Feature __clientSideEncryption = new Feature("ClientSideEncryption", new SemanticVersion(4, 1, 9));
         private static readonly CollationFeature __collation = new CollationFeature("Collation", new SemanticVersion(3, 3, 11));
         private static readonly Feature __commandMessage = new Feature("CommandMessage", new SemanticVersion(3, 6, 0));
         private static readonly CommandsThatWriteAcceptWriteConcernFeature __commandsThatWriteAcceptWriteConcern = new CommandsThatWriteAcceptWriteConcernFeature("CommandsThatWriteAcceptWriteConcern", new SemanticVersion(3, 3, 11));
-        private static readonly Feature __createIndexesCommand = new Feature("CreateIndexesCommand", new SemanticVersion(3, 0, 0));
+        private static readonly Feature __createIndexesCommand = new Feature("CreateIndexesCommand", new SemanticVersion(2, 6, 0));
         private static readonly Feature __createIndexesUsingInsertOperations = new Feature("CreateIndexesUsingInsertOperations", new SemanticVersion(1, 0, 0), new SemanticVersion(4, 1, 1, ""));
         private static readonly Feature __currentOpCommand = new Feature("CurrentOpCommand", new SemanticVersion(3, 2, 0));
         private static readonly Feature __documentValidation = new Feature("DocumentValidation", new SemanticVersion(3, 2, 0));
@@ -369,14 +369,14 @@ public class Feature
         public static Feature Views => __views;
 
         /// <summary>
-        /// Gets the write commands feature.
+        /// Gets the wildcard indexes feature.
         /// </summary>
-        public static Feature WriteCommands => __writeCommands;
+        public static Feature WildcardIndexes => __wildcardIndexes;
 
         /// <summary>
-        /// Gets the wildcard indexes feature.
+        /// Gets the write commands feature.
         /// </summary>
-        public static Feature WildcardIndexes => __wildcardIndexes;
+        public static Feature WriteCommands => __writeCommands;
         #endregion
 
         private readonly string _name;

src/MongoDB.Driver.Core/Core/Operations/AggregateOperation.cs

@@ -344,16 +344,13 @@ internal BsonDocument CreateCommand(ConnectionDescription connectionDescription,
                 { "readConcern", readConcern, readConcern != null }
             };
 
-            if (Feature.AggregateCursorResult.IsSupported(connectionDescription.ServerVersion))
+            var useCursor = _useCursor.GetValueOrDefault(true) || connectionDescription.ServerVersion >= new SemanticVersion(3, 6, 0);
+            if (useCursor)
             {
-                var useCursor = _useCursor.GetValueOrDefault(true) || connectionDescription.ServerVersion >= new SemanticVersion(3, 6, 0);
-                if (useCursor)
+                command["cursor"] = new BsonDocument
                 {
-                    command["cursor"] = new BsonDocument
-                    {
-                        { "batchSize", () => _batchSize.Value, _batchSize.HasValue }
-                    };
-                }
+                    { "batchSize", () => _batchSize.Value, _batchSize.HasValue }
+                };
             }
 
             return command;

src/MongoDB.Driver.Core/Core/Operations/BulkDeleteOperation.cs

@@ -43,17 +43,6 @@ protected override IRetryableWriteOperation<BsonDocument> CreateBatchOperation(B
             };
         }
 
-        protected override IExecutableInRetryableWriteContext<BulkWriteOperationResult> CreateEmulator()
-        {
-            return new BulkDeleteOperationEmulator(CollectionNamespace, Requests, MessageEncoderSettings)
-            {
-                IsOrdered = IsOrdered,
-                MaxBatchCount = MaxBatchCount,
-                MaxBatchLength = MaxBatchLength,
-                WriteConcern = WriteConcern
-            };
-        }
-
         protected override bool RequestHasCollation(DeleteRequest request)
         {
             return request.Collation != null;

src/MongoDB.Driver.Core/Core/Operations/BulkDeleteOperationEmulator.cs

@@ -46,17 +46,6 @@ protected override IRetryableWriteOperation<BsonDocument> CreateBatchOperation(B
             };
         }
 
-        protected override IExecutableInRetryableWriteContext<BulkWriteOperationResult> CreateEmulator()
-        {
-            return new BulkInsertOperationEmulator(CollectionNamespace, Requests, MessageEncoderSettings)
-            {
-                IsOrdered = IsOrdered,
-                MaxBatchCount = MaxBatchCount,
-                MaxBatchLength = MaxBatchLength,
-                WriteConcern = WriteConcern
-            };
-        }
-
         protected override bool RequestHasCollation(InsertRequest request)
         {
             return false;

src/MongoDB.Driver.Core/Core/Operations/BulkInsertOperation.cs

@@ -116,15 +116,8 @@ public WriteConcern WriteConcern
         public BulkWriteOperationResult Execute(RetryableWriteContext context, CancellationToken cancellationToken)
         {
             EnsureCollationIsSupportedIfAnyRequestHasCollation(context, _requests);
-            if (Feature.WriteCommands.IsSupported(context.Channel.ConnectionDescription.ServerVersion))
-            {
-                return ExecuteBatches(context, cancellationToken);
-            }
-            else
-            {
-                var emulator = CreateEmulator();
-                return emulator.Execute(context, cancellationToken);
-            }
+
+            return ExecuteBatches(context, cancellationToken);
         }
 
         public BulkWriteOperationResult Execute(IWriteBinding binding, CancellationToken cancellationToken)
@@ -140,15 +133,8 @@ public BulkWriteOperationResult Execute(IWriteBinding binding, CancellationToken
         public Task<BulkWriteOperationResult> ExecuteAsync(RetryableWriteContext context, CancellationToken cancellationToken)
         {
             EnsureCollationIsSupportedIfAnyRequestHasCollation(context, _requests);
-            if (Feature.WriteCommands.IsSupported(context.Channel.ConnectionDescription.ServerVersion))
-            {
-                return ExecuteBatchesAsync(context, cancellationToken);
-            }
-            else
-            {
-                var emulator = CreateEmulator();
-                return emulator.ExecuteAsync(context, cancellationToken);
-            }
+
+            return ExecuteBatchesAsync(context, cancellationToken);
         }
 
         public async Task<BulkWriteOperationResult> ExecuteAsync(IWriteBinding binding, CancellationToken cancellationToken)
@@ -164,8 +150,6 @@ public async Task<BulkWriteOperationResult> ExecuteAsync(IWriteBinding binding,
         // protected methods
         protected abstract IRetryableWriteOperation<BsonDocument> CreateBatchOperation(Batch batch);
 
-        protected abstract IExecutableInRetryableWriteContext<BulkWriteOperationResult> CreateEmulator();
-
         protected abstract bool RequestHasCollation(TWriteRequest request);
 
         // private methods

src/MongoDB.Driver.Core/Core/Operations/BulkInsertOperationEmulator.cs

@@ -44,17 +44,6 @@ protected override IRetryableWriteOperation<BsonDocument> CreateBatchOperation(B
             };
         }
 
-        protected override IExecutableInRetryableWriteContext<BulkWriteOperationResult> CreateEmulator()
-        {
-            return new BulkUpdateOperationEmulator(CollectionNamespace, Requests, MessageEncoderSettings)
-            {
-                IsOrdered = IsOrdered,
-                MaxBatchCount = MaxBatchCount,
-                MaxBatchLength = MaxBatchLength,
-                WriteConcern = WriteConcern
-            };
-        }
-
         protected override bool RequestHasCollation(UpdateRequest request)
         {
             return request.Collation != null;