CSHARP-2342: Test only the initial command in a transaction includes readConcern

Author: vincentkam

tests/MongoDB.Bson.TestHelpers/JsonDrivenTests/JsonDrivenTest.cs

@@ -80,7 +80,11 @@ public virtual void Assert()
                 {
                     throw new Exception("Unexpected exception was thrown.", _actualException);
                 }
-                AssertResult();
+
+                if (_expectedResult != null)
+                {
+                    AssertResult();
+                }
             }
             else
             {

tests/MongoDB.Driver.Tests/JsonDrivenTests/JsonDrivenCountDocumentsTest.cs

@@ -0,0 +1,100 @@
+/* Copyright 2019-present MongoDB Inc.
+*
+* Licensed under the Apache License, Version 2.0 (the "License");
+* you may not use this file except in compliance with the License.
+* You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+
+using System.Collections.Generic;
+using System.Threading;
+using System.Threading.Tasks;
+using FluentAssertions;
+using MongoDB.Bson;
+using MongoDB.Bson.TestHelpers.JsonDrivenTests;
+
+namespace MongoDB.Driver.Tests.JsonDrivenTests
+{
+    public sealed class JsonDrivenCountDocumentsTest : JsonDrivenCollectionTest
+    {
+        // private fields
+        private FilterDefinition<BsonDocument> _filter = new BsonDocument();
+        private CountOptions _options = new CountOptions();
+        private long _result;
+        private IClientSessionHandle _session;
+
+        // public constructors
+        public JsonDrivenCountDocumentsTest(IMongoCollection<BsonDocument> collection, Dictionary<string, object> objectMap)
+            : base(collection, objectMap)
+        {
+        }
+
+        // public methods
+        public override void Arrange(BsonDocument document)
+        {
+            JsonDrivenHelper.EnsureAllFieldsAreValid(document, "name", "object", "collectionOptions", "arguments", "result", "error");
+            base.Arrange(document);
+        }
+
+        // protected methods
+        protected override void AssertResult()
+        {
+            _result.Should().Be(_expectedResult.ToInt64());
+        }
+
+        protected override void CallMethod(CancellationToken cancellationToken)
+        {
+            if (_session == null)
+            {
+#pragma warning disable 618
+                _result = _collection.CountDocuments(_filter, _options, cancellationToken);
+#pragma warning restore
+            }
+            else
+            {
+#pragma warning disable 618
+                _result = _collection.CountDocuments(_session, _filter, _options, cancellationToken);
+#pragma warning restore
+            }
+        }
+
+        protected override async Task CallMethodAsync(CancellationToken cancellationToken)
+        {
+            if (_session == null)
+            {
+#pragma warning disable 618
+                _result = await _collection.CountDocumentsAsync(_filter, _options, cancellationToken).ConfigureAwait(false);
+#pragma warning restore
+            }
+            else
+            {
+#pragma warning disable 618
+                _result = await _collection.CountDocumentsAsync(_session, _filter, _options, cancellationToken).ConfigureAwait(false);
+#pragma warning restore
+            }
+        }
+
+        protected override void SetArgument(string name, BsonValue value)
+        {
+            switch (name)
+            {
+                case "filter":
+                    _filter = new BsonDocumentFilterDefinition<BsonDocument>(value.AsBsonDocument);
+                    return;
+
+                case "session":
+                    _session = (IClientSessionHandle)_objectMap[value.AsString];
+                    return;
+            }
+
+            base.SetArgument(name, value);
+        }
+    }
+}

tests/MongoDB.Driver.Tests/JsonDrivenTests/JsonDrivenTestFactory.cs

@@ -70,6 +70,7 @@ public JsonDrivenTest CreateTest(string receiver, string name)
                     case "aggregate": return new JsonDrivenAggregateTest(collection, _objectMap);
                     case "bulkWrite": return new JsonDrivenBulkWriteTest(collection, _objectMap);
                     case "count": return new JsonDrivenCountTest(collection, _objectMap);
+                    case "countDocuments": return new JsonDrivenCountDocumentsTest(collection, _objectMap);
                     case "deleteMany": return new JsonDrivenDeleteManyTest(collection, _objectMap);
                     case "deleteOne": return new JsonDrivenDeleteOneTest(collection, _objectMap);
                     case "distinct": return new JsonDrivenDistinctTest(collection, _objectMap);

tests/MongoDB.Driver.Tests/Specifications/transactions/tests/abort.json

@@ -441,7 +441,6 @@
             }
           },
           "result": {
-            "errorCodeName": "DuplicateKey",
             "errorLabelsOmit": [
               "TransientTransactionError",
               "UnknownTransactionCommitResult"

tests/MongoDB.Driver.Tests/Specifications/transactions/tests/abort.yml

@@ -297,7 +297,9 @@ tests:
           document:
             _id: 1
         result:
-          errorCodeName: DuplicateKey
+          # Don't assert on errorCodeName because (after SERVER-38583) the
+          # DuplicateKey is reported in writeErrors, not as a top-level
+          # command error.
           errorLabelsOmit: ["TransientTransactionError", "UnknownTransactionCommitResult"]
       # Make sure the server aborted the transaction.
       - name: insertOne

tests/MongoDB.Driver.Tests/Specifications/transactions/tests/error-labels.json

@@ -25,7 +25,6 @@
             ]
           },
           "result": {
-            "errorCodeName": "DuplicateKey",
             "errorLabelsOmit": [
               "TransientTransactionError",
               "UnknownTransactionCommitResult"

tests/MongoDB.Driver.Tests/Specifications/transactions/tests/error-labels.yml

@@ -17,7 +17,9 @@ tests:
             - _id: 1
             - _id: 1
         result:
-          errorCodeName: DuplicateKey
+          # Don't assert on errorCodeName because (after SERVER-38583) the
+          # DuplicateKey is reported in writeErrors, not as a top-level
+          # command error.
           errorLabelsOmit: ["TransientTransactionError", "UnknownTransactionCommitResult"]
       - name: abortTransaction
         object: session0