Added MongoClientSettings test

Author: papafe

src/MongoDB.Driver/Core/Connections/Socks5AuthenticationSettings.cs

@@ -42,6 +42,17 @@ public static Socks5AuthenticationSettings UsernamePassword(string username, str
     /// </summary>
     public sealed class NoAuthenticationSettings : Socks5AuthenticationSettings
     {
+        /// <inheritdoc />
+        public override bool Equals(object obj)
+        {
+            return obj is Socks5AuthenticationSettings;
+        }
+
+        /// <inheritdoc />
+        public override int GetHashCode()
+        {
+            return 1;
+        }
     }
 
     /// <summary>

src/MongoDB.Driver/Core/Connections/Socks5ProxySettings.cs

@@ -80,7 +80,6 @@ public override int GetHashCode()
             .GetHashCode();
     }
 
-
     /// <inheritdoc/>
     public override string ToString()
     {

tests/MongoDB.Driver.Tests/MongoClientSettingsTests.cs

@@ -25,6 +25,7 @@
 using MongoDB.Driver.Core.Clusters;
 using MongoDB.Driver.Core.Compression;
 using MongoDB.Driver.Core.Configuration;
+using MongoDB.Driver.Core.Connections;
 using MongoDB.Driver.Core.Servers;
 using MongoDB.Driver.Core.TestHelpers.XunitExtensions;
 using MongoDB.Driver.Encryption;
@@ -233,6 +234,8 @@ public void TestConnectTimeout()
             Assert.Throws<InvalidOperationException>(() => { settings.ConnectTimeout = connectTimeout; });
         }
 
+        //TODO I understand we want to keep tests in alphabetical order, but I think it would make sense to group them by scope
+        //Tests like this, that should be modified for every new setting added (for instance) should be at the top of this test suite.
         [Fact]
         public void TestDefaults()
         {
@@ -266,6 +269,7 @@ public void TestDefaults()
             Assert.Equal(ServerMonitoringMode.Auto, settings.ServerMonitoringMode);
             Assert.Equal(MongoDefaults.ServerSelectionTimeout, settings.ServerSelectionTimeout);
             Assert.Equal(MongoDefaults.SocketTimeout, settings.SocketTimeout);
+            Assert.Equal(null, settings.Socks5ProxySettings);
             Assert.Null(settings.SslSettings);
 #pragma warning disable 618
             Assert.Equal(false, settings.UseSsl);
@@ -435,6 +439,10 @@ public void TestEquals()
             clone.SocketTimeout = new TimeSpan(1, 2, 3);
             Assert.False(clone.Equals(settings));
 
+            clone = settings.Clone();
+            clone.Socks5ProxySettings = Socks5ProxySettings.Create("host.com", null, null, null);
+            Assert.False(clone.Equals(settings));
+
             clone = settings.Clone();
             clone.SslSettings = new SslSettings { CheckCertificateRevocation = false };
             Assert.False(clone.Equals(settings));
@@ -475,6 +483,7 @@ public void TestEquals()
             settings.ReadConcern = ReadConcern.Majority;
             settings.ReadEncoding = new UTF8Encoding(false, false);
             settings.ServerApi = new ServerApi(ServerApiVersion.V1);
+            settings.Socks5ProxySettings = Socks5ProxySettings.Create("host.com", 8080, null, null);
             settings.WriteConcern = WriteConcern.W2;
             settings.WriteEncoding = new UTF8Encoding(false, false);
 
@@ -485,6 +494,7 @@ public void TestEquals()
             clone.ReadEncoding = new UTF8Encoding(false, false);
             clone.ReadPreference = clone.ReadPreference.With(settings.ReadPreference.ReadPreferenceMode);
             clone.ServerApi = new ServerApi(settings.ServerApi.Version);
+            clone.Socks5ProxySettings = Socks5ProxySettings.Create("host.com", 8080, null, null);
             clone.WriteConcern = WriteConcern.FromBsonDocument(settings.WriteConcern.ToBsonDocument());
             clone.WriteEncoding = new UTF8Encoding(false, false);
 
@@ -582,7 +592,8 @@ public void TestFromUrl()
                 "maxConnecting=3;maxIdleTime=124;maxLifeTime=125;maxPoolSize=126;minPoolSize=127;readConcernLevel=majority;" +
                 "readPreference=secondary;readPreferenceTags=a:1,b:2;readPreferenceTags=c:3,d:4;retryReads=false;retryWrites=true;socketTimeout=129;" +
                 "serverMonitoringMode=Stream;serverSelectionTimeout=20s;tls=true;sslVerifyCertificate=false;waitqueuesize=130;waitQueueTimeout=131;" +
-                "w=1;fsync=true;journal=true;w=2;wtimeout=131;gssapiServiceName=other";
+                "w=1;fsync=true;journal=true;w=2;wtimeout=131;gssapiServiceName=other" +
+                "&proxyHost=host.com&proxyPort=2020&proxyUsername=user&proxyPassword=passw";
             var builder = new MongoUrlBuilder(connectionString);
             var url = builder.ToMongoUrl();
 
@@ -620,6 +631,10 @@ public void TestFromUrl()
             Assert.Equal(ServerMonitoringMode.Stream, settings.ServerMonitoringMode);
             Assert.Equal(url.ServerSelectionTimeout, settings.ServerSelectionTimeout);
             Assert.Equal(url.SocketTimeout, settings.SocketTimeout);
+            Assert.Equal(url.ProxyHost, settings.Socks5ProxySettings.Host);
+            Assert.Equal(url.ProxyPort, settings.Socks5ProxySettings.Port);
+            Assert.Equal(url.ProxyUsername, ((Socks5AuthenticationSettings.UsernamePasswordAuthenticationSettings)settings.Socks5ProxySettings.Authentication).Username);
+            Assert.Equal(url.ProxyPassword, ((Socks5AuthenticationSettings.UsernamePasswordAuthenticationSettings)settings.Socks5ProxySettings.Authentication).Password);
 #pragma warning disable 618
             Assert.Equal(url.TlsDisableCertificateRevocationCheck, !settings.SslSettings.CheckCertificateRevocation);
             Assert.Equal(url.UseSsl, settings.UseSsl);
@@ -1175,6 +1190,21 @@ public void TestSocketTimeout()
             Assert.Throws<InvalidOperationException>(() => { settings.SocketTimeout = socketTimeout; });
         }
 
+        [Fact]
+        public void TestSocks5ProxySettings()
+        {
+            var settings = new MongoClientSettings();
+            Assert.Equal(null, settings.Socks5ProxySettings);
+
+            var newProxySettings = Socks5ProxySettings.Create("host.com", 280, "test", "test");
+            settings.Socks5ProxySettings = newProxySettings;
+            Assert.Equal(newProxySettings, settings.Socks5ProxySettings);
+
+            settings.Freeze();
+            Assert.Equal(newProxySettings, settings.Socks5ProxySettings);
+            Assert.Throws<InvalidOperationException>(() => { settings.Socks5ProxySettings = newProxySettings; });
+        }
+
         [Fact]
         public void TestSslSettings()
         {
@@ -1326,6 +1356,7 @@ public void ToClusterKey_should_copy_relevant_values()
                 ServerMonitoringMode = ServerMonitoringMode.Poll,
                 ServerSelectionTimeout = TimeSpan.FromSeconds(6),
                 SocketTimeout = TimeSpan.FromSeconds(4),
+                Socks5ProxySettings = Socks5ProxySettings.Create("host", 2020, null, null),
                 SslSettings = sslSettings,
                 UseTls = true,
 #pragma warning disable 618
@@ -1362,6 +1393,7 @@ public void ToClusterKey_should_copy_relevant_values()
             result.ServerMonitoringMode.Should().Be(ServerMonitoringMode.Poll);
             result.ServerSelectionTimeout.Should().Be(subject.ServerSelectionTimeout);
             result.SocketTimeout.Should().Be(subject.SocketTimeout);
+            result.Socks5ProxySettings.Should().Be(subject.Socks5ProxySettings);
             result.SslSettings.Should().Be(subject.SslSettings);
             result.UseTls.Should().Be(subject.UseTls);
 #pragma warning disable 618