Skip to content

Commit 681f461

Browse files
committed
Small corrections
1 parent acd8a64 commit 681f461

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

src/MongoDB.Bson/BsonExtensionMethods.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ namespace MongoDB.Bson
2626
public static class BsonExtensionMethods
2727
{
2828
//DOMAIN-API We should remove all the methods that do not take a serialization domain.
29-
//QUESTION: Do we want to do something now about this...? It's used also internally, but it seems in most cases it's used for "default serialization", so it should be ok.
29+
//QUESTION: Do we want to do something now about this...? The methods are also used internally, but it seems in most cases it's used for "default serialization" and for "ToString" methods, so it should be ok.
3030
/// <summary>
3131
/// Serializes an object to a BSON byte array.
3232
/// </summary>

src/MongoDB.Driver/Authentication/SaslAuthenticator.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ private CommandWireProtocol<BsonDocument> CreateCommandProtocol(BsonDocument com
257257
resultSerializer: BsonDocumentSerializer.Instance,
258258
messageEncoderSettings: null,
259259
serverApi: _serverApi,
260-
serializationDomain: BsonSerializer.DefaultSerializationDomain); //QUESTION Is it correct to use the default serialization domain here?
260+
serializationDomain: BsonSerializer.DefaultSerializationDomain);
261261

262262
private BsonDocument CreateStartCommand(byte[] bytesToSendToServer)
263263
{

src/MongoDB.Driver/Core/Bindings/CoreSession.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,7 @@ private IReadOperation<BsonDocument> CreateCommitTransactionOperation(OperationC
454454
{
455455
var writeConcern = GetCommitTransactionWriteConcern(operationContext, isCommitRetry);
456456
var maxCommitTime = _currentTransaction.TransactionOptions.MaxCommitTime;
457-
//QUESTION Is it correct we only need a default domain here?
457+
//We only use BsonDocumentSerializer with the domain, so using the default one is fine.
458458
return new CommitTransactionOperation(_currentTransaction.RecoveryToken, writeConcern, BsonSerializer.DefaultSerializationDomain) { MaxCommitTime = maxCommitTime };
459459
}
460460

src/MongoDB.Driver/Core/Connections/ConnectionInitializer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ private CommandWireProtocol<BsonDocument> CreateGetLastErrorProtocol(ServerApi s
163163
resultSerializer: BsonDocumentSerializer.Instance,
164164
messageEncoderSettings: null,
165165
serverApi: serverApi,
166-
serializationDomain: BsonSerializer.DefaultSerializationDomain); //QUESTION Is it correct to use the default serialization domain here?
166+
serializationDomain: BsonSerializer.DefaultSerializationDomain);
167167
return getLastErrorProtocol;
168168
}
169169

src/MongoDB.Driver/Core/Connections/HelloHelper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ internal static CommandWireProtocol<BsonDocument> CreateProtocol(
8181
resultSerializer: BsonDocumentSerializer.Instance,
8282
messageEncoderSettings: null,
8383
serverApi,
84-
serializationDomain: BsonSerializer.DefaultSerializationDomain); //QUESTION Is it correct to use the default serialization domain here?
84+
serializationDomain: BsonSerializer.DefaultSerializationDomain); //Here and in similar cases using the default serialization domain is ok because we only serialize/deserialize BsonDocuments
8585
}
8686

8787
internal static HelloResult GetResult(

src/MongoDB.Driver/Core/WireProtocol/Messages/CommandMessageSection.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ internal abstract class CommandMessageSection
3636
internal abstract class Type0CommandMessageSection : CommandMessageSection
3737
{
3838
// constructors
39-
public Type0CommandMessageSection(object document, IBsonSerializer documentSerializer)
39+
protected Type0CommandMessageSection(object document, IBsonSerializer documentSerializer)
4040
{
41-
Ensure.IsNotNull((object)document, nameof(document));
41+
Ensure.IsNotNull(document, nameof(document));
4242
Document = document;
4343
DocumentSerializer = Ensure.IsNotNull(documentSerializer, nameof(documentSerializer));
4444
}
@@ -86,7 +86,7 @@ protected BatchableCommandMessageSection(
8686
internal abstract class Type1CommandMessageSection : BatchableCommandMessageSection
8787
{
8888
// constructors
89-
public Type1CommandMessageSection(
89+
protected Type1CommandMessageSection(
9090
string identifier,
9191
IBatchableSource<object> documents,
9292
IBsonSerializer documentSerializer,

0 commit comments

Comments
 (0)