Skip to content

Commit 73539cf

Browse files
committed
removed rootSerializer from TypedQueryBuilder as it was unused.
1 parent 475c55a commit 73539cf

File tree

3 files changed

+17
-20
lines changed

3 files changed

+17
-20
lines changed

Driver/Builders/QueryBuilder.cs

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ public static IMongoQuery Null
3939
get { return null; }
4040
}
4141

42+
// public static methods
4243
/// <summary>
4344
/// Builds a query using a strongly-typed query builder.
4445
/// </summary>
@@ -51,19 +52,6 @@ public static IMongoQuery Build<TDocument>(Func<QueryBuilder<TDocument>, IMongoQ
5152
return queryBuilderFunction(queryBuilder);
5253
}
5354

54-
/// <summary>
55-
/// Builds a query from an expression.
56-
/// </summary>
57-
/// <typeparam name="TDocument">The entity type.</typeparam>
58-
/// <param name="expression">The query.</param>
59-
/// <returns>An IMongoQuery.</returns>
60-
public static IMongoQuery Where<TDocument>(Expression<Func<TDocument, bool>> expression)
61-
{
62-
var builder = new QueryBuilder<TDocument>();
63-
return builder.Where(expression);
64-
}
65-
66-
// public static methods
6755
/// <summary>
6856
/// Tests that the named array element contains all of the values (see $all).
6957
/// </summary>
@@ -636,6 +624,18 @@ public static QueryComplete Where(BsonJavaScript javaScript)
636624
return new QueryComplete(new BsonDocument("$where", javaScript));
637625
}
638626

627+
/// <summary>
628+
/// Builds a query from an expression.
629+
/// </summary>
630+
/// <typeparam name="TDocument">The entity type.</typeparam>
631+
/// <param name="expression">The query.</param>
632+
/// <returns>An IMongoQuery.</returns>
633+
public static IMongoQuery Where<TDocument>(Expression<Func<TDocument, bool>> expression)
634+
{
635+
var builder = new QueryBuilder<TDocument>();
636+
return builder.Where(expression);
637+
}
638+
639639
/// <summary>
640640
/// Tests that the value of the named element is within a circle (see $within and $center).
641641
/// </summary>

Driver/Builders/TypedQueryBuilder.cs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ public class QueryBuilder<TDocument>
3535
{
3636
// private fields
3737
private readonly BsonSerializationInfoHelper _serializationInfoHelper;
38-
private readonly IBsonSerializer _rootSerializer;
3938
private readonly PredicateTranslator _predicateTranslator;
4039
private readonly UntypedQueryBuilder _queryBuilder;
4140

@@ -44,18 +43,16 @@ public class QueryBuilder<TDocument>
4443
/// Initializes a new instance of the <see cref="QueryBuilder&lt;TDocument&gt;"/> class.
4544
/// </summary>
4645
public QueryBuilder()
47-
: this(new BsonSerializationInfoHelper(), null)
46+
: this(new BsonSerializationInfoHelper())
4847
{ }
4948

5049
/// <summary>
5150
/// Initializes a new instance of the <see cref="QueryBuilder&lt;TDocument&gt;"/> class.
5251
/// </summary>
5352
/// <param name="serializationInfoHelper">The serialization info helper.</param>
54-
/// <param name="rootSerializer">The root serializer.</param>
55-
internal QueryBuilder(BsonSerializationInfoHelper serializationInfoHelper, IBsonSerializer rootSerializer)
53+
internal QueryBuilder(BsonSerializationInfoHelper serializationInfoHelper)
5654
{
5755
_serializationInfoHelper = serializationInfoHelper;
58-
_rootSerializer = rootSerializer;
5956
_predicateTranslator = new PredicateTranslator(_serializationInfoHelper);
6057
_queryBuilder = new UntypedQueryBuilder();
6158
}
@@ -111,7 +108,7 @@ public IMongoQuery ElemMatch<TValue>(Expression<Func<TDocument, IEnumerable<TVal
111108
{
112109
var serializationInfo = _serializationInfoHelper.GetSerializationInfo(memberExpression);
113110
var itemSerializationInfo = _serializationInfoHelper.GetItemSerializationInfo("ElemMatch", serializationInfo);
114-
var elementQueryBuilder = new QueryBuilder<TValue>(_serializationInfoHelper, itemSerializationInfo.Serializer);
111+
var elementQueryBuilder = new QueryBuilder<TValue>(_serializationInfoHelper);
115112
var elementQuery = elementQueryBuilderFunction(elementQueryBuilder);
116113
return _queryBuilder.ElemMatch(serializationInfo.ElementName, elementQuery);
117114
}

Driver/Builders/UpdateBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1807,7 +1807,7 @@ public UpdateBuilder<TDocument> Pull<TValue>(Expression<Func<TDocument, IEnumera
18071807

18081808
var serializationInfo = _serializationInfoHelper.GetSerializationInfo(memberExpression);
18091809
var itemSerializationInfo = _serializationInfoHelper.GetItemSerializationInfo("Pull", serializationInfo);
1810-
var elementQueryBuilder = new QueryBuilder<TValue>(_serializationInfoHelper, itemSerializationInfo.Serializer);
1810+
var elementQueryBuilder = new QueryBuilder<TValue>(_serializationInfoHelper);
18111811
var elementQuery = elementQueryBuilderFunction(elementQueryBuilder);
18121812
_updateBuilder = _updateBuilder.Pull(serializationInfo.ElementName, elementQuery);
18131813
return this;

0 commit comments

Comments
 (0)