CSHARP-4689: MongoUrl should have a registered TypeConverter

Co-authored-by: Corniel Nobel <[email protected]>

Author: Corniel

src/MongoDB.Driver/MongoUrl.cs

@@ -15,6 +15,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
@@ -29,6 +30,7 @@ namespace MongoDB.Driver
     /// Represents an immutable URL style connection string. See also MongoUrlBuilder.
     /// </summary>
     [Serializable]
+    [TypeConverter(typeof(MongoUrlTypeConverter))]
     public class MongoUrl : IEquatable<MongoUrl>
     {
         // private static fields

src/MongoDB.Driver/MongoUrlTypeConverter.cs

@@ -0,0 +1,35 @@
+/* Copyright 2010-present MongoDB Inc.
+*
+* Licensed under the Apache License, Version 2.0 (the "License");
+* you may not use this file except in compliance with the License.
+* You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+
+using System;
+using System.ComponentModel;
+using System.Globalization;
+
+namespace MongoDB.Driver
+{
+    /// <summary>Implements a <see cref="TypeConverter"/> for converting <see cref="MongoUrl"/>.</summary>
+    public sealed class MongoUrlTypeConverter : TypeConverter
+    {
+        /// <inheritdoc />
+        public override bool CanConvertFrom(ITypeDescriptorContext context, Type sourceType)
+            => sourceType == typeof(string) || base.CanConvertFrom(context, sourceType);
+
+        /// <inheritdoc />
+        public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)
+            => value is string str
+            ? new MongoUrl(str)
+            : base.ConvertFrom(context, culture, value);
+    }
+}

tests/MongoDB.Driver.Tests/MongoUrlTests.cs

@@ -15,14 +15,15 @@
 
 using System;
 using System.Collections.Generic;
+using System.ComponentModel;
 using System.Threading.Tasks;
 using FluentAssertions;
 using MongoDB.Bson;
 using MongoDB.Bson.TestHelpers;
-using MongoDB.TestHelpers.XunitExtensions;
 using MongoDB.Driver.Core.Clusters;
 using MongoDB.Driver.Core.Compression;
 using MongoDB.Driver.Core.Configuration;
+using MongoDB.TestHelpers.XunitExtensions;
 using Xunit;
 
 namespace MongoDB.Driver.Tests
@@ -457,6 +458,34 @@ public void TestSrvMaxHosts()
             subject.SrvMaxHosts.Should().Be(2);
         }
 
+        [Fact]
+        public void Decorated_with_TypeConverter()
+        {
+            var converter = TypeDescriptor.GetConverter(typeof(MongoUrl));
+
+            converter.Should().BeOfType<MongoUrlTypeConverter>();
+        }
+
+        [Fact]
+        public void Convert_from_string_should_work()
+        {
+            var converter = TypeDescriptor.GetConverter(typeof(MongoUrl));
+
+            var result = converter.ConvertFrom("mongodb://localhost");
+
+            result.Should().Be(new MongoUrl("mongodb://localhost"));
+        }
+
+        [Fact]
+        public void Convert_to_string_should_work()
+        {
+            var converter = TypeDescriptor.GetConverter(typeof(MongoUrl));
+
+            var result = converter.ConvertTo(new MongoUrl("mongodb://localhost"), typeof(string));
+
+            result.Should().Be("mongodb://localhost");
+        }
+
         // private methods
         private IEnumerable<MongoUrl> EnumerateBuiltAndParsedUrls(
             MongoUrlBuilder built,