CSHARP-4595: Support GridFS with Stable API. (#1064)

Author: JamesKovacs

src/MongoDB.Driver.Core/Core/Misc/Feature.cs

@@ -116,6 +116,7 @@ public class Feature
         private static readonly Feature __snapshotReads = new Feature("SnapshotReads", WireVersion.Server50, notSupportedMessage: "Snapshot reads require MongoDB 5.0 or later");
         private static readonly Feature __sortArrayOperator = new Feature("SortArrayOperator", WireVersion.Server52);
         private static readonly Feature __speculativeAuthentication = new Feature("SpeculativeAuthentication", WireVersion.Server44);
+        private static readonly Feature __stableApi = new Feature("StableAPI", WireVersion.Server50);
         private static readonly Feature __streamingHello = new Feature("StreamingHello", WireVersion.Server44);
         private static readonly Feature __tailableCursor = new Feature("TailableCursor", WireVersion.Server32);
         private static readonly Feature __toConversionOperators = new Feature("ToConversionOperators", WireVersion.Server40);
@@ -644,6 +645,11 @@ public class Feature
         /// </summary>
         public static Feature SpeculativeAuthentication => __speculativeAuthentication;
 
+        /// <summary>
+        /// Gets the speculative authentication feature.
+        /// </summary>
+        public static Feature StableApi => __stableApi;
+
         /// <summary>
         /// Gets the streaming hello feature.
         /// </summary>

src/MongoDB.Driver.GridFS/GridFSBucket.cs

@@ -17,11 +17,9 @@
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
 using System.IO;
-using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
 using MongoDB.Bson;
-using MongoDB.Bson.IO;
 using MongoDB.Bson.Serialization;
 using MongoDB.Bson.Serialization.Serializers;
 using MongoDB.Driver.Core.Bindings;
@@ -643,7 +641,7 @@ private FindOperation<GridFSFileInfo<TFileId>> CreateFindOperation(FilterDefinit
                 Filter = renderedFilter,
                 Limit = options.Limit,
                 MaxTime = options.MaxTime,
-                NoCursorTimeout = options.NoCursorTimeout ?? false,
+                NoCursorTimeout = options.NoCursorTimeout,
                 ReadConcern = GetReadConcern(),
                 RetryRequested = _database.Client.Settings.RetryReads,
                 Skip = options.Skip,

tests/MongoDB.Driver.GridFS.Tests/GridFSBucketTests.cs

@@ -630,6 +630,79 @@ public void UploadFromStream_should_throw_when_source_is_null(
             action.ShouldThrow<ArgumentNullException>().And.ParamName.Should().Be("source");
         }
 
+        [Theory]
+        [ParameterAttributeData]
+        public void GridFS_should_work_with_strict_stable_api(
+            [Values(false, true)] bool async)
+        {
+            RequireServer.Check().Supports(Feature.StableApi);
+
+            var settings = DriverTestConfiguration.GetClientSettings();
+            settings.ServerApi = new ServerApi(ServerApiVersion.V1, strict: true, deprecationErrors: true);
+
+            using var client = DriverTestConfiguration.CreateDisposableClient(settings);
+            var database = client.GetDatabase(DriverTestConfiguration.DatabaseNamespace.DatabaseName);
+            var subject = new GridFSBucket<ObjectId>(database);
+
+            if (async)
+            {
+                subject.DropAsync().GetAwaiter().GetResult();
+            }
+            else
+            {
+                subject.Drop();
+            }
+
+            const string filename = "hello.txt";
+            const string content = "Hello, world!";
+            var bytes = Encoding.UTF8.GetBytes(content);
+            var id = ObjectId.GenerateNewId();
+            if (async)
+            {
+                subject.UploadFromBytesAsync(id, filename, bytes).GetAwaiter().GetResult();
+            }
+            else
+            {
+                subject.UploadFromBytes(id, filename, bytes);
+            }
+
+            var filter = Builders<GridFSFileInfo<ObjectId>>.Filter.Eq(x => x.Id, id);
+            List<GridFSFileInfo<ObjectId>> results;
+            if (async)
+            {
+                results = subject.FindAsync(filter).GetAwaiter().GetResult().ToList();
+            }
+            else
+            {
+                results = subject.Find(filter).ToList();
+            }
+
+            results.Count.Should().Be(1);
+            results.First().Filename.Should().Be(filename);
+
+            byte[] downloadedBytes;
+            if (async)
+            {
+                downloadedBytes = subject.DownloadAsBytesAsync(id).GetAwaiter().GetResult();
+            }
+            else
+            {
+                downloadedBytes = subject.DownloadAsBytes(id);
+            }
+
+            var downloadedContent = Encoding.UTF8.GetString(downloadedBytes);
+            downloadedContent.Should().Be(content);
+
+            if (async)
+            {
+                subject.DropAsync().GetAwaiter().GetResult();
+            }
+            else
+            {
+                subject.Drop();
+            }
+        }
+
         // private methods
         private GridFSBucket CreateSubject(GridFSBucketOptions options = null)
         {