Skip to content

Commit d302702

Browse files
committed
Small things
1 parent 1603128 commit d302702

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

src/MongoDB.Bson/Serialization/IBsonSerializerExtensions.cs

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
*/
1515

1616
using System;
17+
using System.ComponentModel;
1718
using MongoDB.Bson.IO;
1819
using MongoDB.Bson.Serialization.Conventions;
1920

@@ -56,9 +57,21 @@ public static TValue Deserialize<TValue>(this IBsonSerializer<TValue> serializer
5657
/// <param name="serializer">The serializer.</param>
5758
/// <returns>The discriminator convention.</returns>
5859
public static IDiscriminatorConvention GetDiscriminatorConvention(this IBsonSerializer serializer) =>
60+
GetDiscriminatorConvention(serializer, BsonSerializer.DefaultSerializationDomain);
61+
62+
/// <summary>
63+
/// //TODO
64+
/// </summary>
65+
/// <param name="serializer"></param>
66+
/// <param name="serializationDomain"></param>
67+
/// <returns></returns>
68+
#if DEBUG
69+
[EditorBrowsable(EditorBrowsableState.Never)]
70+
#endif
71+
public static IDiscriminatorConvention GetDiscriminatorConvention(this IBsonSerializer serializer, IBsonSerializationDomain serializationDomain) =>
5972
serializer is IHasDiscriminatorConvention hasDiscriminatorConvention
6073
? hasDiscriminatorConvention.DiscriminatorConvention
61-
: BsonSerializer.LookupDiscriminatorConvention(serializer.ValueType); //TODO We can keep this as is? In the long run this method should have the domain passed.
74+
: serializationDomain.LookupDiscriminatorConvention(serializer.ValueType);
6275

6376
/// <summary>
6477
/// Serializes a value.

src/MongoDB.Driver/MongoDatabase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -660,7 +660,7 @@ private Task CreateCollectionHelperAsync<TDocument>(IClientSessionHandle session
660660

661661
private IWriteOperation<BsonDocument> CreateCreateCollectionOperation<TDocument>(string name, CreateCollectionOptions<TDocument> options, ExpressionTranslationOptions translationOptions)
662662
{
663-
var serializerRegistry = options.SerializerRegistry ?? BsonSerializer.SerializerRegistry;
663+
var serializerRegistry = options.SerializerRegistry ?? BsonSerializer.SerializerRegistry; //TODO What do we do here....?
664664
var documentSerializer = options.DocumentSerializer ?? serializerRegistry.GetSerializer<TDocument>();
665665

666666
var clusteredIndex = options.ClusteredIndex?.Render(documentSerializer, serializerRegistry, translationOptions);

0 commit comments

Comments
 (0)