CSHARP-5797: Add C# 14 testing #1834
Conversation
BorisDog
added
the
chore
There was a problem hiding this comment.
Pull request overview
This PR adds C# 14 testing infrastructure to the MongoDB C# driver project to ensure compatibility with the upcoming C# 14 language version. The changes include creating a new Release_CSharp_14 build configuration, updating test code to be compatible with C# 14 syntax changes, and configuring CI/CD pipelines to run tests with C# 14.
- Added new
Release_CSharp_14build configuration with LangVersion 14 for test projects while keeping source projects on C# 12 - Updated test code to address C# 14 breaking changes: escaped
fieldidentifiers, explicit array syntax forstring.Concat, and disambiguatedReverse()calls - Configured CI/CD to run unit tests with C# 14 on .NET 10.0 across all platforms
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/BuildProps/Tests.Build.props | Added Release_CSharp_14 configuration with LangVersion 14 and CSHARP_14 conditional compilation symbol |
| src/Directory.Build.props | Added Release_CSharp_14 configuration for source projects (keeps LangVersion at 12) |
| CSharpDriver.sln | Added Release_CSharp_14 configuration mappings for all projects in the solution |
| evergreen/evergreen.yml | Added unit-tests-net100-v14 task for C# 14 testing on all platforms (Windows, Ubuntu, macOS) |
| evergreen/run-unit-tests.sh | Added CONFIGURATION environment variable support with default to 'Release' |
| evergreen/compile-sources.sh | Added CONFIGURATION environment variable support for build command |
| tests/MongoDB.Bson.Tests/Serialization/ExtensionMembersTests.cs | New test file validating C# 14 extension members feature compatibility with serialization |
| tests/MongoDB.Bson.Tests/IO/*.cs (8 files) | Renamed field variables to @field to avoid conflicts with C# 14's contextual keyword in property accessors |
| tests/MongoDB.Driver.Tests/Linq/Linq3ImplementationWithLinq2Tests/Translators/AggregateProjectTranslatorTests.cs | Cast to IEnumerable before calling Reverse() to disambiguate overload resolution |
| tests/MongoDB.Driver.Encryption.Tests/BasicTests.cs | Changed to Enumerable.Reverse() static method to avoid C# 14 overload ambiguity |
| tests/MongoDB.Driver.Tests/Linq/Linq3Implementation/Translators/ExpressionToAggregationExpressionTranslators/MethodTranslators/StringConcatMethodToAggregationExpressionTranslatorTests.cs | Updated string.Concat calls to use explicit array syntax instead of params |
| tests/MongoDB.Driver.Tests/Linq/Linq3Implementation/Jira/CSharp5071Tests.cs | Updated string.Concat calls to use explicit array syntax in 22 test cases |
| tests/MongoDB.Driver.Tests/Linq/Linq3Implementation/Jira/CSharp5749Tests.cs | Reformatted long method call lines for better readability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "stringconstant+stringproperty+stringconstant" => collection.AsQueryable().Select(x => string.Concat(new[] { "X" + x.B + "Z" })), | ||
| "stringconstant+stringproperty+stringproperty" => collection.AsQueryable().Select(x => string.Concat(new[] { "X" + x.B + x.C })), | ||
| "stringproperty+intconstant+stringproperty" => collection.AsQueryable().Select(x => string.Concat(new[] { x.A + 2 + x.C })), | ||
| "stringproperty+intproperty+stringproperty" => collection.AsQueryable().Select(x => string.Concat(new[] { x.A + x.J + x.C})), |
There was a problem hiding this comment.
Missing space before the closing brace. Should be x.C } instead of x.C} for consistency with the other lines in this switch expression.
| "stringproperty+intproperty+stringproperty" => collection.AsQueryable().Select(x => string.Concat(new[] { x.A + x.J + x.C})), | |
| "stringproperty+intproperty+stringproperty" => collection.AsQueryable().Select(x => string.Concat(new[] { x.A + x.J + x.C })), |
damieng
left a comment
damieng
left a comment
There was a problem hiding this comment.
Just one minor optional suggestion.
| var field = _instance.GetType().GetField("_disposed", BindingFlags.NonPublic | BindingFlags.Instance); | ||
| return (bool)field.GetValue(_instance); | ||
| var @field = _instance.GetType().GetField("_disposed", BindingFlags.NonPublic | BindingFlags.Instance); | ||
| return (bool)@field.GetValue(_instance); |
There was a problem hiding this comment.
A static extension method on Object called GetPrivateValue(string name) would be useful in this test lib and reduce a lot of boilerplate/noise across all these methods.
There was a problem hiding this comment.
Something very much like that exists in the Reflector.cs file in the MongoDB.Bson.TestHelpers project.
| { | ||
| "intproperty" => collection.AsQueryable().Select(x => string.Concat(x.I)), | ||
| "stringproperty" => collection.AsQueryable().Select(x => string.Concat(x.A)), | ||
| "stringproperty" => collection.AsQueryable().Select(x => string.Concat(new[] { x.A })), |
There was a problem hiding this comment.
Another one to add to the C# 14/.NET 10 gotcha list I suspect.
| } | ||
|
|
||
| static Expression VisitSequenceEqualMethod(MethodCallExpression node, MethodInfo method, ReadOnlyCollection<Expression> arguments) | ||
| static Expression VisitSequenceEqualMethod(MethodCallExpression node, MethodInfo method, |
There was a problem hiding this comment.
Minor: all parameters on the same line, or each on it's own.
There was a problem hiding this comment.
Thanks, not sure how this happened.
4 participants
No description provided.