changes

Author: zhouselena

.evergreen/config.yml

@@ -292,7 +292,7 @@ functions:
         binary: bash
         env:
           VERSION_ID: ${version_id}
-        include_expansions_in_env: [perf_uri_private_endpoint]
+        include_expansions_in_env: [PERF_URI_PRIVATE_ENDPOINT]
         args: [*task-runner, perf-pr-comment]
 
   run-enterprise-auth-tests:

internal/cmd/perfcomp/energystatistics_test.go

@@ -17,15 +17,11 @@ func createTestVectors(start1 int, stop1 int, step1 int, start2 int, stop2 int,
 	xData := []float64{}
 	yData := []float64{}
 
-	i := start1
-	for i < stop1 {
+	for i := start1; i < stop1; i += step1 {
 		xData = append(xData, float64(i))
-		i += step1
 	}
-	j := start2
-	for j < stop2 {
+	for j := start2; j < stop2; j += step2 {
 		yData = append(yData, float64(j))
-		j += step2
 	}
 
 	x := mat.NewDense(len(xData), 1, xData)
@@ -41,8 +37,8 @@ func TestEnergyStatistics(t *testing.T) {
 		e, tstat, h := GetEnergyStatistics(x, y)
 
 		del := 1e-3
-
-		assert.InDelta(t, 0.160, e, del) // |0.160 - e| < 1/100
+		// Limit precision of comparison to 3 digits after the decimal.
+		assert.InDelta(t, 0.160, e, del) // |0.160 - e| < 0.001
 		assert.InDelta(t, 8.136, tstat, del)
 		assert.InDelta(t, 0.002, h, del)
 	})
@@ -72,11 +68,10 @@ func TestEnergyStatistics(t *testing.T) {
 		y := mat.NewDense(1, 1, []float64{1})
 
 		e, tstat, h := GetEnergyStatistics(x, y)
-		del := 1e-3
 
-		assert.InDelta(t, 0.0, e, del)
-		assert.InDelta(t, 0.0, tstat, del)
-		assert.InDelta(t, 0.0, h, del)
+		assert.Equal(t, 0.0, e)
+		assert.Equal(t, 0.0, tstat)
+		assert.Equal(t, 0.0, h)
 	})
 
 }

internal/cmd/perfcomp/main.go

@@ -10,6 +10,7 @@ import (
 	"context"
 	"fmt"
 	"log"
+	"math"
 	"os"
 	"strings"
 	"time"
@@ -91,14 +92,14 @@ type EnergyStats struct {
 
 func main() {
 	// Connect to analytics node
-	uri := os.Getenv("perf_uri_private_endpoint")
+	uri := os.Getenv("PERF_URI_PRIVATE_ENDPOINT")
 	if uri == "" {
-		log.Panic("perf_uri_private_endpoint env variable is not set")
+		log.Panic("PERF_URI_PRIVATE_ENDPOINT env variable is not set")
 	}
 
 	version := os.Getenv("VERSION_ID")
 	if version == "" {
-		log.Panic("could not retrieve version")
+		log.Panic("VERSION_ID env variable is not set")
 	}
 
 	client, err1 := mongo.Connect(options.Client().ApplyURI(uri))
@@ -150,7 +151,11 @@ func findRawData(version string, coll *mongo.Collection) ([]RawData, error) {
 
 	cursor, err := coll.Find(findCtx, filter, findOptions)
 	if err != nil {
-		return nil, err
+		log.Panicf(
+			"Error retrieving raw data for version %q: %v",
+			version,
+			err,
+		)
 	}
 	defer cursor.Close(findCtx)
 
@@ -160,13 +165,20 @@ func findRawData(version string, coll *mongo.Collection) ([]RawData, error) {
 	for cursor.Next(findCtx) {
 		var rd RawData
 		if err := cursor.Decode(&rd); err != nil {
-			return nil, err
+			break
 		}
 		rawData = append(rawData, rd)
 	}
 
-	if err := cursor.Err(); err != nil {
-		return nil, err
+	if err == nil {
+		err = cursor.Err()
+	}
+	if err != nil {
+		log.Panicf(
+			"Error decoding raw data from version %q: %v",
+			version,
+			err,
+		)
 	}
 
 	return rawData, nil
@@ -208,7 +220,12 @@ func getEnergyStatsForOneBenchmark(rd RawData, coll *mongo.Collection) ([]*Energ
 
 		stableRegion, err := findLastStableRegion(testname, measurement, coll)
 		if err != nil {
-			return nil, err
+			log.Panicf(
+				"Error finding last stable region for test %q, measurement %q: %v",
+				testname,
+				measurement,
+				err,
+			)
 		}
 
 		pChange := GetPercentageChange(patchVal[0], stableRegion.Mean)
@@ -253,7 +270,7 @@ func generatePRComment(energyStats []*EnergyStats, version string) string {
 
 	var testCount int64
 	for _, es := range energyStats {
-		if es.Z > 1.96 || es.Z < -1.96 {
+		if math.Abs(es.Z) > 1.96 {
 			testCount += 1
 			fmt.Fprintf(&comment, "| %s | %s | %.4f | %.4f | %.4f | Avg: %.4f, Stdev: %.4f | %.4f |\n", es.Benchmark, es.Measurement, es.H, es.Z, es.PChange, es.StableRegion.Mean, es.StableRegion.Std, es.PatchValues[0])
 		}