Rename NewSessionWithID to NewSessionWithLSID and update docs and tests.

Author: matthewdale

internal/integration/mongointernal_test.go

@@ -20,7 +20,7 @@ import (
 	"go.mongodb.org/mongo-driver/v2/x/bsonx/bsoncore"
 )
 
-func TestNewSessionWithID(t *testing.T) {
+func TestNewSessionWithLSID(t *testing.T) {
 	mt := mtest.New(t)
 
 	mt.Run("can be used to pass a specific session ID to CRUD commands", func(mt *mtest.T) {
@@ -32,7 +32,7 @@ func TestNewSessionWithID(t *testing.T) {
 			AppendBinary("id", 4, []byte{0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15}).
 			Build())
 
-		sess := mongo.NewSessionWithID(mt.Client, sessionID)
+		sess := mongo.NewSessionWithLSID(mt.Client, sessionID)
 
 		ctx := mongo.NewSessionContext(context.Background(), sess)
 		_, err := mt.Coll.InsertOne(ctx, bson.D{{"foo", "bar"}})
@@ -52,22 +52,47 @@ func TestNewSessionWithID(t *testing.T) {
 		mt.Parallel()
 
 		sessionID := bson.Raw(bsoncore.NewDocumentBuilder().
-			AppendBinary("id", 4, []byte{}).
+			AppendBinary("id", 4, []byte{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}).
 			Build())
-		sess := mongo.NewSessionWithID(mt.Client, sessionID)
+		sess := mongo.NewSessionWithLSID(mt.Client, sessionID)
 
 		// Use a defer-recover block to catch the expected panic and assert that
 		// the recovered error is not nil.
 		defer func() {
 			err := recover()
-			assert.NotNil(mt, err, "expected panic error to not be nil")
+			assert.NotNil(mt, err, "expected EndSession to panic")
 		}()
 
+		// Expect this call to panic.
 		sess.EndSession(context.Background())
 
 		// We expect that calling EndSession on a Session returned by
-		// NewSessionWithID panics. This code will only be reached if EndSession
+		// NewSessionWithLSID panics. This code will only be reached if EndSession
 		// doesn't panic.
 		t.Errorf("expected EndSession to panic")
 	})
+
+	mt.Run("ClientSession.SetServer panics", func(mt *mtest.T) {
+		mt.Parallel()
+
+		sessionID := bson.Raw(bsoncore.NewDocumentBuilder().
+			AppendBinary("id", 4, []byte{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}).
+			Build())
+		sess := mongo.NewSessionWithLSID(mt.Client, sessionID)
+
+		// Use a defer-recover block to catch the expected panic and assert that
+		// the recovered error is not nil.
+		defer func() {
+			err := recover()
+			assert.NotNil(mt, err, "expected ClientSession.SetServer to panic")
+		}()
+
+		// Expect this call to panic.
+		sess.ClientSession().SetServer()
+
+		// We expect that calling ClientSession.SetServer on a Session returned
+		// by NewSessionWithLSID panics. This code will only be reached if
+		// ClientSession.SetServer doesn't panic.
+		t.Errorf("expected ClientSession.SetServer to panic")
+	})
 }

mongo/mongointernal.go

@@ -16,17 +16,17 @@ import (
 	"go.mongodb.org/mongo-driver/v2/x/mongo/driver/session"
 )
 
-// NewSessionWithID returns a Session with the given sessionID document. The
+// NewSessionWithLSID returns a Session with the given sessionID document. The
 // sessionID is a BSON document with key "id" containing a 16-byte UUID (binary
 // subtype 4).
 //
-// Sessions returned by NewSessionWithID are never added to the driver's session
-// pool. Calling EndSession on a Session returned by NewSessionWithID will
-// panic.
+// Sessions returned by NewSessionWithLSID are never added to the driver's
+// session pool. Calling "EndSession" or "ClientSession.SetServer" on a Session
+// returned by NewSessionWithLSID will panic.
 //
-// NewSessionWithID is intended only for internal use and may be changed or
+// NewSessionWithLSID is intended only for internal use and may be changed or
 // removed at any time.
-func NewSessionWithID(client *Client, sessionID bson.Raw) *Session {
+func NewSessionWithLSID(client *Client, sessionID bson.Raw) *Session {
 	return &Session{
 		clientSession: &session.Client{
 			Server: &session.Server{