Skip to content

Commit 27f5d62

Browse files
committed
Merge branch 'pr/127'
GODRIVER-741 Change-Id: I5f908fea4498d347d858e4e6a472806b40cf3e10
2 parents ea085ec + e877ac8 commit 27f5d62

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

x/network/connstring/connstring.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -573,12 +573,14 @@ func (p *parser) addOption(pair string) error {
573573
return fmt.Errorf("invalid value for %s: %s", key, value)
574574
}
575575
p.ServerSelectionTimeout = time.Duration(n) * time.Millisecond
576+
p.ServerSelectionTimeoutSet = true
576577
case "sockettimeoutms":
577578
n, err := strconv.Atoi(value)
578579
if err != nil || n < 0 {
579580
return fmt.Errorf("invalid value for %s: %s", key, value)
580581
}
581582
p.SocketTimeout = time.Duration(n) * time.Millisecond
583+
p.SocketTimeoutSet = true
582584
case "ssl":
583585
switch value {
584586
case "true":

x/network/connstring/connstring_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ func TestConnectTimeout(t *testing.T) {
139139
} else {
140140
require.NoError(t, err)
141141
require.Equal(t, test.expected, cs.ConnectTimeout)
142+
require.True(t, cs.ConnectTimeoutSet)
142143
}
143144
})
144145
}
@@ -396,6 +397,7 @@ func TestServerSelectionTimeout(t *testing.T) {
396397
} else {
397398
require.NoError(t, err)
398399
require.Equal(t, test.expected, cs.ServerSelectionTimeout)
400+
require.True(t, cs.ServerSelectionTimeoutSet)
399401
}
400402
})
401403
}
@@ -422,6 +424,7 @@ func TestSocketTimeout(t *testing.T) {
422424
} else {
423425
require.NoError(t, err)
424426
require.Equal(t, test.expected, cs.SocketTimeout)
427+
require.True(t, cs.SocketTimeoutSet)
425428
}
426429
})
427430
}
@@ -448,6 +451,7 @@ func TestWTimeout(t *testing.T) {
448451
} else {
449452
require.NoError(t, err)
450453
require.Equal(t, test.expected, cs.WTimeout)
454+
require.True(t, cs.WTimeoutSet)
451455
}
452456
})
453457
}

0 commit comments

Comments
 (0)