Merge branch 'master' into experiment-any-mongo

Author: matthewdale

.evergreen/config.yml

@@ -268,8 +268,11 @@ functions:
       type: test
       params:
         binary: bash
+        add_expansions_to_env: true
         env:
           VERSION_ID: ${version_id}
+          BASE_SHA: "${revision}"
+          HEAD_SHA: "${github_commit}"
         include_expansions_in_env: [PERF_URI_PRIVATE_ENDPOINT]
         args: [*task-runner, perf-pr-comment]
 
@@ -669,6 +672,7 @@ tasks:
         params:
           binary: bash
           args: [*task-runner, driver-benchmark]
+      - func: assume-test-secrets-ec2-role
       - func: send-perf-data
       - func: send-perf-pr-comment
 

.github/labeler.yml

@@ -1,4 +1,4 @@
-priority-3-low:
+review-priority-normal:
 - changed-files:
   - any-glob-to-any-file: '*'
 

.github/workflows/codeql.yml

@@ -2,9 +2,19 @@ name: "CodeQL"
 
 on:
   push:
-    branches: [ "v1", "cloud-*", "master", "release/*" ]
+    branches:
+      - "v1"
+      - "cloud-*"
+      - "master"
+      - "release/*"
+      - "feature/*"
   pull_request:
-    branches: [ "v1", "cloud-*", "master", "release/*" ]
+    branches:
+      - "v1"
+      - "cloud-*"
+      - "master"
+      - "release/*"
+      - "feature/*"
   schedule:
     - cron: '36 17 * * 0'
   workflow_call:

.gitignore

@@ -25,6 +25,7 @@ go.work.sum
 .task
 env.sh
 expansion.yml
+bin
 
 # AWS SAM-generated files
 internal/cmd/faas/awslambda/.aws-sam
@@ -38,6 +39,10 @@ internal/cmd/compilecheck/compilecheck.so
 api-report.md
 api-report.txt
 
+# Ignore perf report files
+perf-report.md
+perf-report.txt
+
 # Ignore secrets files
 secrets-expansion.yml
 secrets-export.sh

bson/raw_test.go

@@ -450,7 +450,7 @@ func BenchmarkRawString(b *testing.B) {
 			b.ReportAllocs()
 			b.ResetTimer()
 			for i := 0; i < b.N; i++ {
-				_ = bsoncore.Document(bs).StringN(1024) // Assuming you want to limit to 1024 bytes for this benchmark
+				_, _ = bsoncore.Document(bs).StringN(1024) // Assuming you want to limit to 1024 bytes for this benchmark
 			}
 		})
 	}
@@ -473,7 +473,7 @@ func TestComplexDocuments_StringN(t *testing.T) {
 			bson, _ := Marshal(tc.doc)
 			bsonDoc := bsoncore.Document(bson)
 
-			got := bsonDoc.StringN(tc.n)
+			got, _ := bsonDoc.StringN(tc.n)
 			assert.Equal(t, tc.n, len(got))
 		})
 	}
@@ -518,7 +518,7 @@ func createMassiveArraysDocument(arraySize int) D {
 func createUniqueVoluminousDocument(t *testing.T, size int) bsoncore.Document {
 	t.Helper()
 
-	docs := make(D, size)
+	docs := make(D, 0, size)
 
 	for i := 0; i < size; i++ {
 		docs = append(docs, E{
@@ -561,7 +561,7 @@ func createLargeSingleDoc(t *testing.T) bsoncore.Document {
 func createVoluminousArrayDocuments(t *testing.T, size int) bsoncore.Document {
 	t.Helper()
 
-	docs := make(D, size)
+	docs := make(D, 0, size)
 
 	for i := 0; i < size; i++ {
 		docs = append(docs, E{

etc/perf-pr-comment.sh

@@ -5,5 +5,22 @@
 set -eux
 
 pushd ./internal/cmd/perfcomp >/dev/null || exist
-GOWORK=off go run main.go --project="mongo-go-driver" ${VERSION_ID}
+GOWORK=off go build -o ../../../bin/perfcomp .
 popd >/dev/null
+
+# Generate perf report.
+GOWORK=off ./bin/perfcomp compare --project="mongo-go-driver" ${VERSION_ID} > ./internal/cmd/perfcomp/perf-report.txt
+
+if [[ -n "${BASE_SHA+set}" && -n "${HEAD_SHA+set}" && "$BASE_SHA" != "$HEAD_SHA" ]]; then
+    # Parse and generate perf comparison comment.
+    GOWORK=off ./bin/perfcomp mdreport
+    # Make the PR comment.
+    target=$DRIVERS_TOOLS/.evergreen/github_app/create_or_modify_comment.sh
+    bash $target -m "## 🧪 Performance Results" -c "$(pwd)/perf-report.md" -h $HEAD_SHA -o "mongodb" -n "mongo-go-driver"
+    rm ./perf-report.md
+else
+    # Skip comment if it isn't a PR run.
+    echo "Skipping Perf PR comment"
+fi
+
+rm ./internal/cmd/perfcomp/perf-report.txt

internal/bsoncoreutil/bsoncoreutil.go

@@ -8,7 +8,7 @@ package bsoncoreutil
 
 // Truncate truncates a given string for a certain width
 func Truncate(str string, width int) string {
-	if width == 0 {
+	if width <= 0 {
 		return ""
 	}