GODRIVER-2536 Return early in replaceErrors. (#1076)

benjirewis · benjirewis · commit 404feab9510d · 2022-09-16T13:40:21.000-04:00
diff --git a/mongo/errors.go b/mongo/errors.go
@@ -46,6 +46,11 @@ func (e ErrMapForOrderedArgument) Error() string {
 }
 
 func replaceErrors(err error) error {
+	// Return nil when err is nil to avoid costly reflection logic below.
+	if err == nil {
+		return nil
+	}
+
 	if err == topology.ErrTopologyClosed {
 		return ErrClientDisconnected
 	}

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,11 @@ func (e ErrMapForOrderedArgument) Error() string {`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`func replaceErrors(err error) error {`
	`49`	`+ // Return nil when err is nil to avoid costly reflection logic below.`
	`50`	`+ if err == nil {`
	`51`	`+ return nil`
	`52`	`+ }`
	`53`	`+`
`49`	`54`	`if err == topology.ErrTopologyClosed {`
`50`	`55`	`return ErrClientDisconnected`
`51`	`56`	`}`