GODRIVER-2156 Enable unused linter. (#773)

Author: matthewdale

.golangci.yml

@@ -18,7 +18,7 @@ linters:
     - staticcheck
     # - structcheck
     - typecheck
-    # - unused
+    - unused
     # - unconvert
     # - unparam
     # - varcheck
@@ -54,11 +54,23 @@ issues:
     - (^|/)data($|/)
     - (^|/)etc($|/)
   exclude-rules:
+    # Ignore some linters for example code that is intentionally simplified.
     - path: examples/
       linters:
         - revive
         - errcheck
+    # Ignore some linters for generated operation code.
+    # TODO: Re-enable once GODRIVER-2154 is done.
     - path: x/mongo/driver/operation/
       linters:
-        - staticcheck # TODO: Re-enable once GODRIVER-2154 is done.
-        - ineffassign # TODO: Re-enable once GODRIVER-2154 is done.
+        - staticcheck
+        - ineffassign
+    # Disable unused code linters for the copy/pasted "awsv4" package.
+    - path: x/mongo/driver/auth/internal/awsv4
+      linters:
+        - unused
+    # Disable "unused" linter for "crypt.go" because the linter doesn't work correctly without
+    # enabling CGO.
+    - path: x/mongo/driver/crypt.go
+      linters:
+        - unused

benchmark/harness_case.go

@@ -56,10 +56,6 @@ func (c *CaseDefinition) StopTimer() {
 	c.isRunning = false
 }
 
-func (c *CaseDefinition) roundedRuntime() time.Duration {
-	return roundDurationMS(c.Runtime)
-}
-
 func (c *CaseDefinition) Run(ctx context.Context) *BenchResult {
 	out := &BenchResult{
 		Trials:     1,

bson/bsoncodec/default_value_encoders_test.go

@@ -54,7 +54,6 @@ func TestDefaultValueEncoders(t *testing.T) {
 	type myuint uint
 	type myfloat32 float32
 	type myfloat64 float64
-	type mystring string
 
 	now := time.Now().Truncate(time.Millisecond)
 	pjsnum := new(json.Number)

bson/bsoncodec/registry.go

@@ -54,12 +54,6 @@ func (entme ErrNoTypeMapEntry) Error() string {
 // ErrNotInterface is returned when the provided type is not an interface.
 var ErrNotInterface = errors.New("The provided type is not an interface")
 
-var defaultRegistry *Registry
-
-func init() {
-	defaultRegistry = buildDefaultRegistry()
-}
-
 // A RegistryBuilder is used to build a Registry. This type is not goroutine
 // safe.
 type RegistryBuilder struct {

bson/bsoncodec/registry_test.go

@@ -409,9 +409,9 @@ func TestRegistry(t *testing.T) {
 	})
 }
 
-type fakeType1 struct{ b bool }
-type fakeType2 struct{ b bool }
-type fakeType4 struct{ b bool }
+type fakeType1 struct{}
+type fakeType2 struct{}
+type fakeType4 struct{}
 type fakeType5 func(string, string) string
 type fakeStructCodec struct{ fakeCodec }
 type fakeSliceCodec struct{ fakeCodec }

bson/bsonrw/value_reader.go

@@ -790,16 +790,6 @@ func (vr *valueReader) readCString() (string, error) {
 	return string(vr.d[start : start+int64(idx)]), nil
 }
 
-func (vr *valueReader) skipCString() error {
-	idx := bytes.IndexByte(vr.d[vr.offset:], 0x00)
-	if idx < 0 {
-		return io.EOF
-	}
-	// idx does not include the null byte
-	vr.offset += int64(idx) + 1
-	return nil
-}
-
 func (vr *valueReader) readString() (string, error) {
 	length, err := vr.readLength()
 	if err != nil {

bson/bsonrw/writer.go

@@ -76,27 +76,3 @@ func (sw *SliceWriter) Write(p []byte) (int, error) {
 	*sw = append(*sw, p...)
 	return written, nil
 }
-
-type writer []byte
-
-func (w *writer) Write(p []byte) (int, error) {
-	index := len(*w)
-	return w.WriteAt(p, int64(index))
-}
-
-func (w *writer) WriteAt(p []byte, off int64) (int, error) {
-	newend := off + int64(len(p))
-	if newend < int64(len(*w)) {
-		newend = int64(len(*w))
-	}
-
-	if newend > int64(cap(*w)) {
-		buf := make([]byte, int64(2*cap(*w))+newend)
-		copy(buf, *w)
-		*w = buf
-	}
-
-	*w = []byte(*w)[:newend]
-	copy([]byte(*w)[off:], p)
-	return len(p), nil
-}

bson/decoder_test.go

@@ -62,6 +62,9 @@ func TestDecoderv2(t *testing.T) {
 		}
 		t.Run("lookup error", func(t *testing.T) {
 			type certainlydoesntexistelsewhereihope func(string, string) string
+			// Avoid unused code lint error.
+			_ = certainlydoesntexistelsewhereihope(func(string, string) string { return "" })
+
 			cdeih := func(string, string) string { return "certainlydoesntexistelsewhereihope" }
 			dec, err := NewDecoder(bsonrw.NewBSONDocumentReader([]byte{}))
 			noerr(t, err)
@@ -249,21 +252,6 @@ func TestDecoderv2(t *testing.T) {
 	})
 }
 
-type testDecoderCodec struct {
-	EncodeValueCalled bool
-	DecodeValueCalled bool
-}
-
-func (tdc *testDecoderCodec) EncodeValue(bsoncodec.EncodeContext, bsonrw.ValueWriter, interface{}) error {
-	tdc.EncodeValueCalled = true
-	return nil
-}
-
-func (tdc *testDecoderCodec) DecodeValue(bsoncodec.DecodeContext, bsonrw.ValueReader, interface{}) error {
-	tdc.DecodeValueCalled = true
-	return nil
-}
-
 type testUnmarshaler struct {
 	invoked bool
 	err     error

bson/encoder_test.go

@@ -133,13 +133,3 @@ func docToBytes(d interface{}) []byte {
 	}
 	return b
 }
-
-type byteMarshaler []byte
-
-func (bm byteMarshaler) MarshalBSON() ([]byte, error) { return bm, nil }
-
-type _impl struct {
-	Foo string
-}
-
-func (_impl) method() {}

bson/primitive_codecs.go

@@ -90,25 +90,3 @@ func (PrimitiveCodecs) RawDecodeValue(dc bsoncodec.DecodeContext, vr bsonrw.Valu
 	val.Set(reflect.ValueOf(rdr))
 	return err
 }
-
-func (pc PrimitiveCodecs) encodeRaw(ec bsoncodec.EncodeContext, dw bsonrw.DocumentWriter, raw Raw) error {
-	var copier bsonrw.Copier
-	elems, err := raw.Elements()
-	if err != nil {
-		return err
-	}
-	for _, elem := range elems {
-		dvw, err := dw.WriteDocumentElement(elem.Key())
-		if err != nil {
-			return err
-		}
-
-		val := elem.Value()
-		err = copier.CopyValueFromBytes(dvw, val.Type, val.Value)
-		if err != nil {
-			return err
-		}
-	}
-
-	return dw.WriteDocumentEnd()
-}