GODRIVER-1488 turn off DecodeDeepZeroInline for mgocompat.Registry (#312)

Author: iwysiu

bson/mgocompat/bson_test.go

@@ -1685,3 +1685,31 @@ func TestMarshalRespectNil(t *testing.T) {
 	assert.NotNil(t, testStruct2.Map, "expected non-nil map")
 	assert.NotNil(t, testStruct2.MapPtr, "expected non-nil map ptr")
 }
+
+// Our mgocompat.Registry tests
+type Inner struct {
+	ID string
+}
+
+type InlineLoop struct {
+	Inner `bson:",inline"`
+	Value string
+	Draft *InlineLoop `bson:",omitempty"`
+}
+
+func TestInlineWithPointerToSelf(t *testing.T) {
+	x1 := InlineLoop{
+		Inner: Inner{
+			ID: "1",
+		},
+		Value: "",
+	}
+
+	bytes, err := bson.MarshalWithRegistry(Registry, x1)
+	assert.Nil(t, err, "expected nil error, got: %v", err)
+
+	var x2 InlineLoop
+	err = bson.UnmarshalWithRegistry(Registry, bytes, &x2)
+	assert.Nil(t, err, "expected nil error, got: %v", err)
+	assert.Equal(t, x1, x2, "Expected %v, got %v", x1, x2)
+}

bson/mgocompat/registry.go

@@ -50,7 +50,6 @@ func NewRegistryBuilder() *bsoncodec.RegistryBuilder {
 	structcodec, _ := bsoncodec.NewStructCodec(bsoncodec.DefaultStructTagParser,
 		bsonoptions.StructCodec().
 			SetDecodeZeroStruct(true).
-			SetDecodeDeepZeroInline(true).
 			SetEncodeOmitDefaultStruct(true).
 			SetAllowUnexportedFields(true))
 	emptyInterCodec := bsoncodec.NewEmptyInterfaceCodec(
@@ -94,7 +93,6 @@ func NewRespectNilValuesRegistryBuilder() *bsoncodec.RegistryBuilder {
 	structcodec, _ := bsoncodec.NewStructCodec(bsoncodec.DefaultStructTagParser,
 		bsonoptions.StructCodec().
 			SetDecodeZeroStruct(true).
-			SetDecodeDeepZeroInline(false).
 			SetEncodeOmitDefaultStruct(true).
 			SetAllowUnexportedFields(true))
 	mapCodec := bsoncodec.NewMapCodec(