GODRIVER-2654 Remove direct slice assignment (#1129)

prestonvasquez · web-flow · commit 4fe91b3cb413 · 2022-11-14T12:09:09.000-07:00
diff --git a/x/mongo/driver/topology/topology.go b/x/mongo/driver/topology/topology.go
@@ -564,14 +564,10 @@ func (t *Topology) selectServerFromDescription(desc description.Topology,
 			allowedIndexes = append(allowedIndexes, i)
 		}
 	}
-	var allowed []description.Server
-	if len(allowedIndexes) == len(desc.Servers) {
-		allowed = desc.Servers
-	} else {
-		allowed = make([]description.Server, len(allowedIndexes))
-		for i, idx := range allowedIndexes {
-			allowed[i] = desc.Servers[idx]
-		}
+
+	allowed := make([]description.Server, len(allowedIndexes))
+	for i, idx := range allowedIndexes {
+		allowed[i] = desc.Servers[idx]
 	}
 
 	suitable, err := selectionState.selector.SelectServer(desc, allowed)

Original file line number	Diff line number	Diff line change
`@@ -564,14 +564,10 @@ func (t *Topology) selectServerFromDescription(desc description.Topology,`
`564`	`564`	`allowedIndexes = append(allowedIndexes, i)`
`565`	`565`	`}`
`566`	`566`	`}`
`567`		`- var allowed []description.Server`
`568`		`- if len(allowedIndexes) == len(desc.Servers) {`
`569`		`- allowed = desc.Servers`
`570`		`- } else {`
`571`		`- allowed = make([]description.Server, len(allowedIndexes))`
`572`		`- for i, idx := range allowedIndexes {`
`573`		`- allowed[i] = desc.Servers[idx]`
`574`		`- }`
	`567`	`+`
	`568`	`+ allowed := make([]description.Server, len(allowedIndexes))`
	`569`	`+ for i, idx := range allowedIndexes {`
	`570`	`+ allowed[i] = desc.Servers[idx]`
`575`	`571`	`}`
`576`	`572`
`577`	`573`	`suitable, err := selectionState.selector.SelectServer(desc, allowed)`