Close cursor in Database.ListCollectionNames.

athum · athum · commit 51b003868e57 · 2019-10-02T15:11:35.000-04:00
GODRIVER-1292 Change-Id: I02c8765de132c1e8a8267c473a24fb9784d3e8fd
diff --git a/mongo/database.go b/mongo/database.go
@@ -317,6 +317,8 @@ func (db *Database) ListCollectionNames(ctx context.Context, filter interface{},
 		return nil, err
 	}
 
+	defer res.Close(ctx)
+
 	names := make([]string, 0)
 	for res.Next(ctx) {
 		next := &bsonx.Doc{}
@@ -338,6 +340,7 @@ func (db *Database) ListCollectionNames(ctx context.Context, filter interface{},
 		names = append(names, elemName)
 	}
 
+	res.Close(ctx)
 	return names, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -317,6 +317,8 @@ func (db *Database) ListCollectionNames(ctx context.Context, filter interface{},`
`317`	`317`	`return nil, err`
`318`	`318`	`}`
`319`	`319`
	`320`	`+ defer res.Close(ctx)`
	`321`	`+`
`320`	`322`	`names := make([]string, 0)`
`321`	`323`	`for res.Next(ctx) {`
`322`	`324`	`next := &bsonx.Doc{}`
`@@ -338,6 +340,7 @@ func (db *Database) ListCollectionNames(ctx context.Context, filter interface{},`
`338`	`340`	`names = append(names, elemName)`
`339`	`341`	`}`
`340`	`342`
	`343`	`+ res.Close(ctx)`
`341`	`344`	`return names, nil`
`342`	`345`	`}`
`343`	`346`