Skip to content

Commit 540e8af

Browse files
Update skip rules to reflect non-support for cursor t/o iteration mode
1 parent ba93be3 commit 540e8af

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

internal/spectest/skip.go

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,6 @@ var skipTests = map[string][]string{
567567
"TestUnifiedSpec/client-side-operations-timeout/tests/sessions-override-operation-timeoutMS.json/timeoutMS_applied_to_withTransaction",
568568
"TestUnifiedSpec/client-side-operations-timeout/tests/sessions-override-timeoutMS.json",
569569
"TestUnifiedSpec/client-side-operations-timeout/tests/tailable-awaitData.json/error_if_timeoutMode_is_cursor_lifetime",
570-
"TestUnifiedSpec/client-side-operations-timeout/tests/tailable-awaitData.json/error_if_maxAwaitTimeMS_is_greater_than_timeoutMS",
571570
"TestUnifiedSpec/client-side-operations-timeout/tests/tailable-awaitData.json/timeoutMS_applied_to_find",
572571
"TestUnifiedSpec/client-side-operations-timeout/tests/tailable-awaitData.json/timeoutMS_is_refreshed_for_getMore_if_maxAwaitTimeMS_is_not_set",
573572
"TestUnifiedSpec/client-side-operations-timeout/tests/tailable-awaitData.json/timeoutMS_is_refreshed_for_getMore_if_maxAwaitTimeMS_is_set",
@@ -802,19 +801,25 @@ var skipTests = map[string][]string{
802801
"TestUnifiedSpec/transactions-convenient-api/tests/unified/commit.json/withTransaction_commits_after_callback_returns",
803802
},
804803

805-
// GODRIVER-3473: the implementation of DRIVERS-2868 makes it clear that the
806-
// Go Driver does not correctly implement the following validation for
807-
// tailable awaitData cursors:
804+
"Address CSOT Compliance Issue in Timeout Handling for Cursor Constructors (GODRIVER-3480)": {
805+
"TestUnifiedSpec/client-side-operations-timeout/tests/tailable-awaitData.json/apply_remaining_timeoutMS_if_less_than_maxAwaitTimeMS",
806+
},
807+
808+
// The Go Driver does not support "iteration" mode for cursors. That is,
809+
// we do not apply the timeout used to construct the cursor when using the
810+
// cursor, rather we apply the context-level timeout if one is provided. It's
811+
// doubtful that we will ever support this mode, so we skip these tests.
808812
//
809-
// Drivers MUST error if this option is set, timeoutMS is set to a
810-
// non-zero value, and maxAwaitTimeMS is greater than or equal to
811-
// timeoutMS.
813+
// If we do ever support this mode, it will be done as part of DRIVERS-2722
814+
// which does not currently have driver-specific tickets.
812815
//
813-
// Once GODRIVER-3473 is completed, we can continue running these tests.
814-
"When constructing tailable awaitData cusors must validate, timeoutMS is set to a non-zero value, and maxAwaitTimeMS is greater than or equal to timeoutMS (GODRIVER-3473)": {
816+
// Note that we have integration tests that cover the cases described in these
817+
// tests upto what is supported in the Go Driver. See GODRIVER-3473
818+
"Change CSOT default cursor timeout mode to ITERATION (DRIVERS-2772)": {
815819
"TestUnifiedSpec/client-side-operations-timeout/tests/tailable-awaitData.json/apply_remaining_timeoutMS_if_less_than_maxAwaitTimeMS",
816820
"TestUnifiedSpec/client-side-operations-timeout/tests/tailable-awaitData.json/error_if_maxAwaitTimeMS_is_equal_to_timeoutMS",
817821
"TestUnifiedSpec/client-side-operations-timeout/tests/change-streams.json/error_if_maxAwaitTimeMS_is_equal_to_timeoutMS",
822+
"TestUnifiedSpec/client-side-operations-timeout/tests/tailable-awaitData.json/error_if_maxAwaitTimeMS_is_greater_than_timeoutMS",
818823
},
819824
}
820825

0 commit comments

Comments
 (0)