Skip to content

Commit 6f54cb8

Browse files
prestonvasquezprestonvasquez
committed
1 parent dd173ec commit 6f54cb8

File tree

2 files changed

+57
-4
lines changed

2 files changed

+57
-4
lines changed

‎internal/integration/unified/unified_spec_test.go‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,9 @@ import (
1616

1717
var (
1818
passDirectories = []string{
19-
spectest.TestPath(3, "unified-test-format", "valid-pass"),
20-
spectest.TestPath(3, "versioned-api"),
19+
//spectest.TestPath(3, "unified-test-format", "valid-pass"),
20+
//spectest.TestPath(3, "versioned-api"),
21+
spectest.TestPath(3, "crud", "unified"),
2122
//"versioned-api",
2223
//"crud/unified",
2324
//"change-streams",

‎internal/spectest/skip.go‎

Lines changed: 54 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,11 +152,63 @@ var skipTests = map[string]string{
152152
"TestUnifiedSpec/specifications/source/unified-test-format/tests/valid-pass/operator-type-number_alias.json/type_number_alias_matches_double": "Implement GODRIVER-3409",
153153
"TestUnifiedSpec/specifications/source/unified-test-format/tests/valid-pass/operator-type-number_alias.json/type_number_alias_matches_decimal128": "Implement GODRIVER-3409",
154154

155+
// TODO(GODRIVER-3143): Convert CRUD v1 spec tests to unified test format
156+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bulkWrite-collation.json/BulkWrite_with_delete_operations_and_collation": "Implement GODRIVER-3143",
157+
"TestUnifiedSpec/specifications/source/crud/tests/unified/count.json/Count_documents_with_skip_and_limit": "Implement GODRIVER-3143",
158+
"TestUnifiedSpec/specifications/source/crud/tests/unified/findOne.json/FindOne_with_filter,_sort,_and_skip": "Implement GODRIVER-3143",
159+
160+
// TODO(GODRIVER-2125): Allow hint for unacknowledged writes using OP_MSG when
161+
// supported by the server
162+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bulkWrite-deleteMany-hint-unacknowledged.json/Unacknowledged_deleteMany_with_hint_string_on_4.4+_server": "Implement GODRIVER-2125",
163+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bulkWrite-deleteMany-hint-unacknowledged.json/Unacknowledged_deleteMany_with_hint_document_on_4.4+_server": "Implement GODRIVER-2125",
164+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bulkWrite-deleteOne-hint-unacknowledged.json/Unacknowledged_deleteOne_with_hint_string_on_4.4+_server": "Implement GODRIVER-2125",
165+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bulkWrite-deleteOne-hint-unacknowledged.json/Unacknowledged_deleteOne_with_hint_document_on_4.4+_server": "Implement GODRIVER-2125",
166+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bulkWrite-replaceOne-hint-unacknowledged.json/Unacknowledged_replaceOne_with_hint_string_on_4.2+_server": "Implement GODRIVER-2125",
167+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bulkWrite-replaceOne-hint-unacknowledged.json/Unacknowledged_replaceOne_with_hint_document_on_4.2+_server": "Implement GODRIVER-2125",
168+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bulkWrite-updateMany-hint-unacknowledged.json/Unacknowledged_updateMany_with_hint_string_on_4.2+_server": "Implement GODRIVER-2125",
169+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bulkWrite-updateMany-hint-unacknowledged.json/Unacknowledged_updateMany_with_hint_document_on_4.2+_server": "Implement GODRIVER-2125",
170+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bulkWrite-updateOne-hint-unacknowledged.json/Unacknowledged_updateOne_with_hint_string_on_4.2+_server": "Implement GODRIVER-2125",
171+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bulkWrite-updateOne-hint-unacknowledged.json/Unacknowledged_updateOne_with_hint_document_on_4.2+_server": "Implement GODRIVER-2125",
172+
173+
// TODO(GODRIVER-3407): Allow drivers to set bypassDocumentValidation: false
174+
// on write commands
175+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bypassDocumentValidation.json/Aggregate_with_$out_passes_bypassDocumentValidation:_false": "Implement GODRIVER-3407",
176+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bypassDocumentValidation.json/BulkWrite_passes_bypassDocumentValidation:_false": "Implement GODRIVER-3407",
177+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bypassDocumentValidation.json/FindOneAndReplace_passes_bypassDocumentValidation:_false": "Implement GODRIVER-3407",
178+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bypassDocumentValidation.json/FindOneAndUpdate_passes_bypassDocumentValidation:_fals": "Implement GODRIVER-3407",
179+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bypassDocumentValidation.json/FindOneAndUpdate_passes_bypassDocumentValidation:_false": "Implement GODRIVER-3407",
180+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bypassDocumentValidation.json/InsertMany_passes_bypassDocumentValidation:_false": "Implement GODRIVER-3407",
181+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bypassDocumentValidation.json/InsertOne_passes_bypassDocumentValidation:_false": "Implement GODRIVER-3407",
182+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bypassDocumentValidation.json/ReplaceOne_passes_bypassDocumentValidation:_false": "Implement GODRIVER-3407",
183+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bypassDocumentValidation.json/UpdateMany_passes_bypassDocumentValidation:_false": "Implement GODRIVER-3407",
184+
"TestUnifiedSpec/specifications/source/crud/tests/unified/bypassDocumentValidation.json/UpdateOne_passes_bypassDocumentValidation:_false": "Implement GODRIVER-3407",
185+
"TestUnifiedSpec/specifications/source/crud/tests/unified/deleteMany-hint-unacknowledged.json/Unacknowledged_deleteMany_with_hint_string_on_4.4+_server": "Implement GODRIVER-3407",
186+
"TestUnifiedSpec/specifications/source/crud/tests/unified/deleteMany-hint-unacknowledged.json/Unacknowledged_deleteMany_with_hint_document_on_4.4+_server": "Implement GODRIVER-3407",
187+
"TestUnifiedSpec/specifications/source/crud/tests/unified/deleteOne-hint-unacknowledged.json/Unacknowledged_deleteOne_with_hint_string_on_4.4+_server": "Implement GODRIVER-3407",
188+
"TestUnifiedSpec/specifications/source/crud/tests/unified/deleteOne-hint-unacknowledged.json/Unacknowledged_deleteOne_with_hint_document_on_4.4+_server": "Implement GODRIVER-3407",
189+
"TestUnifiedSpec/specifications/source/crud/tests/unified/findOneAndDelete-hint-unacknowledged.json/Unacknowledged_findOneAndDelete_with_hint_string_on_4.4+_server": "Implement GODRIVER-3407",
190+
"TestUnifiedSpec/specifications/source/crud/tests/unified/findOneAndDelete-hint-unacknowledged.json/Unacknowledged_findOneAndDelete_with_hint_document_on_4.4+_server": "Implement GODRIVER-3407",
191+
"TestUnifiedSpec/specifications/source/crud/tests/unified/findOneAndReplace-hint-unacknowledged.json/Unacknowledged_findOneAndReplace_with_hint_string_on_4.4+_server": "Implement GODRIVER-3407",
192+
"TestUnifiedSpec/specifications/source/crud/tests/unified/findOneAndReplace-hint-unacknowledged.json/Unacknowledged_findOneAndReplace_with_hint_document_on_4.4+_server": "Implement GODRIVER-3407",
193+
"TestUnifiedSpec/specifications/source/crud/tests/unified/findOneAndUpdate-hint-unacknowledged.json/Unacknowledged_findOneAndUpdate_with_hint_string_on_4.4+_server": "Implement GODRIVER-3407",
194+
"TestUnifiedSpec/specifications/source/crud/tests/unified/findOneAndUpdate-hint-unacknowledged.json/Unacknowledged_findOneAndUpdate_with_hint_document_on_4.4+_server": "Implement GODRIVER-3407",
195+
"TestUnifiedSpec/specifications/source/crud/tests/unified/replaceOne-hint-unacknowledged.json/Unacknowledged_replaceOne_with_hint_string_on_4.2+_server": "Implement GODRIVER-3407",
196+
"TestUnifiedSpec/specifications/source/crud/tests/unified/replaceOne-hint-unacknowledged.json/Unacknowledged_replaceOne_with_hint_document_on_4.2+_server": "Implement GODRIVER-3407",
197+
"TestUnifiedSpec/specifications/source/crud/tests/unified/updateMany-hint-unacknowledged.json/Unacknowledged_updateMany_with_hint_string_on_4.2+_server": "Implement GODRIVER-3407",
198+
"TestUnifiedSpec/specifications/source/crud/tests/unified/updateMany-hint-unacknowledged.json/Unacknowledged_updateMany_with_hint_document_on_4.2+_server": "Implement GODRIVER-3407",
199+
"TestUnifiedSpec/specifications/source/crud/tests/unified/updateOne-hint-unacknowledged.json/Unacknowledged_updateOne_with_hint_string_on_4.2+_server": "Implement GODRIVER-3407",
200+
"TestUnifiedSpec/specifications/source/crud/tests/unified/updateOne-hint-unacknowledged.json/Unacknowledged_updateOne_with_hint_document_on_4.2+_server": "Implement GODRIVER-3407",
201+
202+
// TODO(GODRIVER-3392): Test that inserts and upserts respect null _id values
203+
"TestUnifiedSpec/specifications/source/crud/tests/unified/create-null-ids.json/inserting__id_with_type_null_via_insertOne": "Implement GODRIVER-3392",
204+
205+
// TODO(GODRIVER-3395): Ensure findOne does not set batchSize=1
206+
"TestUnifiedSpec/specifications/source/crud/tests/unified/find.json/Find_with_batchSize_equal_to_limit": "Implement GODRIVER-3395",
207+
155208
// GODRIVER-1773: This test runs a "find" with limit=4 and batchSize=3. It
156209
// expects batchSize values of three for the "find" and one for the
157210
// "getMore", but we send three for both.
158211
"TestUnifiedSpec/command-monitoring/find.json/A_successful_find_event_with_a_getmore_and_the_server_kills_the_cursor_(<=_4.4)": "See GODRIVER-1773",
159-
//"TestUnifiedSpec/unified-test-format/valid-pass/poc-command-monitoring.json/A_successful_find_event_with_a_getmore_and_the_server_kills_the_cursor_(<=_4.4)": "See GODRIVER-1773",
160212

161213
// GODRIVER-2577: The following spec tests require canceling ops
162214
// immediately, but the current logic clears pools and cancels in-progress
@@ -180,7 +232,7 @@ var skipTests = map[string]string{
180232
"TestUnifiedSpec/server-discovery-and-monitoring/unified/auth-network-timeout-error.json/Reset_server_and_pool_after_network_timeout_error_during_authentication": "Uses unsupported socketTimeoutMS",
181233
"TestUnifiedSpec/server-discovery-and-monitoring/unified/find-network-timeout-error.json/Ignore_network_timeout_error_on_find": "Uses unsupported socketTimeoutMS",
182234
"TestUnifiedSpec/command-monitoring/find.json/A_successful_find_with_options": "Uses unsupported maxTimeMS",
183-
"TestUnifiedSpec/crud/unified/estimatedDocumentCount.json/estimatedDocumentCount_with_maxTimeMS": "Uses unsupported maxTimeMS",
235+
"TestUnifiedSpec/specifications/source/crud/tests/unified/estimatedDocumentCount.json/estimatedDocumentCount_with_maxTimeMS": "Uses unsupported maxTimeMS",
184236
"TestUnifiedSpec/run-command/runCursorCommand.json/supports_configuring_getMore_maxTimeMS": "Uses unsupported maxTimeMS",
185237

186238
// TODO(GODRIVER-3137): Implement Gossip cluster time"

0 commit comments

Comments
 (0)