GODRIVER-1215 parse lastWriteDate from isMaster correctly

Change-Id: If1f5b0b7fb7561dda8cfaf0dd4fd88ae18f2d60b

Author: iwysiu

internal/results.go

@@ -735,3 +735,31 @@ func TestEndSessions(t *testing.T) {
 
 	require.Equal(t, "endSessions", started.CommandName)
 }
+
+func TestIsMaster(t *testing.T) {
+	if os.Getenv("TOPOLOGY") != "replica_set" {
+		t.Skip("Needs to run on a replica set")
+	}
+	cs := testutil.ConnString(t)
+	client, err := NewClient(options.Client().ApplyURI(cs.String()))
+	require.NoError(t, err)
+	err = client.Connect(nil)
+	require.NoError(t, err)
+
+	coll := createTestCollection(t, nil, nil)
+	skipIfBelow34(t, coll.db)
+	_, err = coll.InsertOne(
+		context.Background(),
+		bsonx.Doc{{"x", bsonx.Int32(1)}},
+	)
+	require.NoError(t, err)
+
+	isMaster := operation.NewIsMaster().ClusterClock(client.clock).Deployment(client.topology).
+		AppName(cs.AppName).Compressors(cs.Compressors)
+
+	err = isMaster.Execute(ctx)
+	require.NoError(t, err)
+
+	res := isMaster.Result("")
+	require.False(t, res.LastWriteTime.IsZero())
+}

mongo/client_internal_test.go

@@ -121,13 +121,21 @@ func NewServer(addr address.Address, response bsoncore.Document) Server {
 				desc.LastError = fmt.Errorf("expected 'isreplicaset' to be a boolean but it's a BSON %s", element.Value().Type)
 				return desc
 			}
-		case "lastWriteDate":
-			dt, ok := element.Value().DateTimeOK()
+		case "lastWrite":
+			lastWrite, ok := element.Value().DocumentOK()
 			if !ok {
-				desc.LastError = fmt.Errorf("expected 'lastWriteDate' to be a datetime but it's a BSON %s", element.Value().Type)
+				desc.LastError = fmt.Errorf("expected 'lastWrite' to be a document but it's a BSON %s", element.Value().Type)
 				return desc
 			}
-			desc.LastWriteTime = time.Unix(dt/1000, dt%1000*1000000).UTC()
+			dateTime, err := lastWrite.LookupErr("lastWriteDate")
+			if err == nil {
+				dt, ok := dateTime.DateTimeOK()
+				if !ok {
+					desc.LastError = fmt.Errorf("expected 'lastWriteDate' to be a datetime but it's a BSON %s", dateTime.Type)
+					return desc
+				}
+				desc.LastWriteTime = time.Unix(dt/1000, dt%1000*1000000).UTC()
+			}
 		case "logicalSessionTimeoutMinutes":
 			i64, ok := element.Value().AsInt64OK()
 			if !ok {

x/mongo/driver/description/server.go

@@ -66,7 +66,7 @@ func (im *IsMaster) Deployment(d driver.Deployment) *IsMaster {
 	return im
 }
 
-// Result returns the result of executing this operaiton.
+// Result returns the result of executing this operation.
 func (im *IsMaster) Result(addr address.Address) description.Server {
 	desc := description.Server{Addr: addr, CanonicalAddr: addr, LastUpdateTime: time.Now().UTC()}
 	elements, err := im.res.Elements()
@@ -132,13 +132,21 @@ func (im *IsMaster) Result(addr address.Address) description.Server {
 				desc.LastError = fmt.Errorf("expected 'isreplicaset' to be a boolean but it's a BSON %s", element.Value().Type)
 				return desc
 			}
-		case "lastWriteDate":
-			dt, ok := element.Value().DateTimeOK()
+		case "lastWrite":
+			lastWrite, ok := element.Value().DocumentOK()
 			if !ok {
-				desc.LastError = fmt.Errorf("expected 'lastWriteDate' to be a datetime but it's a BSON %s", element.Value().Type)
+				desc.LastError = fmt.Errorf("expected 'lastWrite' to be a document but it's a BSON %s", element.Value().Type)
 				return desc
 			}
-			desc.LastWriteTime = time.Unix(dt/1000, dt%1000*1000000).UTC()
+			dateTime, err := lastWrite.LookupErr("lastWriteDate")
+			if err == nil {
+				dt, ok := dateTime.DateTimeOK()
+				if !ok {
+					desc.LastError = fmt.Errorf("expected 'lastWriteDate' to be a datetime but it's a BSON %s", dateTime.Type)
+					return desc
+				}
+				desc.LastWriteTime = time.Unix(dt/1000, dt%1000*1000000).UTC()
+			}
 		case "logicalSessionTimeoutMinutes":
 			i64, ok := element.Value().AsInt64OK()
 			if !ok {

x/mongo/driver/operation/ismaster.go

@@ -39,7 +39,7 @@ type IsMaster struct {
 	Hosts                        []string           `bson:"hosts,omitempty"`
 	IsMaster                     bool               `bson:"ismaster,omitempty"`
 	IsReplicaSet                 bool               `bson:"isreplicaset,omitempty"`
-	LastWriteTimestamp           time.Time          `bson:"lastWriteDate,omitempty"`
+	LastWrite                    *lastWriteDate     `bson:"lastWrite,omitempty"`
 	LogicalSessionTimeoutMinutes uint32             `bson:"logicalSessionTimeoutMinutes,omitempty"`
 	MaxBSONObjectSize            uint32             `bson:"maxBsonObjectSize,omitempty"`
 	MaxMessageSizeBytes          uint32             `bson:"maxMessageSizeBytes,omitempty"`
@@ -58,6 +58,10 @@ type IsMaster struct {
 	Tags                         map[string]string  `bson:"tags,omitempty"`
 }
 
+type lastWriteDate struct {
+	LastWriteDate time.Time `bson:"lastWriteDate"`
+}
+
 type server struct {
 	Type    string
 	SetName string