GODRIVER-1405 Remove topology.WithConnectionAppName (#377)

Author: Divjot Arora

mongo/client.go

@@ -337,9 +337,6 @@ func (c *Client) configure(opts *options.ClientOptions) error {
 		serverOpts = append(serverOpts, topology.WithServerAppName(func(string) string {
 			return appName
 		}))
-		connOpts = append(connOpts, topology.WithConnectionAppName(func(string) string {
-			return appName
-		}))
 	}
 	// Compressors & ZlibLevel
 	var comps []string

mongo/integration/client_test.go

@@ -351,7 +351,8 @@ func TestClient(t *testing.T) {
 		SetAppName(testAppName)
 	appNameMtOpts := mtest.NewOptions().
 		ClientOptions(appNameDialerOpts).
-		Topologies(mtest.Single)
+		Topologies(mtest.Single).
+		Auth(false) // Can't run with auth because the proxy dialer won't work with TLS enabled.
 	mt.RunOpts("app name is always sent", appNameMtOpts, func(mt *mtest.T) {
 		err := mt.Client.Ping(mtest.Background, mtest.PrimaryRp)
 		assert.Nil(mt, err, "Ping error: %v", err)

x/mongo/driver/drivertest/channel_conn.go

@@ -75,3 +75,35 @@ func MakeReply(doc bsoncore.Document) []byte {
 	dst = append(dst, doc...)
 	return bsoncore.UpdateLength(dst, idx, int32(len(dst[idx:])))
 }
+
+// GetCommandFromQueryWireMessage returns the command sent in an OP_QUERY wire message.
+func GetCommandFromQueryWireMessage(wm []byte) (bsoncore.Document, error) {
+	var ok bool
+	_, _, _, _, wm, ok = wiremessage.ReadHeader(wm)
+	if !ok {
+		return nil, errors.New("could not read header")
+	}
+	_, wm, ok = wiremessage.ReadQueryFlags(wm)
+	if !ok {
+		return nil, errors.New("could not read flags")
+	}
+	_, wm, ok = wiremessage.ReadQueryFullCollectionName(wm)
+	if !ok {
+		return nil, errors.New("could not read fullCollectionName")
+	}
+	_, wm, ok = wiremessage.ReadQueryNumberToSkip(wm)
+	if !ok {
+		return nil, errors.New("could not read numberToSkip")
+	}
+	_, wm, ok = wiremessage.ReadQueryNumberToReturn(wm)
+	if !ok {
+		return nil, errors.New("could not read numberToReturn")
+	}
+
+	var query bsoncore.Document
+	query, wm, ok = wiremessage.ReadQueryQuery(wm)
+	if !ok {
+		return nil, errors.New("could not read query")
+	}
+	return query, nil
+}

x/mongo/driver/examples/server_monitoring/main.go

@@ -20,11 +20,6 @@ func main() {
 		address.Address("localhost:27017"),
 		nil,
 		topology.WithHeartbeatInterval(func(time.Duration) time.Duration { return 2 * time.Second }),
-		topology.WithConnectionOptions(
-			func(opts ...topology.ConnectionOption) []topology.ConnectionOption {
-				return append(opts, topology.WithConnectionAppName(func(string) string { return "server monitoring test" }))
-			},
-		),
 	)
 	if err != nil {
 		log.Fatalf("could not start server: %v", err)

x/mongo/driver/topology/connection_options.go

@@ -83,15 +83,6 @@ func withServerDescriptionCallback(callback func(description.Server), opts ...Co
 // ConnectionOption is used to configure a connection.
 type ConnectionOption func(*connectionConfig) error
 
-// WithConnectionAppName sets the application name which gets sent to MongoDB when it
-// first connects.
-func WithConnectionAppName(fn func(string) string) ConnectionOption {
-	return func(c *connectionConfig) error {
-		c.appName = fn(c.appName)
-		return nil
-	}
-}
-
 // WithCompressors sets the compressors that can be used for communication.
 func WithCompressors(fn func([]string) []string) ConnectionOption {
 	return func(c *connectionConfig) error {

x/mongo/driver/topology/topology_options.go

@@ -65,7 +65,6 @@ func WithConnString(fn func(connstring.ConnString) connstring.ConnString) Option
 		var connOpts []ConnectionOption
 
 		if cs.AppName != "" {
-			connOpts = append(connOpts, WithConnectionAppName(func(string) string { return cs.AppName }))
 			c.serverOpts = append(c.serverOpts, WithServerAppName(func(string) string { return cs.AppName }))
 		}