GODRIVER-3493 unify compile-check scripts

Author: prestonvasquez

Taskfile.yml

@@ -28,7 +28,7 @@ tasks:
 
   build-tests: go test -short ${BUILD_TAGS} -run ^$$ ./...
 
-  build-compile-check: bash etc/compile_check_other.sh
+  build-compile-check: bash etc/compile_check.sh
 
   build-compile-check-all: bash etc/run-compile-check-test.sh
 

etc/compile_check.sh

@@ -2,19 +2,17 @@
 set -e # exit when any command fails
 set -x # show all commands being run
 
-# Default to Go 1.18 if GO_VERSION is not set.
-#
-# Use the "=" operator (instead of the more common ":-" operator) so that it
-# allows setting GO_VERSION="" to use the Go installation in the PATH, and it
-# sets the GO_VERSION variable if the default is used.
-GC=go${GO_VERSION="1.18"}
+: ${GC:=go${GO_VERSION="1.18"}}
+
 COMPILE_CHECK_DIR="internal/cmd/compilecheck"
+ARCHITECTURES=("386" "arm" "arm64" "ppc64le" "s390x")
+BUILD_CMD="${GC} build -buildvcs=false"
 
 # compile_check will attempt to build the internal/test/compilecheck project
 # using the provided Go version. This is to simulate an end-to-end use case.
 function compile_check {
   # Change the directory to the compilecheck test directory.
-  pushd ${COMPILE_CHECK_DIR}
+  pushd "${COMPILE_CHECK_DIR}" >/dev/null
 
   # If a custom Go version is set using the GO_VERSION env var (e.g. "1.18"),
   # add the GOPATH bin directory to PATH and then install that Go version.
@@ -29,29 +27,22 @@ function compile_check {
   ${GC} version
   ${GC} mod tidy
 
-  # Check simple build.
-  ${GC} build ./...
+  # Standard build
+  $BUILD_CMD ./...
 
-  # Check build with dynamic linking.
-  ${GC} build -buildmode=plugin
+  # Dynamic linking
+  $BUILD_CMD -buildmode=plugin
 
   # Check build with tags.
-  ${GC} build $BUILD_TAGS ./...
+  [[ -n "$BUILD_TAGS" ]] && $BUILD_CMD $BUILD_TAGS ./...
 
   # Check build with various architectures.
-  GOOS=linux GOARCH=386 ${GC} build ./...
-  GOOS=linux GOARCH=arm ${GC} build ./...
-  GOOS=linux GOARCH=arm64 ${GC} build ./...
-  GOOS=linux GOARCH=amd64 ${GC} build ./...
-  GOOS=linux GOARCH=ppc64le ${GC} build ./...
-  GOOS=linux GOARCH=s390x ${GC} build ./...
-
-  # Remove the binaries.
-  rm compilecheck
-  rm compilecheck.so
+  for ARCH in "${ARCHITECTURES[@]}"; do
+    GOOS=linux GOARCH=$ARCH $BUILD_CMD ./...
+  done
 
   # Change the directory back to the working directory.
-  popd
+  popd >/dev/null
 }
 
 compile_check

etc/compile_check_other.sh

@@ -4,13 +4,7 @@
 set -eu
 set +x
 
-SUBTEST="${1:-}" # Use the default value if $1 is not set
-
 echo "Running internal/test/compilecheck"
 pushd internal/test/compilecheck
-if [ -n "$SUBTEST" ]; then
-  GOWORK=off go test -run "$SUBTEST" -timeout 30m -v ./... >>../../../test.suite
-else
-  GOWORK=off go test -timeout 30m -v ./... >>../../../test.suite
-fi
+GOWORK=off go test -timeout 30m -v ./... >>../../../test.suite
 popd

etc/run-compile-check-test.sh

@@ -70,7 +70,7 @@ func TestCompileCheck(t *testing.T) {
 				require.NoError(t, err)
 			}()
 
-			exitCode, outputReader, err := container.Exec(context.Background(), []string{"bash", "etc/compile_check_other.sh"})
+			exitCode, outputReader, err := container.Exec(context.Background(), []string{"bash", "etc/compile_check.sh"})
 			require.NoError(t, err)
 
 			output, err := io.ReadAll(outputReader)