Fix data race in 'discard connections' pool test. (#1860)

Author: matthewdale

Taskfile.yml

@@ -87,7 +87,7 @@ tasks:
   test-race:
     - go test ${BUILD_TAGS} -timeout {{.TEST_TIMEOUT}}s -race -p 1 ./...
 
-  test-short: go test ${BUILD_TAGS} -timeout 60s -short ./...
+  test-short: go test ${BUILD_TAGS} -timeout 60s -short -race ./...
 
   test-oidc: bash etc/run-oidc-test.sh 'task --silent evg-test-oidc-auth'
 

x/mongo/driver/topology/pool_test.go

@@ -890,7 +890,7 @@ func TestPool(t *testing.T) {
 			go func() {
 				select {
 				case nc := <-ncs:
-					_, err = nc.Write([]byte{5, 0, 0, 0, 0})
+					_, err := nc.Write([]byte{5, 0, 0, 0, 0})
 					require.NoError(t, err, "Write error")
 				case <-time.After(100 * time.Millisecond):
 				}