GODRIVER-3493 Use semver to compare docker versions to msv

Author: prestonvasquez

etc/compile_check.sh

@@ -41,5 +41,3 @@ function compile_check {
 }
 
 compile_check
-
-exit 0

internal/test/compilecheck/compile_check_test.go

@@ -14,13 +14,13 @@ import (
 	"net/http"
 	"os"
 	"path/filepath"
-	"strconv"
 	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	"github.com/testcontainers/testcontainers-go"
+	"golang.org/x/mod/semver"
 )
 
 const minSupportedVersion = "1.18"
@@ -78,42 +78,6 @@ func TestCompileCheck(t *testing.T) {
 	}
 }
 
-func compareVersions(v1, v2 string) int {
-	parts1 := strings.Split(v1, ".")
-	parts2 := strings.Split(v2, ".")
-
-	n := len(parts1)
-	if len(parts2) > n {
-		n = len(parts2)
-	}
-
-	for i := 0; i < n; i++ {
-		var num1, num2 int
-		if i < len(parts2) {
-			num1, _ = strconv.Atoi(parts1[i])
-		}
-
-		if i < len(parts2) {
-			num2, _ = strconv.Atoi(parts2[i])
-		}
-
-		if num1 < num2 {
-			return -1
-		} else if num1 > num2 {
-			return 1
-		}
-	}
-
-	return 0
-}
-
-type tagResponse struct {
-	Results []struct {
-		Name string `json:"name"`
-	} `json:"results"`
-	Next string `json:"next"`
-}
-
 func getDockerGolangImages() ([]string, error) {
 	url := "https://hub.docker.com/v2/repositories/library/golang/tags?page_size=100"
 
@@ -126,7 +90,13 @@ func getDockerGolangImages() ([]string, error) {
 
 		defer resp.Body.Close()
 
-		var data tagResponse
+		var data struct {
+			Results []struct {
+				Name string `json:"name"`
+			} `json:"results"`
+			Next string `json:"next"`
+		}
+
 		if err := json.NewDecoder(resp.Body).Decode(&data); err != nil {
 			return nil, err
 		}
@@ -156,7 +126,8 @@ func getDockerGolangImages() ([]string, error) {
 				continue
 			}
 
-			if compareVersions(base, minSupportedVersion) >= 0 {
+			//if compareVersions(base, minSupportedVersion) >= 0 {
+			if semver.Compare("v"+base, "v"+minSupportedVersion) >= 0 {
 				versionSet[base] = true
 
 				continue

internal/test/compilecheck/go.mod

@@ -7,6 +7,7 @@ replace go.mongodb.org/mongo-driver => ../../../
 require (
 	github.com/stretchr/testify v1.10.0
 	github.com/testcontainers/testcontainers-go v0.34.0
+	golang.org/x/mod v0.12.0
 )
 
 require (

internal/test/compilecheck/go.sum

@@ -137,6 +137,8 @@ golang.org/x/crypto v0.31.0 h1:ihbySMvVjLAeSH1IbfcRTkD/iNscyz8rGzjF/E5hV6U=
 golang.org/x/crypto v0.31.0/go.mod h1:kDsLvtWBEx7MV9tJOj9bnXsPbxwJQ6csT/x4KIN4Ssk=
 golang.org/x/mod v0.2.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
 golang.org/x/mod v0.3.0/go.mod h1:s0Qsj1ACt9ePp/hMypM3fl4fZqREWJwdYDEqhRiZZUA=
+golang.org/x/mod v0.12.0 h1:rmsUpXtvNzj340zd98LZ4KntptpfRHwpFOHG188oHXc=
+golang.org/x/mod v0.12.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
 golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
 golang.org/x/net v0.0.0-20190620200207-3b0461eec859/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s=
 golang.org/x/net v0.0.0-20200226121028-0de0cce0169b/go.mod h1:z5CRVTTTmAJ677TzLLGU+0bjPO0LkuOLi4/5GtJWs/s=