GODRIVER-1428 add writeConcern to CreateIndexes operation (#262)

Author: iwysiu

mongo/index_view.go

@@ -218,12 +218,20 @@ func (iv IndexView) CreateMany(ctx context.Context, models []IndexModel, opts ..
 		return nil, err
 	}
 
+	wc := iv.coll.writeConcern
+	if sess.TransactionRunning() {
+		wc = nil
+	}
+	if !writeconcern.AckWrite(wc) {
+		sess = nil
+	}
+
 	selector := makePinnedSelector(sess, iv.coll.writeSelector)
 
 	option := options.MergeCreateIndexesOptions(opts...)
 
 	op := operation.NewCreateIndexes(indexes).
-		Session(sess).ClusterClock(iv.coll.client.clock).
+		Session(sess).WriteConcern(wc).ClusterClock(iv.coll.client.clock).
 		Database(iv.coll.db.name).Collection(iv.coll.name).CommandMonitor(iv.coll.client.monitor).
 		Deployment(iv.coll.client.deployment).ServerSelector(selector)
 

mongo/integration/index_view_test.go

@@ -15,6 +15,7 @@ import (
 	"go.mongodb.org/mongo-driver/mongo"
 	"go.mongodb.org/mongo-driver/mongo/integration/mtest"
 	"go.mongodb.org/mongo-driver/mongo/options"
+	"go.mongodb.org/mongo-driver/mongo/writeconcern"
 )
 
 type index struct {
@@ -138,26 +139,54 @@ func TestIndexView(t *testing.T) {
 		})
 	})
 	mt.Run("create many", func(mt *mtest.T) {
-		iv := mt.Coll.Indexes()
-		indexNames, err := iv.CreateMany(mtest.Background, []mongo.IndexModel{
-			{
-				Keys: bson.D{{"foo", -1}},
-			},
-			{
-				Keys: bson.D{{"bar", 1}, {"baz", -1}},
-			},
-		})
-		assert.Nil(mt, err, "CreateMany error: %v", err)
-		assert.Equal(mt, 2, len(indexNames), "expected 2 index names, got %v", len(indexNames))
+		mt.Run("success", func(mt *mtest.T) {
+			iv := mt.Coll.Indexes()
+			indexNames, err := iv.CreateMany(mtest.Background, []mongo.IndexModel{
+				{
+					Keys: bson.D{{"foo", -1}},
+				},
+				{
+					Keys: bson.D{{"bar", 1}, {"baz", -1}},
+				},
+			})
+			assert.Nil(mt, err, "CreateMany error: %v", err)
+			assert.Equal(mt, 2, len(indexNames), "expected 2 index names, got %v", len(indexNames))
 
-		verifyIndexExists(mt, iv, index{
-			Key:  map[string]int{"foo": -1},
-			Name: indexNames[0],
-		})
-		verifyIndexExists(mt, iv, index{
-			Key:  map[string]int{"bar": 1, "baz": -1},
-			Name: indexNames[1],
+			verifyIndexExists(mt, iv, index{
+				Key:  map[string]int{"foo": -1},
+				Name: indexNames[0],
+			})
+			verifyIndexExists(mt, iv, index{
+				Key:  map[string]int{"bar": 1, "baz": -1},
+				Name: indexNames[1],
+			})
 		})
+		wc := writeconcern.New(writeconcern.W(1))
+		mt.RunOpts("uses writeconcern",
+			mtest.NewOptions().CollectionOptions(options.Collection().SetWriteConcern(wc)),
+			func(mt *mtest.T) {
+				iv := mt.Coll.Indexes()
+				_, err := iv.CreateMany(mtest.Background, []mongo.IndexModel{
+					{
+						Keys: bson.D{{"foo", -1}},
+					},
+					{
+						Keys: bson.D{{"bar", 1}, {"baz", -1}},
+					},
+				})
+				assert.Nil(mt, err, "CreateMany error: %v", err)
+
+				evt := mt.GetStartedEvent()
+				assert.NotNil(mt, evt, "expected CommandStartedEvent, got nil")
+
+				assert.Equal(mt, "createIndexes", evt.CommandName, "command name mismatch; expected createIndexes, got %s", evt.CommandName)
+
+				actual, err := evt.Command.LookupErr("writeConcern", "w")
+				assert.Nil(mt, err, "error getting writeConcern.w: %s", err)
+
+				wcVal := numberFromValue(mt, actual)
+				assert.Equal(mt, int64(1), wcVal, "expected writeConcern to be 1, got: %v", wcVal)
+			})
 	})
 	mt.Run("drop one", func(mt *mtest.T) {
 		iv := mt.Coll.Indexes()

x/mongo/driver/operation/createIndexes.go

@@ -2,6 +2,9 @@ version = 0
 name = "CreateIndexes"
 documentation = "CreateIndexes performs a createIndexes operation."
 
+[properties]
+enabled = ["write concern"]
+
 [command]
 name = "createIndexes"
 parameter = "collection"