GODRIVER-725: too big integers should be parsed as doubles.

Author: craiggwilson

bson/bsonrw/json_scanner.go

@@ -417,25 +417,23 @@ func (js *jsonScanner) scanNumber(first byte) (*jsonToken, error) {
 			return nil, fmt.Errorf("invalid JSON number. Position: %d", start)
 		case nssDone:
 			js.pos = int(math.Max(0, float64(js.pos-1)))
-			if t == jttDouble {
-				v, err := strconv.ParseFloat(b.String(), 64)
-				if err != nil {
-					return nil, err
+			if t != jttDouble {
+				v, err := strconv.ParseInt(b.String(), 10, 64)
+				if err == nil {
+					if v < math.MinInt32 || v > math.MaxInt32 {
+						return &jsonToken{t: jttInt64, v: v, p: start}, nil
+					}
+
+					return &jsonToken{t: jttInt32, v: int32(v), p: start}, nil
 				}
-
-				return &jsonToken{t: t, v: v, p: start}, nil
 			}
 
-			v, err := strconv.ParseInt(b.String(), 10, 64)
+			v, err := strconv.ParseFloat(b.String(), 64)
 			if err != nil {
 				return nil, err
 			}
 
-			if v < math.MinInt32 || v > math.MaxInt32 {
-				return &jsonToken{t: t, v: v, p: start}, nil
-			}
-
-			return &jsonToken{t: jttInt32, v: int32(v), p: start}, nil
+			return &jsonToken{t: jttDouble, v: v, p: start}, nil
 		}
 	}
 }

bson/bsonrw/json_scanner_test.go

@@ -232,6 +232,10 @@ func TestJsonScannerValidInputs(t *testing.T) {
 			desc: "valid double: -1.2E-10", input: "-1.2E-10",
 			tokens: []jsonToken{{t: jttDouble, v: -1.2e-10}},
 		},
+		{
+			desc: "valid double: 8005332285744496613785600", input: "8005332285744496613785600",
+			tokens: []jsonToken{{t: jttDouble, v: float64(8005332285744496613785600)}},
+		},
 		{
 			desc:  "valid object, only spaces",
 			input: `{"key": "string", "key2": 2, "key3": {}, "key4": [], "key5": false }`,