GODRIVER-3493 Test why codeql is breaking

Author: prestonvasquez

.github/workflows/codeql.yml

@@ -33,12 +33,11 @@ jobs:
         languages: go
         build-mode: manual
 
-        #- name: Install Taskfile support
-        #  uses: arduino/setup-task@v2
+    - name: Install Taskfile support
+      uses: arduino/setup-task@v2
 
-        #- name: Task build
-        #  shell: bash
-        #  run: task build
+    - shell: bash
+      run: task build
 
     - name: Perform CodeQL Analysis
       uses: github/codeql-action/analyze@v3

Taskfile.yml

@@ -23,16 +23,12 @@ tasks:
       - go build ./...
       - go build ${BUILD_TAGS} ./...
       - task: build-tests
-      - task: build-compile-check-msv
+      - task: build-compile-check
       - task: cross-compile
 
   build-tests: go test -short ${BUILD_TAGS} -run ^$$ ./...
 
-  # Compile check for all versions >= the minimum supported version.
-  build-compile-check: bash etc/run-compile-check-test.sh
-
-  # Compile check for the minimum supported version (msv).
-  build-compile-check-msv: bash etc/run-compile-check-test.sh TestCompileCheck/golang:1.18
+  build-compile-check: bash etc/compile_check.sh
 
   build-aws-ecs-test: go build ${BUILD_TAGS} ./internal/cmd/testaws/main.go
 

etc/compile_check.sh

@@ -2,41 +2,98 @@
 set -e # exit when any command fails
 set -x # show all commands being run
 
-GC=go
+# Default to Go 1.18 if GO_VERSION is not set.
+#
+# Use the "=" operator (instead of the more common ":-" operator) so that it
+# allows setting GO_VERSION="" to use the Go installation in the PATH, and it
+# sets the GO_VERSION variable if the default is used.
+GC=go${GO_VERSION="1.18"}
 COMPILE_CHECK_DIR="internal/cmd/compilecheck"
-ARCHITECTURES=("386" "arm" "arm64" "ppc64le" "s390x")
-BUILD_CMD="${GC} build -buildvcs=false"
-
-# Compilation modules are not part of the workspace as testcontainers requires
-# a version of klauspost/compress not supported by the Go Driver / other modules
-# in the workspace.
-export GOWORK=off
 
 # compile_check will attempt to build the internal/test/compilecheck project
 # using the provided Go version. This is to simulate an end-to-end use case.
 function compile_check {
   # Change the directory to the compilecheck test directory.
-  pushd "${COMPILE_CHECK_DIR}" >/dev/null
+  pushd ${COMPILE_CHECK_DIR}
+
+  # If a custom Go version is set using the GO_VERSION env var (e.g. "1.18"),
+  # add the GOPATH bin directory to PATH and then install that Go version.
+  if [ ! -z "$GO_VERSION" ]; then
+    PATH=$(go env GOPATH)/bin:$PATH
+    export PATH
+
+    go install golang.org/dl/go$GO_VERSION@latest
+    ${GC} download
+  fi
 
   ${GC} version
   ${GC} mod tidy
 
-  # Standard build
-  $BUILD_CMD ./...
+  # Check simple build.
+  ${GC} build ./...
 
-  # Dynamic linking
-  $BUILD_CMD -buildmode=plugin
+  # Check build with dynamic linking.
+  ${GC} build -buildmode=plugin
 
   # Check build with tags.
-  [[ -n "$BUILD_TAGS" ]] && $BUILD_CMD $BUILD_TAGS ./...
+  ${GC} build $BUILD_TAGS ./...
 
   # Check build with various architectures.
-  for ARCH in "${ARCHITECTURES[@]}"; do
-    GOOS=linux GOARCH=$ARCH $BUILD_CMD ./...
-  done
+  GOOS=linux GOARCH=386 ${GC} build ./...
+  GOOS=linux GOARCH=arm ${GC} build ./...
+  GOOS=linux GOARCH=arm64 ${GC} build ./...
+  GOOS=linux GOARCH=amd64 ${GC} build ./...
+  GOOS=linux GOARCH=ppc64le ${GC} build ./...
+  GOOS=linux GOARCH=s390x ${GC} build ./...
+
+  # Remove the binaries.
+  rm compilecheck
+  rm compilecheck.so
 
   # Change the directory back to the working directory.
-  popd >/dev/null
+  popd
 }
 
 compile_check
+##!/usr/bin/env bash
+#set -e # exit when any command fails
+#set -x # show all commands being run
+#
+#GC=go
+#COMPILE_CHECK_DIR="internal/cmd/compilecheck"
+#ARCHITECTURES=("386" "arm" "arm64" "ppc64le" "s390x")
+#BUILD_CMD="${GC} build -buildvcs=false"
+#
+## Compilation modules are not part of the workspace as testcontainers requires
+## a version of klauspost/compress not supported by the Go Driver / other modules
+## in the workspace.
+#export GOWORK=off
+#
+## compile_check will attempt to build the internal/test/compilecheck project
+## using the provided Go version. This is to simulate an end-to-end use case.
+#function compile_check {
+#  # Change the directory to the compilecheck test directory.
+#  pushd "${COMPILE_CHECK_DIR}" >/dev/null
+#
+#  ${GC} version
+#  ${GC} mod tidy
+#
+#  # Standard build
+#  $BUILD_CMD ./...
+#
+#  # Dynamic linking
+#  $BUILD_CMD -buildmode=plugin
+#
+#  # Check build with tags.
+#  [[ -n "$BUILD_TAGS" ]] && $BUILD_CMD $BUILD_TAGS ./...
+#
+#  # Check build with various architectures.
+#  for ARCH in "${ARCHITECTURES[@]}"; do
+#    GOOS=linux GOARCH=$ARCH $BUILD_CMD ./...
+#  done
+#
+#  # Change the directory back to the working directory.
+#  popd >/dev/null
+#}
+#
+#compile_check

go.work

@@ -1,4 +1,4 @@
-go 1.23.1
+go 1.22
 
 use (
 	.
@@ -8,6 +8,6 @@ use (
 	./internal/cmd/benchmark
 	./internal/cmd/faas/awslambda/mongodb
 	./internal/test/goleak
-	./internal/test/compilecheck
+	//./internal/test/compilecheck
 	./internal/cmd/compilecheck
 )