Fix new lint failures and drop deprecated linters. (#1055)

Author: matthewdale

.golangci.yml

@@ -5,7 +5,6 @@ linters:
   disable-all: true
   # TODO(GODRIVER-2156): Enable all commented-out linters.
   enable:
-    - deadcode
     - errcheck
     # - errorlint
     - goimports
@@ -18,12 +17,10 @@ linters:
     - nakedret
     - revive
     - staticcheck
-    - structcheck
     - typecheck
     - unused
     - unconvert
     # - unparam
-    - varcheck
 
 linters-settings:
   errcheck:
@@ -65,15 +62,29 @@ issues:
     - path: x/mongo/driver/auth/internal/awsv4
       linters:
         - unused
-        - structcheck
-    # Disable "unused" linter for "crypt.go" because the linter doesn't work correctly without
-    # enabling CGO.
-    - path: x/mongo/driver/crypt.go
+    # Disable "unused" linter for code files that depend on the "mongocrypt.MongoCrypt" type because
+    # the linter build doesn't work correctly with CGO enabled. As a result, all calls to a
+    # "mongocrypt.MongoCrypt" API appear to always panic (see mongocrypt_not_enabled.go), leading
+    # to confusing messages about unused code.
+    - path: x/mongo/driver/crypt.go|mongo/(crypt_retrievers|mongocryptd).go
       linters:
         - unused
     # Ignore "TLS MinVersion too low", "TLS InsecureSkipVerify set true", and "Use of weak random
     # number generator (math/rand instead of crypto/rand)" in tests.
     - path: (.+)_test.go
       text: G401|G402|G404
       linters:
-        - gosec
+        - gosec
+    # Ignore missing comments for exported variable/function/type for code in the "internal" and
+    # "benchmark" directories.
+    - path: (internal\/|benchmark\/)
+      text: exported (.+) should have comment( \(or a comment on this block\))? or be unexported
+    # Ignore missing package comments for directories that aren't frequently used by external users.
+    # TODO(GODRIVER-2517): Remove "mongo/testaws" and "mongo/testatlas" from the ignored paths when
+    # TODO we move those packages to the "cmd/" directory.
+    - path: (internal\/|benchmark\/|x\/|cmd\/|mongo\/integration\/|mongo\/(testaws\/|testatlas\/))
+      text: should have a package comment
+    # Disable unused linter for "golang.org/x/exp/rand" package in internal/randutil/rand.
+    - path: internal/randutil/rand
+      linters:
+        - unused

bson/bsonoptions/doc.go

@@ -0,0 +1,8 @@
+// Copyright (C) MongoDB, Inc. 2022-present.
+//
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License. You may obtain
+// a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+
+// Package bsonoptions defines the optional configurations for the BSON codecs.
+package bsonoptions

bson/bsonrw/bsonrwtest/bsonrwtest.go

@@ -4,6 +4,7 @@
 // not use this file except in compliance with the License. You may obtain
 // a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
 
+// Package bsonrwtest provides utilities for testing the "bson/bsonrw" package.
 package bsonrwtest // import "go.mongodb.org/mongo-driver/bson/bsonrw/bsonrwtest"
 
 import (

internal/testutil/israce/norace.go

@@ -4,6 +4,7 @@
 // not use this file except in compliance with the License. You may obtain
 // a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
 
+//go:build !race
 // +build !race
 
 // Package israce reports if the Go race detector is enabled.

mongo/address/addr.go

@@ -4,6 +4,7 @@
 // not use this file except in compliance with the License. You may obtain
 // a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
 
+// Package address provides structured representations of network addresses.
 package address // import "go.mongodb.org/mongo-driver/mongo/address"
 
 import (

mongo/description/description.go

@@ -4,6 +4,7 @@
 // not use this file except in compliance with the License. You may obtain
 // a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
 
+// Package description contains types and functions for describing the state of MongoDB clusters.
 package description // import "go.mongodb.org/mongo-driver/mongo/description"
 
 // Unknown is an unknown server or topology kind.

mongo/options/doc.go

@@ -0,0 +1,8 @@
+// Copyright (C) MongoDB, Inc. 2022-present.
+//
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License. You may obtain
+// a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+
+// Package options defines the optional configurations for the MongoDB Go Driver.
+package options

mongo/readconcern/readconcern.go

@@ -4,6 +4,7 @@
 // not use this file except in compliance with the License. You may obtain
 // a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
 
+// Package readconcern defines read concerns for MongoDB operations.
 package readconcern // import "go.mongodb.org/mongo-driver/mongo/readconcern"
 
 import (

mongo/readpref/readpref.go

@@ -4,6 +4,7 @@
 // not use this file except in compliance with the License. You may obtain
 // a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
 
+// Package readpref defines read preferences for MongoDB queries.
 package readpref // import "go.mongodb.org/mongo-driver/mongo/readpref"
 
 import (

mongo/writeconcern/writeconcern.go

@@ -4,6 +4,7 @@
 // not use this file except in compliance with the License. You may obtain
 // a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
 
+// Package writeconcern defines write concerns for MongoDB operations.
 package writeconcern // import "go.mongodb.org/mongo-driver/mongo/writeconcern"
 
 import (