Skip to content

Commit d103fea

Browse files
prestonvasquezprestonvasquez
committed
GODRIVER-3445 retryable-reads
1 parent 5dca3f7 commit d103fea

File tree

2 files changed

+45
-5
lines changed

2 files changed

+45
-5
lines changed

‎internal/integration/unified/unified_spec_test.go‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,21 +16,21 @@ import (
1616

1717
var (
1818
passDirectories = []string{
19+
//
20+
//"load-balancers",
21+
//
1922
//spectest.TestPath(3, "unified-test-format", "valid-pass"),
2023
//spectest.TestPath(3, "versioned-api"),
2124
//spectest.TestPath(3, "crud", "unified"),
2225
//spectest.TestPath(3, "change-streams", "unified"),
2326
//spectest.TestPath(3, "transactions", "unified"),
24-
//
25-
//"load-balancers",
26-
//
2727
//spectest.TestPath(3, "collection-management"),
2828
//spectest.TestPath(3, "command-logging-and-monitoring", "monitoring"),
2929
//spectest.TestPath(3, "command-logging-and-monitoring", "logging"),
3030
//spectest.TestPath(3, "connection-monitoring-and-pooling", "cmap-format"),
3131
//spectest.TestPath(3, "connection-monitoring-and-pooling", "logging"),
32-
spectest.TestPath(3, "sessions"),
33-
//"sessions",
32+
//spectest.TestPath(3, "sessions"),
33+
spectest.TestPath(3, "retryable-reads", "unified"),
3434
//"retryable-reads/unified",
3535
//"retryable-writes/unified",
3636
//"client-side-encryption/unified",

‎internal/spectest/skip.go‎

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,46 @@ var skipTests = map[string]string{
263263
"TestUnifiedSpec/transactions/unified/mongos-unpin.json/unpin_when_a_non-transaction_write_operation_uses_a_session": "Implement GODRIVER-3034",
264264
"TestUnifiedSpec/transactions/unified/mongos-unpin.json/unpin_when_a_non-transaction_read_operation_uses_a_session": "Implement GODRIVER-3034",
265265

266+
// TODO(GODRIVER-3146): Convert retryable reads spec tests to unified test
267+
// format.
268+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects-serverErrors.json/ListCollectionObjects_succeeds_after_InterruptedAtShutdown": "Implement GODRIVER-3146",
269+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects-serverErrors.json/ListCollectionObjects_succeeds_after_InterruptedDueToReplStateChange": "Implement GODRIVER-3146",
270+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects-serverErrors.json/ListCollectionObjects_succeeds_after_NotWritablePrimary": "Implement GODRIVER-3146",
271+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects-serverErrors.json/ListCollectionObjects_succeeds_after_NotPrimaryNoSecondaryOk": "Implement GODRIVER-3146",
272+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects-serverErrors.json/ListCollectionObjects_succeeds_after_NotPrimaryOrSecondary": "Implement GODRIVER-3146",
273+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects-serverErrors.json/ListCollectionObjects_succeeds_after_PrimarySteppedDown": "Implement GODRIVER-3146",
274+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects-serverErrors.json/ListCollectionObjects_succeeds_after_ShutdownInProgress": "Implement GODRIVER-3146",
275+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects-serverErrors.json/ListCollectionObjects_succeeds_after_HostNotFound": "Implement GODRIVER-3146",
276+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects-serverErrors.json/ListCollectionObjects_succeeds_after_HostUnreachable": "Implement GODRIVER-3146",
277+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects-serverErrors.json/ListCollectionObjects_succeeds_after_NetworkTimeout": "Implement GODRIVER-3146",
278+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects-serverErrors.json/ListCollectionObjects_succeeds_after_SocketException": "Implement GODRIVER-3146",
279+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects-serverErrors.json/ListCollectionObjects_fails_after_two_NotWritablePrimary_errors": "Implement GODRIVER-3146",
280+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects-serverErrors.json/ListCollectionObjects_fails_after_NotWritablePrimary_when_retryReads_is_false": "Implement GODRIVER-3146",
281+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects.json/ListCollectionObjects_succeeds_on_first_attempt": "Implement GODRIVER-3146",
282+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects.json/ListCollectionObjects_succeeds_on_second_attempt": "Implement GoDRIVER-3146",
283+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects.json/ListCollectionObjects_fails_on_first_attempt": "Implement GoDRIVER-3146",
284+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listCollectionObjects.json/ListCollectionObjects_fails_on_second_attempt": "Implement GoDRIVER-3146",
285+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects-serverErrors.json/ListDatabaseObjects_succeeds_after_InterruptedAtShutdown": "Implement GODRIVER-3146",
286+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects-serverErrors.json/ListDatabaseObjects_succeeds_after_InterruptedDueToReplStateChange": "Implement GODRIVER-3146",
287+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects-serverErrors.json/ListDatabaseObjects_succeeds_after_NotWritablePrimary": "Implement GODRIVER-3146",
288+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects-serverErrors.json/ListDatabaseObjects_succeeds_after_NotPrimaryNoSecondaryOk": "Implement GODRIVER-3146",
289+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects-serverErrors.json/ListDatabaseObjects_succeeds_after_NotPrimaryOrSecondary": "Implement GODRIVER-3146",
290+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects-serverErrors.json/ListDatabaseObjects_succeeds_after_PrimarySteppedDown": "Implement GODRIVER-3146",
291+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects-serverErrors.json/ListDatabaseObjects_succeeds_after_ShutdownInProgress": "Implement GODRIVER-3146",
292+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects-serverErrors.json/ListDatabaseObjects_succeeds_after_HostNotFound": "Implement GODRIVER-3146",
293+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects-serverErrors.json/ListDatabaseObjects_succeeds_after_HostUnreachable": "Implement GODRIVER-3146",
294+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects-serverErrors.json/ListDatabaseObjects_succeeds_after_NetworkTimeout": "Implement GODRIVER-3146",
295+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects-serverErrors.json/ListDatabaseObjects_succeeds_after_SocketException": "Implement GODRIVER-3146",
296+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects-serverErrors.json/ListDatabaseObjects_fails_after_two_NotWritablePrimary_errors": "Implement GODRIVER-3146",
297+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects-serverErrors.json/ListDatabaseObjects_fails_after_NotWritablePrimary_when_retryReads_is_false": "Implement GODRIVER-3146",
298+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects.json/ListDatabaseObjects_succeeds_on_first_attempt": "Implement GODRIVER-3146",
299+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects.json/ListDatabaseObjects_succeeds_on_second_attempt": "Implement GODRIVER-3146",
300+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects.json/ListDatabaseObjects_fails_on_first_attempt": "Implement GODRIVER-3146",
301+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/listDatabaseObjects.json/ListDatabaseObjects_fails_on_second_attempt": "Implement GODRIVER-3146",
302+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/mapReduce.json/MapReduce_succeeds_with_retry_on": "Implement GODRIVER-3146",
303+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/mapReduce.json/MapReduce_fails_with_retry_on": "Implement GODRIVER-3146",
304+
"TestUnifiedSpec/specifications/source/retryable-reads/tests/unified/mapReduce.json/MapReduce_fails_with_retry_off": "Implement GODRIVER-3146",
305+
266306
// DRIVERS-2722: Setting "maxTimeMS" on a command that creates a cursor also
267307
// limits the lifetime of the cursor. That may be surprising to users, so
268308
// omit "maxTimeMS" from operations that return user-managed cursors.

0 commit comments

Comments
 (0)